A local-first personal finance app
:fire: (preferences) remove unused user prefs (#3104)
Matiss Janis Aboltins0135a4d1b90b
diff --git a/packages/desktop-client/src/components/App.tsx b/packages/desktop-client/src/components/App.tsxindex 6135c28b91..b6e86047d3 100644--- a/packages/desktop-client/src/components/App.tsx+++ b/packages/desktop-client/src/components/App.tsx@@ -33,7 +33,6 @@ import { DevelopmentTopBar } from './DevelopmentTopBar';import { FatalError } from './FatalError';import { FinancesApp } from './FinancesApp';import { ManagementApp } from './manager/ManagementApp';-import { MobileWebMessage } from './mobile/MobileWebMessage';import { UpdateNotification } from './UpdateNotification';type AppInnerProps = {@@ -124,7 +123,6 @@ function AppInner({ budgetId, cloudFileId }: AppInnerProps) {))}<UpdateNotification />- <MobileWebMessage /></>);}diff --git a/packages/desktop-client/src/components/mobile/MobileWebMessage.tsx b/packages/desktop-client/src/components/mobile/MobileWebMessage.tsxdeleted file mode 100644index edf8d5ad0b..0000000000--- a/packages/desktop-client/src/components/mobile/MobileWebMessage.tsx+++ /dev/null@@ -1,107 +0,0 @@-import React, { useState } from 'react';--import { useLocalPref } from '../../hooks/useLocalPref';-import { useResponsive } from '../../ResponsiveProvider';-import { theme, styles } from '../../style';-import { Button } from '../common/Button';-import { Text } from '../common/Text';-import { View } from '../common/View';-import { Checkbox } from '../forms';--const buttonStyle = { border: 0, fontSize: 15, padding: '10px 13px' };--export function MobileWebMessage() {- const [hideMobileMessage = true, setHideMobileMessagePref] =- useLocalPref('hideMobileMessage');-- const { isNarrowWidth } = useResponsive();-- const [show, setShow] = useState(- isNarrowWidth &&- !hideMobileMessage &&- !document.cookie.match(/hideMobileMessage=true/),- );- const [requestDontRemindMe, setRequestDontRemindMe] = useState(false);-- function onTry() {- setShow(false);-- if (requestDontRemindMe) {- // remember the pref indefinitely- setHideMobileMessagePref(true);- } else {- // Set a cookie for 5 minutes- const d = new Date();- d.setTime(d.getTime() + 1000 * 60 * 5);- document.cookie =- 'hideMobileMessage=true;path=/;expires=' + d.toUTCString();- }- }-- if (!show) {- return null;- }-- return (- <View- style={{- position: 'absolute',- bottom: 0,- left: 0,- right: 0,- backgroundColor: theme.menuAutoCompleteBackground,- color: theme.menuAutoCompleteText,- padding: 10,- margin: 10,- borderRadius: 6,- zIndex: 10000,- fontSize: 15,- ...styles.shadowLarge,- }}- >- <Text style={{ lineHeight: '1.5em' }}>- <strong>Actual features are limited on small screens.</strong>- <br />- <span>- While we work to improve this experience, you may find the full Actual- feature set on devices with larger screens.- </span>- </Text>-- <View- style={{- gap: 16,- marginTop: 20,- justifyContent: 'center',- }}- >- <Button style={buttonStyle} onClick={onTry}>- Try it anyway- </Button>- <View- style={{- alignItems: 'center',- flexDirection: 'row',- justifyContent: 'flex-end',- }}- >- <Checkbox- id="dont_remind_me"- checked={requestDontRemindMe}- onChange={() => {- setRequestDontRemindMe(!requestDontRemindMe);- }}- />- <label- htmlFor="dont_remind_me"- style={{- userSelect: 'none',- }}- >- Don’t remind me again- </label>- </View>- </View>- </View>- );-}diff --git a/packages/loot-core/src/mocks/budget.ts b/packages/loot-core/src/mocks/budget.tsindex b9d21aec1f..82019aa0b4 100644--- a/packages/loot-core/src/mocks/budget.ts+++ b/packages/loot-core/src/mocks/budget.ts@@ -5,7 +5,6 @@ import * as budgetActions from '../server/budget/actions';import * as budget from '../server/budget/base';import * as db from '../server/db';import { runHandler, runMutator } from '../server/mutators';-import * as prefs from '../server/prefs';import * as sheet from '../server/sheet';import { batchMessages, setSyncingMode } from '../server/sync';import * as monthUtils from '../shared/months';@@ -735,7 +734,6 @@ export async function createTestBudget(handlers: Handlers) {// Bust the cache and reload the spreadsheetsetSyncingMode('disabled');- await prefs.savePrefs({ isCached: false });await sheet.reloadSpreadsheet(db);await budget.createAllBudgets();diff --git a/packages/loot-core/src/types/prefs.d.ts b/packages/loot-core/src/types/prefs.d.tsindex 2ce56c31c7..a8a1dbfca3 100644--- a/packages/loot-core/src/types/prefs.d.ts+++ b/packages/loot-core/src/types/prefs.d.ts@@ -18,8 +18,6 @@ export type LocalPrefs = Partial<| 'dd.MM.yyyy';numberFormat: (typeof numberFormats)[number]['value'];hideFraction: boolean;- hideClosedAccounts: boolean;- hideMobileMessage: boolean;isPrivacyEnabled: boolean;budgetName: string;'ui.showClosedAccounts': boolean;@@ -40,7 +38,6 @@ export type LocalPrefs = Partial<[key: `flip-amount-${string}-${'csv' | 'qif'}`]: boolean;'flags.updateNotificationShownForVersion': string;id: string;- isCached: boolean;lastUploaded: string;cloudFileId: string;groupId: string;diff --git a/upcoming-release-notes/3104.md b/upcoming-release-notes/3104.mdnew file mode 100644index 0000000000..37e1c49ba2--- /dev/null+++ b/upcoming-release-notes/3104.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Delete unused user preferences.