Skip to content

A local-first personal finance app

Fix title first null undefined (#4908)

Alec Bakholdin04da20e34c4a
diff --git a/packages/loot-core/src/shared/util.test.ts b/packages/loot-core/src/shared/util.test.ts
index 63a599e629..c17f84ebb0 100644
--- a/packages/loot-core/src/shared/util.test.ts
+++ b/packages/loot-core/src/shared/util.test.ts
@@ -3,6 +3,7 @@ import {
getNumberFormat,
setNumberFormat,
currencyToAmount,
+ titleFirst,
} from './util';
describe('utility functions', () => {
@@ -172,4 +173,12 @@ describe('utility functions', () => {
expect(currencyToAmount('3.000')).toBe(3000);
expect(currencyToAmount('3.000,')).toBe(3000);
});
+
+ test('titleFirst works with all inputs', () => {
+ expect(titleFirst('')).toBe('');
+ expect(titleFirst(undefined)).toBe('');
+ expect(titleFirst(null)).toBe('');
+ expect(titleFirst('a')).toBe('A');
+ expect(titleFirst('abc')).toBe('Abc');
+ });
});
diff --git a/packages/loot-core/src/shared/util.ts b/packages/loot-core/src/shared/util.ts
index 3448da148e..9b537a1ead 100644
--- a/packages/loot-core/src/shared/util.ts
+++ b/packages/loot-core/src/shared/util.ts
@@ -204,7 +204,10 @@ export function fastSetMerge<T>(set1: Set<T>, set2: Set<T>) {
return finalSet;
}
-export function titleFirst(str: string) {
+export function titleFirst(str: string | null | undefined) {
+ if (!str || str.length <= 1) {
+ return str?.toUpperCase() ?? '';
+ }
return str[0].toUpperCase() + str.slice(1);
}
diff --git a/upcoming-release-notes/4908.md b/upcoming-release-notes/4908.md
new file mode 100644
index 0000000000..8ecd18fb6c
--- /dev/null
+++ b/upcoming-release-notes/4908.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [alecbakholdin]
+---
+
+Fixed undefined reference in utils titleFirst function