A local-first personal finance app
Ported NewAutocomplete to TypeScript (#831)
Matiss Janis Aboltins072c3504fe79
diff --git a/packages/desktop-client/src/components/autocomplete/NewAutocomplete.js b/packages/desktop-client/src/components/autocomplete/NewAutocomplete.tsxsimilarity index 82%rename from packages/desktop-client/src/components/autocomplete/NewAutocomplete.jsrename to packages/desktop-client/src/components/autocomplete/NewAutocomplete.tsxindex d082c07b56..f01fc128ba 100644--- a/packages/desktop-client/src/components/autocomplete/NewAutocomplete.js+++ b/packages/desktop-client/src/components/autocomplete/NewAutocomplete.tsx@@ -1,5 +1,10 @@import React, { useState } from 'react';-import Select from 'react-select';+import Select, {+ Props as SelectProps,+ PropsValue,+ SingleValue,+ SelectInstance,+} from 'react-select';import CreatableSelect from 'react-select/creatable';@@ -7,7 +12,17 @@ import { NullComponent } from '../common';import styles from './autocomplete-styles';-const Autocomplete = React.forwardRef(+type OptionValue = string;++interface AutocompleteProps extends SelectProps<OptionValue> {+ focused: boolean;+ embedded: boolean;+ onSelect: (value: PropsValue<OptionValue>) => void;+ onCreateOption: (value: SingleValue<OptionValue>) => void;+ isCreatable: boolean;+}++const Autocomplete = React.forwardRef<SelectInstance, AutocompleteProps>(({value,@@ -96,7 +111,7 @@ const Autocomplete = React.forwardRef(}}maxMenuHeight={200}styles={styles}- embedded={embedded}+ data-embedded={embedded}menuPlacement="auto"menuPortalTarget={embedded ? undefined : document.body}{...props}diff --git a/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js b/packages/desktop-client/src/components/autocomplete/autocomplete-styles.jsindex 858f0e5cd3..3c7acdcdb4 100644--- a/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js+++ b/packages/desktop-client/src/components/autocomplete/autocomplete-styles.js@@ -29,7 +29,7 @@ const colourStyles = {backgroundColor: colors.n1,marginTop: 2,marginBottom: 2,- position: selectProps.embedded ? 'relative' : styles.position,+ position: selectProps['data-embedded'] ? 'relative' : styles.position,overflow: 'hidden',}),menuList: styles => ({diff --git a/upcoming-release-notes/831.md b/upcoming-release-notes/831.mdnew file mode 100644index 0000000000..9438182e43--- /dev/null+++ b/upcoming-release-notes/831.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Moved `NewAutocomplete` component to TypeScript