A local-first personal finance app
Always show stacked bar graph tooltip label on hover (#8356)
Darwin Do09a6d9badd31
diff --git a/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx b/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsxindex 4b130b9c5e..43f8e88a1c 100644--- a/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx+++ b/packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx@@ -89,6 +89,19 @@ const CustomTooltip = ({);}, [payload]);+ const maxTooltipItems = 5;++ const visibleItems = useMemo(() => {+ const nonZero = items.filter(p => p.value !== 0);+ if (!compact || nonZero.length <= maxTooltipItems) return nonZero;++ const hoveredIndex = nonZero.findIndex(p => tooltip === p.name);+ if (hoveredIndex >= maxTooltipItems) {+ return [...nonZero.slice(0, maxTooltipItems - 1), nonZero[hoveredIndex]];+ }+ return nonZero.slice(0, maxTooltipItems);+ }, [compact, items, tooltip]);+if (active && items.length) {return (<div@@ -107,29 +120,26 @@ const CustomTooltip = ({<strong>{label}</strong></div><div style={{ lineHeight: 1.4 }}>- {items.map((pay, i) => {+ {visibleItems.map(pay => {const displayName = dataKeyToName.get(pay.name) ?? pay.name;return (- pay.value !== 0 &&- (compact ? i < 5 : true) && (- <AlignedText- key={pay.name}- left={displayName}- right={- <FinancialText>- {format(pay.value, 'financial')}- </FinancialText>- }- style={{- color: pay.color,- textDecoration:- tooltip === pay.name ? 'underline' : 'inherit',- }}- />- )+ <AlignedText+ key={pay.name}+ left={displayName}+ right={+ <FinancialText>+ {format(pay.value, 'financial')}+ </FinancialText>+ }+ style={{+ color: pay.color,+ textDecoration:+ tooltip === pay.name ? 'underline' : 'inherit',+ }}+ />);})}- {payload.length > 5 && compact && '...'}+ {compact && items.length > visibleItems.length && '...'}<AlignedTextleft={t('Total')}right={diff --git a/upcoming-release-notes/fix-stacked-bar-tooltip.md b/upcoming-release-notes/fix-stacked-bar-tooltip.mdnew file mode 100644index 0000000000..ce27716ff4--- /dev/null+++ b/upcoming-release-notes/fix-stacked-bar-tooltip.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [dsmaugy]+---++Shows label name of hovered stacked bar chart group even if the label would have been hidden in compact mode