A local-first personal finance app
Update tooltip and themes with better visibility (#3298)
Robert Dyer09e37210363b
diff --git a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.pngindex 9ca9b75d80..16d68748eb 100644Binary files a/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png and b/packages/desktop-client/e2e/schedules.test.js-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-1-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-1-chromium-linux.pngindex a099f6a117..fbac8396fa 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-1-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.pngindex 1b27a5bcb6..cd6cc7d544 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-3-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-3-chromium-linux.pngindex 8fc889f31b..5ec0c0efbc 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-3-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-3-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.pngindex 5845d8e035..40a92b53ef 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.pngindex 7a8f47d163..5badb70080 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-5-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.pngindex 7eeb40c65c..92ea7af503 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-6-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-1-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-1-chromium-linux.pngindex d4e06b7190..a47ce4466a 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-1-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.pngindex 41217fa688..5f331e9c87 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-3-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-3-chromium-linux.pngindex 114182fbba..f0b387c762 100644Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-3-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-3-chromium-linux.png differdiff --git a/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx b/packages/desktop-client/src/components/autocomplete/Autocomplete.tsxindex 8eb90dd5d7..ffc5ae5479 100644--- a/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx+++ b/packages/desktop-client/src/components/autocomplete/Autocomplete.tsx@@ -576,6 +576,7 @@ function SingleAutocomplete<T extends Item>({isNonModalstyle={{...styles.darkScrollbar,+ ...styles.popover,backgroundColor: theme.menuAutoCompleteBackground,color: theme.menuAutoCompleteText,minWidth: 200,diff --git a/packages/desktop-client/src/components/select/DateSelect.tsx b/packages/desktop-client/src/components/select/DateSelect.tsxindex 729c9d3bf7..6d08b517d8 100644--- a/packages/desktop-client/src/components/select/DateSelect.tsx+++ b/packages/desktop-client/src/components/select/DateSelect.tsx@@ -27,7 +27,7 @@ import {import { stringToInteger } from 'loot-core/src/shared/util';import { useSyncedPref } from '../../hooks/useSyncedPref';-import { theme } from '../../style';+import { styles, theme } from '../../style';import { Input } from '../common/Input';import { Popover } from '../common/Popover';import { View } from '../common/View';@@ -335,7 +335,7 @@ export function DateSelect({isOpen={open}isNonModalonOpenChange={() => setOpen(false)}- style={{ minWidth: 225 }}+ style={{ ...styles.popover, minWidth: 225 }}data-testid="date-select-tooltip">{content}diff --git a/packages/desktop-client/src/style/styles.ts b/packages/desktop-client/src/style/styles.tsindex 0bd0242a4e..d90ae062f7 100644--- a/packages/desktop-client/src/style/styles.ts+++ b/packages/desktop-client/src/style/styles.ts@@ -131,10 +131,18 @@ export const styles = {tooltip: {padding: 5,...shadowLarge,+ borderWidth: 2,borderRadius: 4,+ borderStyle: 'solid',+ borderColor: theme.tooltipBorder,+ backgroundColor: theme.tooltipBackground,+ color: theme.tooltipText,+ overflow: 'auto',+ },+ popover: {+ border: 'none',backgroundColor: theme.menuBackground,color: theme.menuItemText,- overflow: 'auto',},// Dynamically sethorizontalScrollbar: null as CSSProperties | null,diff --git a/packages/desktop-client/src/style/themes/dark.ts b/packages/desktop-client/src/style/themes/dark.tsindex fcd19fb4a8..38aa2a88cb 100644--- a/packages/desktop-client/src/style/themes/dark.ts+++ b/packages/desktop-client/src/style/themes/dark.ts@@ -206,3 +206,7 @@ export const budgetHeaderCurrentMonth = tableHeaderBackground;export const floatingActionBarBackground = colorPalette.purple800;export const floatingActionBarBorder = floatingActionBarBackground;export const floatingActionBarText = colorPalette.navy150;++export const tooltipText = colorPalette.navy100;+export const tooltipBackground = colorPalette.navy800;+export const tooltipBorder = colorPalette.navy700;diff --git a/packages/desktop-client/src/style/themes/development.ts b/packages/desktop-client/src/style/themes/development.tsindex b3a6a69862..b379c2172e 100644--- a/packages/desktop-client/src/style/themes/development.ts+++ b/packages/desktop-client/src/style/themes/development.ts@@ -205,3 +205,7 @@ export const budgetHeaderOtherMonth = colorPalette.gray80;export const floatingActionBarBackground = colorPalette.purple400;export const floatingActionBarBorder = floatingActionBarBackground;export const floatingActionBarText = colorPalette.navy50;++export const tooltipText = colorPalette.navy900;+export const tooltipBackground = colorPalette.navy50;+export const tooltipBorder = colorPalette.navy150;diff --git a/packages/desktop-client/src/style/themes/light.ts b/packages/desktop-client/src/style/themes/light.tsindex aad174b850..ca1b2a6f4a 100644--- a/packages/desktop-client/src/style/themes/light.ts+++ b/packages/desktop-client/src/style/themes/light.ts@@ -208,3 +208,7 @@ export const budgetHeaderOtherMonth = colorPalette.gray80;export const floatingActionBarBackground = colorPalette.purple400;export const floatingActionBarBorder = floatingActionBarBackground;export const floatingActionBarText = colorPalette.navy50;++export const tooltipText = colorPalette.navy900;+export const tooltipBackground = colorPalette.white;+export const tooltipBorder = colorPalette.navy150;diff --git a/packages/desktop-client/src/style/themes/midnight.ts b/packages/desktop-client/src/style/themes/midnight.tsindex 8869a2ba59..f851e7163c 100644--- a/packages/desktop-client/src/style/themes/midnight.ts+++ b/packages/desktop-client/src/style/themes/midnight.ts@@ -208,3 +208,7 @@ export const budgetHeaderCurrentMonth = tableHeaderBackground;export const floatingActionBarBackground = colorPalette.gray900;export const floatingActionBarBorder = colorPalette.purple300;export const floatingActionBarText = colorPalette.purple200;++export const tooltipText = colorPalette.gray100;+export const tooltipBackground = colorPalette.gray800;+export const tooltipBorder = colorPalette.gray600;diff --git a/upcoming-release-notes/3298.md b/upcoming-release-notes/3298.mdnew file mode 100644index 0000000000..ead0ec5d87--- /dev/null+++ b/upcoming-release-notes/3298.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [VoltaicGRiD, psybers]+---++Implement greater visibility and accessibility on popover menus and tooltips.\ No newline at end of file