A local-first personal finance app
Fix lint violations (vol.3) (#6301)
Matiss Janis Aboltins0aa96ecaee91
diff --git a/.github/actions/docs-spelling/allow/keywords.txt b/.github/actions/docs-spelling/allow/keywords.txtindex c2b8fadf3a..21b014e318 100644--- a/.github/actions/docs-spelling/allow/keywords.txt+++ b/.github/actions/docs-spelling/allow/keywords.txt@@ -101,6 +101,8 @@ offbudgetofxOFXoneof+oxfmt+oxlintpayeerulepikadaypikapodsdiff --git a/.oxlintrc.json b/.oxlintrc.jsonindex 22caa3bc1f..0186281c46 100644--- a/.oxlintrc.json+++ b/.oxlintrc.json@@ -2,15 +2,12 @@"$schema": "./node_modules/oxlint/configuration_schema.json","plugins": ["react", "typescript", "import", "jsx-a11y"],"rules": {+ "jsx-a11y/no-autofocus": ["warn", { "ignoreNonDOM": true }],+// TODO fix all these and re-enable- "jsx-a11y/alt-text": "off",- "jsx-a11y/aria-role": "off","jsx-a11y/click-events-have-key-events": "off",- "jsx-a11y/label-has-associated-control": "off","jsx-a11y/prefer-tag-over-role": "off",- "jsx-a11y/role-has-required-aria-props": "off","jsx-a11y/tabindex-no-positive": "off",- "no-autofocus": "off",},"overrides": [{diff --git a/packages/component-library/src/Toggle.tsx b/packages/component-library/src/Toggle.tsxindex ee055edf8b..dd00190258 100644--- a/packages/component-library/src/Toggle.tsx+++ b/packages/component-library/src/Toggle.tsx@@ -36,6 +36,7 @@ export const Toggle = ({})}type="checkbox"/>+ {/* oxlint-disable-next-line eslint-plugin-jsx-a11y(label-has-associated-control) */}<labeldata-toggle-containerdata-on={isOn}diff --git a/packages/desktop-client/src/components/Page.tsx b/packages/desktop-client/src/components/Page.tsxindex 89920cea6a..65c60e6e72 100644--- a/packages/desktop-client/src/components/Page.tsx+++ b/packages/desktop-client/src/components/Page.tsx@@ -78,6 +78,7 @@ export function MobilePageHeader({</View><Viewrole="heading"+ aria-level={1}style={{textAlign: 'center',alignItems: 'center',diff --git a/packages/desktop-client/src/components/common/Modal.tsx b/packages/desktop-client/src/components/common/Modal.tsxindex f0cd6ed4cd..960b5bd584 100644--- a/packages/desktop-client/src/components/common/Modal.tsx+++ b/packages/desktop-client/src/components/common/Modal.tsx@@ -315,6 +315,7 @@ export function ModalHeader({return (<Viewrole="heading"+ aria-level={1}style={{justifyContent: 'center',alignItems: 'center',diff --git a/packages/desktop-client/src/components/modals/EditAccess.tsx b/packages/desktop-client/src/components/modals/EditAccess.tsxindex 61f52c727f..e65f834a21 100644--- a/packages/desktop-client/src/components/modals/EditAccess.tsx+++ b/packages/desktop-client/src/components/modals/EditAccess.tsx@@ -112,7 +112,7 @@ export function EditUserAccess({onChange={(newValue: string) => setUserId(newValue)}value={userId}/>- <label+ <Textstyle={{...styles.verySmallText,color: theme.pageTextLight,@@ -120,7 +120,7 @@ export function EditUserAccess({}}><Trans>Select a user from the directory</Trans>- </label>+ </Text></View>)}{availableUsers.length === 0 && (diff --git a/packages/desktop-client/src/components/modals/EditUser.tsx b/packages/desktop-client/src/components/modals/EditUser.tsxindex cdc8f45118..c15ae4c9ea 100644--- a/packages/desktop-client/src/components/modals/EditUser.tsx+++ b/packages/desktop-client/src/components/modals/EditUser.tsx@@ -221,7 +221,7 @@ function EditUser({ defaultUser, onSave: originalOnSave }: EditUserProps) {borderColor: theme.buttonMenuBorder,}}/>- <label+ <Textstyle={{...styles.verySmallText,color: theme.pageTextLight,@@ -229,7 +229,7 @@ function EditUser({ defaultUser, onSave: originalOnSave }: EditUserProps) {}}><Trans>The username registered within the OpenID provider.</Trans>- </label>+ </Text></FormField><Viewstyle={{@@ -254,7 +254,7 @@ function EditUser({ defaultUser, onSave: originalOnSave }: EditUserProps) {</View></SpaceBetween>{isOwner && (- <label+ <Textstyle={{...styles.verySmallText,color: theme.errorText,@@ -264,7 +264,7 @@ function EditUser({ defaultUser, onSave: originalOnSave }: EditUserProps) {<Trans>Change this username with caution; it is the server owner.</Trans>- </label>+ </Text>)}<SpaceBetween style={{ marginTop: 10 }}><FormField style={{ flex: 1 }}>@@ -365,7 +365,7 @@ const RoleDescription = () => {</Trans></Text><View style={{ paddingTop: 5 }}>- <label+ <Textstyle={{...styles.altMenuHeaderText,...styles.verySmallText,@@ -373,7 +373,7 @@ const RoleDescription = () => {}}><Trans>Basic</Trans>- </label>+ </Text><Textstyle={{...styles.verySmallText,@@ -398,7 +398,7 @@ const RoleDescription = () => {</Text></View><View style={{ paddingTop: 10 }}>- <label+ <Textstyle={{...styles.altMenuHeaderText,...styles.verySmallText,@@ -406,7 +406,7 @@ const RoleDescription = () => {}}><Trans>Admin</Trans>- </label>+ </Text><Textstyle={{...styles.verySmallText,diff --git a/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx b/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsxindex 3ea99a587f..4a6cded221 100644--- a/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx+++ b/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx@@ -970,6 +970,7 @@ export function ImportTransactionsModal({<View style={{ marginLeft: 10, gap: 5 }}><SectionLabel title={t('CSV OPTIONS')} /><label+ htmlFor="csv-delimiter-select"style={{display: 'flex',flexDirection: 'row',@@ -979,6 +980,7 @@ export function ImportTransactionsModal({><Trans>Delimiter:</Trans><Select+ id="csv-delimiter-select"options={[[',', ','],[';', ';'],@@ -994,6 +996,7 @@ export function ImportTransactionsModal({/></label><label+ htmlFor="csv-skip-start-lines"style={{display: 'flex',flexDirection: 'row',@@ -1003,6 +1006,7 @@ export function ImportTransactionsModal({><Trans>Skip start lines:</Trans><Input+ id="csv-skip-start-lines"type="number"value={skipStartLines}min="0"@@ -1014,6 +1018,7 @@ export function ImportTransactionsModal({/></label><label+ htmlFor="csv-skip-end-lines"style={{display: 'flex',flexDirection: 'row',@@ -1023,6 +1028,7 @@ export function ImportTransactionsModal({><Trans>Skip end lines:</Trans><Input+ id="csv-skip-end-lines"type="number"value={skipEndLines}min="0"diff --git a/packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx b/packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsxindex e41774d82e..48bfe82afb 100644--- a/packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx+++ b/packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx@@ -1,5 +1,5 @@import React, { useState, useRef, useEffect, useCallback } from 'react';-import { Trans } from 'react-i18next';+import { Trans, useTranslation } from 'react-i18next';import { Button } from '@actual-app/components/button';import { Paragraph } from '@actual-app/components/paragraph';@@ -31,6 +31,7 @@ export function MergeUnusedPayeesModal({payeeIds,targetPayeeId,}: MergeUnusedPayeesModalProps) {+ const { t } = useTranslation();const allPayees = usePayees();const modalStack = useSelector(state => state.modals.modalStack);const isEditingRule = !!modalStack.find(m => m.name === 'edit-rule');@@ -177,6 +178,9 @@ export function MergeUnusedPayeesModal({alignItems: 'center',justifyContent: 'center',}}+ aria-label={t(+ 'Automatically rename these payees in the future',+ )}><inputtype="checkbox"@@ -184,9 +188,7 @@ export function MergeUnusedPayeesModal({onChange={e => setShouldCreateRule(e.target.checked)}/><Text style={{ marginLeft: 3 }}>- <Trans count={payees.length}>- Automatically rename these payees in the future- </Trans>+ <Trans>Automatically rename these payees in the future</Trans></Text></label>)}diff --git a/packages/desktop-client/src/components/modals/TransferOwnership.tsx b/packages/desktop-client/src/components/modals/TransferOwnership.tsxindex e810912798..4ffecdbe0e 100644--- a/packages/desktop-client/src/components/modals/TransferOwnership.tsx+++ b/packages/desktop-client/src/components/modals/TransferOwnership.tsx@@ -125,7 +125,7 @@ export function TransferOwnership({value={userId}defaultLabel={t('Select a user')}/>- <label+ <Textstyle={{...styles.verySmallText,color: theme.pageTextLight,@@ -136,8 +136,8 @@ export function TransferOwnership({Select a user from the directory to designate as the newbudget owner.</Trans>- </label>- <label+ </Text>+ <Textstyle={{...styles.verySmallText,color: theme.errorText,@@ -147,8 +147,8 @@ export function TransferOwnership({{t('This action is irreversible, ownership of this budget file will only be able to be transferred by the server administrator or new owner.',)}- </label>- <label+ </Text>+ <Textstyle={{...styles.verySmallText,color: theme.errorText,@@ -156,7 +156,7 @@ export function TransferOwnership({}}><Trans>Proceed with caution.</Trans>- </label>+ </Text></View>)}{availableUsers.length === 0 && (diff --git a/packages/desktop-client/src/components/reports/FormulaResult.tsx b/packages/desktop-client/src/components/reports/FormulaResult.tsxindex 9c79ff258c..4166f3f43a 100644--- a/packages/desktop-client/src/components/reports/FormulaResult.tsx+++ b/packages/desktop-client/src/components/reports/FormulaResult.tsx@@ -144,7 +144,6 @@ export function FormulaResult({{!loading && (<Viewref={mergedRef as Ref<HTMLDivElement>}- role="text"aria-label={displayValue}style={{alignItems: 'center',diff --git a/packages/desktop-client/src/components/reports/ReportCardName.tsx b/packages/desktop-client/src/components/reports/ReportCardName.tsxindex bad6685f07..d5b64d29fb 100644--- a/packages/desktop-client/src/components/reports/ReportCardName.tsx+++ b/packages/desktop-client/src/components/reports/ReportCardName.tsx@@ -48,6 +48,7 @@ export const ReportCardName = ({marginBottom: 5,}}role="heading"+ aria-level={2}>{name}</Block>diff --git a/packages/desktop-client/src/components/reports/SummaryNumber.tsx b/packages/desktop-client/src/components/reports/SummaryNumber.tsxindex f011ab0191..e1aea30509 100644--- a/packages/desktop-client/src/components/reports/SummaryNumber.tsx+++ b/packages/desktop-client/src/components/reports/SummaryNumber.tsx@@ -74,7 +74,6 @@ export function SummaryNumber({{!loading && (<Viewref={mergedRef as Ref<HTMLDivElement>}- role="text"aria-label={value < 0? t('Negative amount: {{amount}}', { amount: displayAmount })diff --git a/packages/desktop-client/src/components/settings/AuthSettings.tsx b/packages/desktop-client/src/components/settings/AuthSettings.tsxindex e8a5803794..ed3a813118 100644--- a/packages/desktop-client/src/components/settings/AuthSettings.tsx+++ b/packages/desktop-client/src/components/settings/AuthSettings.tsx@@ -84,11 +84,11 @@ export function AuthSettings() {<Trans>Disable OpenID</Trans></Button>{multiuserEnabled && (- <label style={{ paddingTop: 5, color: theme.errorText }}>+ <Text style={{ paddingTop: 5, color: theme.errorText }}><Trans>Disabling OpenID will deactivate multi-user mode.</Trans>- </label>+ </Text>)}</>)}diff --git a/packages/docs/src/components/Image.jsx b/packages/docs/src/components/Image.jsxindex 12be30d4ef..0af899daaa 100644--- a/packages/docs/src/components/Image.jsx+++ b/packages/docs/src/components/Image.jsx@@ -51,6 +51,7 @@ export default function Image({ img, ...props }) {}return <IdealImage img={img} theme={theme} {...props} />;} else {+ // oxlint-disable-next-line alt-textreturn <img {...props} />;}}diff --git a/upcoming-release-notes/6301.md b/upcoming-release-notes/6301.mdnew file mode 100644index 0000000000..af9df23171--- /dev/null+++ b/upcoming-release-notes/6301.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Fix more lint issues