A local-first personal finance app
Unflag custom reports (#2554)
Neil0c14eb17c49d
diff --git a/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png b/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.pngindex f74f8505bc..5d70d3923a 100644Binary files a/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png and b/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png b/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.pngindex 1098fafea7..a21db20c60 100644Binary files a/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png and b/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.png b/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.pngindex 355c6e0031..2021bf6585 100644Binary files a/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.png and b/packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.png differdiff --git a/packages/desktop-client/src/components/reports/Overview.tsx b/packages/desktop-client/src/components/reports/Overview.tsxindex c8138187a7..b2714d154a 100644--- a/packages/desktop-client/src/components/reports/Overview.tsx+++ b/packages/desktop-client/src/components/reports/Overview.tsx@@ -25,7 +25,6 @@ export function Overview() {const location = useLocation();sessionStorage.setItem('url', location.pathname);- const customReportsFeatureFlag = useFeatureFlag('customReports');const spendingReportFeatureFlag = useFeatureFlag('spendingReport');const accounts = useAccounts();@@ -43,7 +42,7 @@ export function Overview() {}}><PageHeader title="Reports" />- {customReportsFeatureFlag && !isNarrowWidth && (+ {!isNarrowWidth && (<Link to="/reports/custom" style={{ textDecoration: 'none' }}><Button type="primary"><Text>Create new custom report</Text>@@ -66,9 +65,7 @@ export function Overview() {<CashFlowCard />{spendingReportFeatureFlag && <SpendingCard />}</View>- {customReportsFeatureFlag && (- <CustomReportListCards reports={customReports} />- )}+ <CustomReportListCards reports={customReports} /></Page>);}diff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsxindex 4b809341ff..79cc91ccb1 100644--- a/packages/desktop-client/src/components/settings/Experimental.tsx+++ b/packages/desktop-client/src/components/settings/Experimental.tsx@@ -79,7 +79,6 @@ export function ExperimentalFeatures() {primaryAction={expanded ? (<View style={{ gap: '1em' }}>- <FeatureToggle flag="customReports">Custom reports</FeatureToggle><FeatureToggle flag="spendingReport">Monthly spending</FeatureToggle>diff --git a/packages/desktop-client/src/hooks/useFeatureFlag.ts b/packages/desktop-client/src/hooks/useFeatureFlag.tsindex 0089686be5..689b3772e7 100644--- a/packages/desktop-client/src/hooks/useFeatureFlag.ts+++ b/packages/desktop-client/src/hooks/useFeatureFlag.ts@@ -6,7 +6,6 @@ import type { FeatureFlag } from 'loot-core/src/types/prefs';const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {reportBudget: false,goalTemplatesEnabled: false,- customReports: false,spendingReport: false,simpleFinSync: false,iterableTopologicalSort: true,diff --git a/packages/loot-core/src/types/prefs.d.ts b/packages/loot-core/src/types/prefs.d.tsindex 38f7b1a972..68230ffea1 100644--- a/packages/loot-core/src/types/prefs.d.ts+++ b/packages/loot-core/src/types/prefs.d.ts@@ -3,7 +3,6 @@ import { type numberFormats } from '../shared/util';export type FeatureFlag =| 'reportBudget'| 'goalTemplatesEnabled'- | 'customReports'| 'spendingReport'| 'simpleFinSync'| 'iterableTopologicalSort';diff --git a/upcoming-release-notes/2554.md b/upcoming-release-notes/2554.mdnew file mode 100644index 0000000000..2a54f703c6--- /dev/null+++ b/upcoming-release-notes/2554.md@@ -0,0 +1,6 @@+---+category: Features+authors: [carkom]+---++Removing custom reports from feature flag "experimental" state.