A local-first personal finance app
Fix react-hooks/exhaustive-deps in ImportTransactionsModal (#6868)
Joel Jeremy Marquez16ec636358a0
diff --git a/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx b/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsxindex a179a49840..15d282decb 100644--- a/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx+++ b/packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx@@ -2,6 +2,7 @@import React, {useCallback,useEffect,+ useEffectEvent,useState,type ComponentProps,} from 'react';@@ -718,7 +719,7 @@ export function ImportTransactionsModal({close();}- const runImportPreview = useCallback(async () => {+ const onImportPreview = useEffectEvent(async () => {// always start from the original parsed transactions, not the previewed ones to ensure rules runconst transactionPreview = await getImportPreview(parsedTransactions,@@ -732,39 +733,15 @@ export function ImportTransactionsModal({multiplierAmount,);setTransactions(transactionPreview);- }, [- getImportPreview,- parsedTransactions,- filetype,- flipAmount,- fieldMappings,- splitMode,- parseDateFormat,- inOutMode,- outValue,- multiplierAmount,- ]);+ });useEffect(() => {if (parsedTransactions.length === 0 || loadingState === 'parsing') {return;}- runImportPreview();- // intentionally exclude runImportPreview from dependencies to avoid infinite rerenders- // oxlint-disable-next-line react/exhaustive-deps- }, [- filetype,- flipAmount,- fieldMappings,- splitMode,- parseDateFormat,- inOutMode,- outValue,- multiplierAmount,- loadingState,- parsedTransactions.length,- ]);+ onImportPreview();+ }, [loadingState, parsedTransactions.length]);const headers: ComponentProps<typeof TableHeader>['headers'] = [{ name: t('Date'), width: 200 },diff --git a/upcoming-release-notes/6868.md b/upcoming-release-notes/6868.mdnew file mode 100644index 0000000000..14bb5e83d0--- /dev/null+++ b/upcoming-release-notes/6868.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [joel-jeremy]+---++Fix react-hooks/exhaustive-deps in ImportTransactionsModal