A local-first personal finance app
[AI] Promote Payee Locations to a stable feature (#8511)
Matiss Janis Aboltins188dfbe66381
diff --git a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.pngindex 8d12f63c4c..11a2c76ae9 100644Binary files a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png and b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-2-chromium-linux.pngindex e668441c76..1a1de71403 100644Binary files a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png and b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-3-chromium-linux.png b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-3-chromium-linux.pngindex 96f0895310..9488b40dcb 100644Binary files a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-3-chromium-linux.png and b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-3-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.png b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.pngindex a0f3e98de4..3b9c4c5e7a 100644Binary files a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.png and b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-2-chromium-linux.png b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-2-chromium-linux.pngindex 6d4d7deeae..f8d2801470 100644Binary files a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-2-chromium-linux.png and b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-3-chromium-linux.png b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-3-chromium-linux.pngindex 61328517df..af6b6fe810 100644Binary files a/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-3-chromium-linux.png and b/packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-3-chromium-linux.png differdiff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsxindex 086ed95847..81c49243f3 100644--- a/packages/desktop-client/src/components/settings/Experimental.tsx+++ b/packages/desktop-client/src/components/settings/Experimental.tsx@@ -232,12 +232,6 @@ export function ExperimentalFeatures() {><Trans>Budget Analysis Report</Trans></FeatureToggle>- <FeatureToggle- flag="payeeLocations"- feedbackLink="https://github.com/actualbudget/actual/issues/6706"- >- <Trans>Payee Locations</Trans>- </FeatureToggle><FeatureToggleflag="enableBanking"feedbackLink="https://github.com/actualbudget/actual/issues/7799"diff --git a/packages/desktop-client/src/hooks/useFeatureFlag.ts b/packages/desktop-client/src/hooks/useFeatureFlag.tsindex 3efc596358..95789e0b5a 100644--- a/packages/desktop-client/src/hooks/useFeatureFlag.ts+++ b/packages/desktop-client/src/hooks/useFeatureFlag.ts@@ -12,7 +12,6 @@ const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {balanceForecastReport: false,customThemes: false,budgetAnalysisReport: false,- payeeLocations: false,enableBanking: false,sankeyReport: false,akahuBankSync: false,diff --git a/packages/desktop-client/src/hooks/useLocationPermission.ts b/packages/desktop-client/src/hooks/useLocationPermission.tsindex 37aeffeeeb..79ea33c593 100644--- a/packages/desktop-client/src/hooks/useLocationPermission.ts+++ b/packages/desktop-client/src/hooks/useLocationPermission.ts@@ -4,8 +4,6 @@ import { useResponsive } from '@actual-app/components/hooks/useResponsive';import { locationService } from '#payees/location';-import { useFeatureFlag } from './useFeatureFlag';-export type LocationPermission = {isGranted: boolean;isPending: boolean;@@ -13,18 +11,19 @@ export type LocationPermission = {};/**- * Custom hook to manage geolocation permission status- * Currently behind the payeeLocations feature flag+ * Custom hook to manage geolocation permission status.+ *+ * Payee location functionality is only available on the mobile transaction+ * screen, so permission is only tracked at narrow widths.** @returns a LocationPermissions object*/export function useLocationPermission(): LocationPermission {- const payeeLocationsEnabled = useFeatureFlag('payeeLocations');const { isNarrowWidth } = useResponsive();const [state, setState] = useState<PermissionState | null>(null);useEffect(() => {- if (!payeeLocationsEnabled || !isNarrowWidth) {+ if (!isNarrowWidth) {setState(null);return;}@@ -83,7 +82,7 @@ export function useLocationPermission(): LocationPermission {permissionStatus.removeEventListener('change', handleChange);}};- }, [payeeLocationsEnabled, isNarrowWidth]);+ }, [isNarrowWidth]);const requestPermission = async () => {try {diff --git a/packages/docs/docs-sidebar.js b/packages/docs/docs-sidebar.jsindex ac778dbbe2..110968388e 100644--- a/packages/docs/docs-sidebar.js+++ b/packages/docs/docs-sidebar.js@@ -160,6 +160,7 @@ const sidebars = {'transactions/merging','accounts/reconciliation','transactions/payees',+ 'transactions/payee-locations','transactions/bulk-editing','transactions/tags','transactions/split-transactions',@@ -219,7 +220,6 @@ const sidebars = {'experimental/balance-forecast-report','experimental/budget-analysis-report','experimental/sankey-report',- 'experimental/payee-locations',],},'getting-started/tips-tricks',diff --git a/packages/docs/docs/experimental/payee-locations.md b/packages/docs/docs/transactions/payee-locations.mdsimilarity index 84%rename from packages/docs/docs/experimental/payee-locations.mdrename to packages/docs/docs/transactions/payee-locations.mdindex 7cf646b7ea..9bf68b7212 100644--- a/packages/docs/docs/experimental/payee-locations.md+++ b/packages/docs/docs/transactions/payee-locations.md@@ -1,15 +1,9 @@# Payee Locations-<ExperimentalFeatureWarning issueId="6706" />-Payee Locations let Actual remember where you shop. Once you save a location for a payee, Actual can suggest nearby payees in the payee autocomplete the next time you record a transaction at that spot. It can also fill in the nearest payee with a single tap. This is handy for places you visit often, such as a local grocery store or coffee shop.Payee Locations is only available on the mobile transaction screen, not the table-based ledger used on larger screens and desktops.-## Enabling Payee Locations--Payee Locations is an experimental feature, so you need to turn it on before the location buttons appear. Open **Settings**, click **Show advanced settings**, and enable **Payee Locations** under **Experimental Features**.-## Requesting Location AccessBefore you can use any of the payee location functionality, you need to give your browser access to your location. Begin entering a new transaction and tap the **Request Location** button in the payee field. Your browser will then prompt you to allow access.@@ -20,7 +14,7 @@ If you decline the geolocation permission prompt, Actual cannot ask again. You w:::-+## Saving a Payee Location@@ -34,7 +28,7 @@ The **Save** button only appears when no existing location for this payee is witYour location is only captured when you tap **Save**. It is stored in your budget like any other data, so it syncs across your own devices if you use a sync server, and it is never sent to any third party.-+## Using the Nearest Payee@@ -46,9 +40,9 @@ Once you have saved one or more payee locations, Actual can suggest the nearest4. Continue entering the rest of the transaction details.5. Save the transaction.-+-+## Forgetting a Payee Locationdiff --git a/packages/docs/static/img/experimental/payee-locations/payee-locations-nearby-autocomplete.png b/packages/docs/static/img/payees/payee-locations/payee-locations-nearby-autocomplete.pngsimilarity index 100%rename from packages/docs/static/img/experimental/payee-locations/payee-locations-nearby-autocomplete.pngrename to packages/docs/static/img/payees/payee-locations/payee-locations-nearby-autocomplete.pngdiff --git a/packages/docs/static/img/experimental/payee-locations/payee-locations-nearby-button.png b/packages/docs/static/img/payees/payee-locations/payee-locations-nearby-button.pngsimilarity index 100%rename from packages/docs/static/img/experimental/payee-locations/payee-locations-nearby-button.pngrename to packages/docs/static/img/payees/payee-locations/payee-locations-nearby-button.pngdiff --git a/packages/docs/static/img/experimental/payee-locations/payee-locations-request.png b/packages/docs/static/img/payees/payee-locations/payee-locations-request.pngsimilarity index 100%rename from packages/docs/static/img/experimental/payee-locations/payee-locations-request.pngrename to packages/docs/static/img/payees/payee-locations/payee-locations-request.pngdiff --git a/packages/docs/static/img/experimental/payee-locations/payee-locations-save.png b/packages/docs/static/img/payees/payee-locations/payee-locations-save.pngsimilarity index 100%rename from packages/docs/static/img/experimental/payee-locations/payee-locations-save.pngrename to packages/docs/static/img/payees/payee-locations/payee-locations-save.pngdiff --git a/packages/loot-core/src/types/prefs.ts b/packages/loot-core/src/types/prefs.tsindex 2557ee6f09..9b016a2f93 100644--- a/packages/loot-core/src/types/prefs.ts+++ b/packages/loot-core/src/types/prefs.ts@@ -8,7 +8,6 @@ export type FeatureFlag =| 'balanceForecastReport'| 'customThemes'| 'budgetAnalysisReport'- | 'payeeLocations'| 'enableBanking'| 'sankeyReport'| 'akahuBankSync'diff --git a/upcoming-release-notes/promote-payee-locations.md b/upcoming-release-notes/promote-payee-locations.mdnew file mode 100644index 0000000000..9de2996ecf--- /dev/null+++ b/upcoming-release-notes/promote-payee-locations.md@@ -0,0 +1,6 @@+---+category: Features+authors: [MatissJanis]+---++Promote Payee Locations to a stable feature.