A local-first personal finance app
add retry when GoCardless access token exires (#9088)
Matt Fiddaman18e995513bb7
diff --git a/packages/sync-server/src/app-gocardless/services/gocardless-api.ts b/packages/sync-server/src/app-gocardless/services/gocardless-api.tsindex b45d051643..9a1bf91d0f 100644--- a/packages/sync-server/src/app-gocardless/services/gocardless-api.ts+++ b/packages/sync-server/src/app-gocardless/services/gocardless-api.ts@@ -54,6 +54,15 @@ export class GoCardlessApiError extends Error {}}+function isInvalidTokenResponse(data: unknown): boolean {+ return (+ typeof data === 'object' &&+ data !== null &&+ 'summary' in data &&+ data.summary === 'Invalid token'+ );+}+export class GoCardlessApi {#secretId: string | null;#secretKey: string | null;@@ -91,9 +100,11 @@ export class GoCardlessApi {{method = 'GET',body,+ isRetry = false,}: {method?: 'GET' | 'POST' | 'DELETE';body?: Record<string, unknown>;+ isRetry?: boolean;} = {},): Promise<T> {const headers: Record<string, string> = {@@ -138,6 +149,18 @@ export class GoCardlessApi {`GoCardless ${method} ${endpoint} ${response.status}`,error.response.data ? JSON.stringify(error.response.data) : '(no body)',);++ if (+ !isRetry &&+ this.#token &&+ response.status === 401 &&+ isInvalidTokenResponse(error.response.data)+ ) {+ this.#token = null;+ await this.generateToken();+ return this.#request<T>(endpoint, { method, body, isRetry: true });+ }+throw error;}diff --git a/upcoming-release-notes/fix-gocardless-invalid-token.md b/upcoming-release-notes/fix-gocardless-invalid-token.mdnew file mode 100644index 0000000000..38363dd021--- /dev/null+++ b/upcoming-release-notes/fix-gocardless-invalid-token.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [matt-fidd]+---++Fix GoCardless bank sync failing with a generic error when the server's access token is no longer accepted