Skip to content

A local-first personal finance app

feat: ensure only selected transactions are modified

Charles Taylor2005ada76139
diff --git a/packages/desktop-client/src/components/accounts/Account.js b/packages/desktop-client/src/components/accounts/Account.js
index 148614236e..9264f221cc 100644
--- a/packages/desktop-client/src/components/accounts/Account.js
+++ b/packages/desktop-client/src/components/accounts/Account.js
@@ -1413,7 +1413,15 @@ class AccountInternal extends React.PureComponent {
value = !!transactions.find(t => !t.cleared);
}
+ let idSet = new Set(ids);
+
transactions.forEach(trans => {
+ if (!idSet.has(trans.id)) {
+ // Skip transactions which aren't actually selected, since the
+ // query above also retrieves the siblings of any selected splits.
+ return;
+ }
+
let { diff } = updateTransaction(transactions, {
...trans,
[name]: value