Skip to content

A local-first personal finance app

♻️ remove body-parser dependency (#5197)

Matt Fiddaman252f04e02cf1
diff --git a/packages/sync-server/package.json b/packages/sync-server/package.json
index 4b7ccc5652..b9ab2c3fd7 100644
--- a/packages/sync-server/package.json
+++ b/packages/sync-server/package.json
@@ -31,7 +31,6 @@
"@actual-app/web": "workspace:*",
"bcrypt": "^5.1.1",
"better-sqlite3": "^11.10.0",
- "body-parser": "^1.20.3",
"convict": "^6.2.4",
"cors": "^2.8.5",
"date-fns": "^4.1.0",
diff --git a/packages/sync-server/src/app.ts b/packages/sync-server/src/app.ts
index b6d13072dd..427680116f 100644
--- a/packages/sync-server/src/app.ts
+++ b/packages/sync-server/src/app.ts
@@ -2,7 +2,6 @@ import fs, { readFileSync } from 'node:fs';
import { join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
-import bodyParser from 'body-parser';
import cors from 'cors';
import express from 'express';
import rateLimit from 'express-rate-limit';
@@ -38,17 +37,17 @@ if (process.env.NODE_ENV !== 'development') {
);
}
+app.use(express.json({ limit: `${config.get('upload.fileSizeLimitMB')}mb` }));
+
app.use(
- bodyParser.json({ limit: `${config.get('upload.fileSizeLimitMB')}mb` }),
-);
-app.use(
- bodyParser.raw({
+ express.raw({
type: 'application/actual-sync',
limit: `${config.get('upload.fileSizeSyncLimitMB')}mb`,
}),
);
+
app.use(
- bodyParser.raw({
+ express.raw({
type: 'application/encrypted-file',
limit: `${config.get('upload.syncEncryptedFileSizeLimitMB')}mb`,
}),
diff --git a/upcoming-release-notes/5197.md b/upcoming-release-notes/5197.md
new file mode 100644
index 0000000000..da8f8bcaa6
--- /dev/null
+++ b/upcoming-release-notes/5197.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [matt-fidd]
+---
+
+Remove body-parser dependency
diff --git a/yarn.lock b/yarn.lock
index d2673f4249..7c7d7b0f43 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -96,7 +96,6 @@ __metadata:
"@vitest/coverage-v8": "npm:3.1.3"
bcrypt: "npm:^5.1.1"
better-sqlite3: "npm:^11.10.0"
- body-parser: "npm:^1.20.3"
convict: "npm:^6.2.4"
cors: "npm:^2.8.5"
date-fns: "npm:^4.1.0"
@@ -8287,26 +8286,6 @@ __metadata:
languageName: node
linkType: hard
-"body-parser@npm:^1.20.3":
- version: 1.20.3
- resolution: "body-parser@npm:1.20.3"
- dependencies:
- bytes: "npm:3.1.2"
- content-type: "npm:~1.0.5"
- debug: "npm:2.6.9"
- depd: "npm:2.0.0"
- destroy: "npm:1.2.0"
- http-errors: "npm:2.0.0"
- iconv-lite: "npm:0.4.24"
- on-finished: "npm:2.4.1"
- qs: "npm:6.13.0"
- raw-body: "npm:2.5.2"
- type-is: "npm:~1.6.18"
- unpipe: "npm:1.0.0"
- checksum: 10/8723e3d7a672eb50854327453bed85ac48d045f4958e81e7d470c56bf111f835b97e5b73ae9f6393d0011cc9e252771f46fd281bbabc57d33d3986edf1e6aeca
- languageName: node
- linkType: hard
-
"body-parser@npm:^2.2.0":
version: 2.2.0
resolution: "body-parser@npm:2.2.0"
@@ -9205,7 +9184,7 @@ __metadata:
languageName: node
linkType: hard
-"content-type@npm:^1.0.5, content-type@npm:~1.0.5":
+"content-type@npm:^1.0.5":
version: 1.0.5
resolution: "content-type@npm:1.0.5"
checksum: 10/585847d98dc7fb8035c02ae2cb76c7a9bd7b25f84c447e5ed55c45c2175e83617c8813871b4ee22f368126af6b2b167df655829007b21aa10302873ea9c62662
@@ -9687,15 +9666,6 @@ __metadata:
languageName: node
linkType: hard
-"debug@npm:2.6.9, debug@npm:^2.2.0":
- version: 2.6.9
- resolution: "debug@npm:2.6.9"
- dependencies:
- ms: "npm:2.0.0"
- checksum: 10/e07005f2b40e04f1bd14a3dd20520e9c4f25f60224cb006ce9d6781732c917964e9ec029fc7f1a151083cd929025ad5133814d4dc624a9aaf020effe4914ed14
- languageName: node
- linkType: hard
-
"debug@npm:4, debug@npm:^4, debug@npm:^4.0.0, debug@npm:^4.1.0, debug@npm:^4.1.1, debug@npm:^4.3.1, debug@npm:^4.3.2, debug@npm:^4.3.3, debug@npm:^4.3.4, debug@npm:^4.3.6, debug@npm:^4.4.0":
version: 4.4.0
resolution: "debug@npm:4.4.0"
@@ -9708,6 +9678,15 @@ __metadata:
languageName: node
linkType: hard
+"debug@npm:^2.2.0":
+ version: 2.6.9
+ resolution: "debug@npm:2.6.9"
+ dependencies:
+ ms: "npm:2.0.0"
+ checksum: 10/e07005f2b40e04f1bd14a3dd20520e9c4f25f60224cb006ce9d6781732c917964e9ec029fc7f1a151083cd929025ad5133814d4dc624a9aaf020effe4914ed14
+ languageName: node
+ linkType: hard
+
"debug@npm:^3.2.7":
version: 3.2.7
resolution: "debug@npm:3.2.7"
@@ -9909,13 +9888,6 @@ __metadata:
languageName: unknown
linkType: soft
-"destroy@npm:1.2.0":
- version: 1.2.0
- resolution: "destroy@npm:1.2.0"
- checksum: 10/0acb300b7478a08b92d810ab229d5afe0d2f4399272045ab22affa0d99dbaf12637659411530a6fcd597a9bdac718fc94373a61a95b4651bbc7b83684a565e38
- languageName: node
- linkType: hard
-
"detect-europe-js@npm:^0.1.2":
version: 0.1.2
resolution: "detect-europe-js@npm:0.1.2"
@@ -12606,15 +12578,6 @@ __metadata:
languageName: node
linkType: hard
-"iconv-lite@npm:0.4.24":
- version: 0.4.24
- resolution: "iconv-lite@npm:0.4.24"
- dependencies:
- safer-buffer: "npm:>= 2.1.2 < 3"
- checksum: 10/6d3a2dac6e5d1fb126d25645c25c3a1209f70cceecc68b8ef51ae0da3cdc078c151fade7524a30b12a3094926336831fca09c666ef55b37e2c69638b5d6bd2e3
- languageName: node
- linkType: hard
-
"iconv-lite@npm:0.6.3, iconv-lite@npm:^0.6.2, iconv-lite@npm:^0.6.3":
version: 0.6.3
resolution: "iconv-lite@npm:0.6.3"
@@ -14574,13 +14537,6 @@ __metadata:
languageName: node
linkType: hard
-"media-typer@npm:0.3.0":
- version: 0.3.0
- resolution: "media-typer@npm:0.3.0"
- checksum: 10/38e0984db39139604756903a01397e29e17dcb04207bb3e081412ce725ab17338ecc47220c1b186b6bbe79a658aad1b0d41142884f5a481f36290cdefbe6aa46
- languageName: node
- linkType: hard
-
"media-typer@npm:^1.1.0":
version: 1.1.0
resolution: "media-typer@npm:1.1.0"
@@ -15015,7 +14971,7 @@ __metadata:
languageName: node
linkType: hard
-"mime-types@npm:^2.1.12, mime-types@npm:^2.1.27, mime-types@npm:~2.1.24":
+"mime-types@npm:^2.1.12, mime-types@npm:^2.1.27":
version: 2.1.35
resolution: "mime-types@npm:2.1.35"
dependencies:
@@ -15772,7 +15728,7 @@ __metadata:
languageName: node
linkType: hard
-"on-finished@npm:2.4.1, on-finished@npm:^2.4.1":
+"on-finished@npm:^2.4.1":
version: 2.4.1
resolution: "on-finished@npm:2.4.1"
dependencies:
@@ -16528,15 +16484,6 @@ __metadata:
languageName: node
linkType: hard
-"qs@npm:6.13.0":
- version: 6.13.0
- resolution: "qs@npm:6.13.0"
- dependencies:
- side-channel: "npm:^1.0.6"
- checksum: 10/f548b376e685553d12e461409f0d6e5c59ec7c7d76f308e2a888fd9db3e0c5e89902bedd0754db3a9038eda5f27da2331a6f019c8517dc5e0a16b3c9a6e9cef8
- languageName: node
- linkType: hard
-
"qs@npm:^6.11.0, qs@npm:^6.14.0":
version: 6.14.0
resolution: "qs@npm:6.14.0"
@@ -16601,18 +16548,6 @@ __metadata:
languageName: node
linkType: hard
-"raw-body@npm:2.5.2":
- version: 2.5.2
- resolution: "raw-body@npm:2.5.2"
- dependencies:
- bytes: "npm:3.1.2"
- http-errors: "npm:2.0.0"
- iconv-lite: "npm:0.4.24"
- unpipe: "npm:1.0.0"
- checksum: 10/863b5171e140546a4d99f349b720abac4410338e23df5e409cfcc3752538c9caf947ce382c89129ba976f71894bd38b5806c774edac35ebf168d02aa1ac11a95
- languageName: node
- linkType: hard
-
"raw-body@npm:^3.0.0":
version: 3.0.0
resolution: "raw-body@npm:3.0.0"
@@ -17922,7 +17857,7 @@ __metadata:
languageName: node
linkType: hard
-"safer-buffer@npm:>= 2.1.2 < 3, safer-buffer@npm:>= 2.1.2 < 3.0.0":
+"safer-buffer@npm:>= 2.1.2 < 3.0.0":
version: 2.1.2
resolution: "safer-buffer@npm:2.1.2"
checksum: 10/7eaf7a0cf37cc27b42fb3ef6a9b1df6e93a1c6d98c6c6702b02fe262d5fcbd89db63320793b99b21cb5348097d0a53de81bd5f4e8b86e20cc9412e3f1cfb4e83
@@ -18235,7 +18170,7 @@ __metadata:
languageName: node
linkType: hard
-"side-channel@npm:^1.0.4, side-channel@npm:^1.0.6, side-channel@npm:^1.1.0":
+"side-channel@npm:^1.0.4, side-channel@npm:^1.1.0":
version: 1.1.0
resolution: "side-channel@npm:1.1.0"
dependencies:
@@ -19589,16 +19524,6 @@ __metadata:
languageName: node
linkType: hard
-"type-is@npm:~1.6.18":
- version: 1.6.18
- resolution: "type-is@npm:1.6.18"
- dependencies:
- media-typer: "npm:0.3.0"
- mime-types: "npm:~2.1.24"
- checksum: 10/0bd9eeae5efd27d98fd63519f999908c009e148039d8e7179a074f105362d4fcc214c38b24f6cda79c87e563cbd12083a4691381ed28559220d4a10c2047bed4
- languageName: node
- linkType: hard
-
"typed-array-buffer@npm:^1.0.3":
version: 1.0.3
resolution: "typed-array-buffer@npm:1.0.3"