A local-first personal finance app
Add bank sync option to only import balance (#5711)
youngcw25c83eb64dd9
diff --git a/packages/desktop-client/src/components/banksync/EditSyncAccount.tsx b/packages/desktop-client/src/components/banksync/EditSyncAccount.tsxindex ade1dbd35e..003513dc04 100644--- a/packages/desktop-client/src/components/banksync/EditSyncAccount.tsx+++ b/packages/desktop-client/src/components/banksync/EditSyncAccount.tsx@@ -136,6 +136,8 @@ export function EditSyncAccount({ account }: EditSyncAccountProps) {const [savedReimportDeleted = true, setSavedReimportDeleted] = useSyncedPref(`sync-reimport-deleted-${account.id}`,);+ const [savedImportTransactions = true, setSavedImportTransactions] =+ useSyncedPref(`sync-import-transactions-${account.id}`);const [transactionDirection, setTransactionDirection] =useState<TransactionDirection>('payment');@@ -151,6 +153,9 @@ export function EditSyncAccount({ account }: EditSyncAccountProps) {const [mappings, setMappings] = useState<Mappings>(mappingsFromString(savedMappings),);+ const [importTransactions, setImportTransactions] = useState(+ String(savedImportTransactions) === 'true',+ );const transactionQuery = useMemo(() =>@@ -186,6 +191,7 @@ export function EditSyncAccount({ account }: EditSyncAccountProps) {setSavedImportPending(String(importPending));setSavedImportNotes(String(importNotes));setSavedReimportDeleted(String(reimportDeleted));+ setSavedImportTransactions(String(importTransactions));close();};@@ -255,24 +261,27 @@ export function EditSyncAccount({ account }: EditSyncAccountProps) {<CheckboxOptionid="form_pending"- checked={importPending}+ checked={importPending && importTransactions}onChange={() => setImportPending(!importPending)}+ disabled={!importTransactions}><Trans>Import pending transactions</Trans></CheckboxOption><CheckboxOptionid="form_notes"- checked={importNotes}+ checked={importNotes && importTransactions}onChange={() => setImportNotes(!importNotes)}+ disabled={!importTransactions}><Trans>Import transaction notes</Trans></CheckboxOption><CheckboxOptionid="form_reimport_deleted"- checked={reimportDeleted}+ checked={reimportDeleted && importTransactions}onChange={() => setReimportDeleted(!reimportDeleted)}+ disabled={!importTransactions}><Tooltipcontent={t(@@ -294,6 +303,31 @@ export function EditSyncAccount({ account }: EditSyncAccountProps) {</Tooltip></CheckboxOption>+ <CheckboxOption+ id="form_import_transactions"+ checked={!importTransactions}+ onChange={() => setImportTransactions(!importTransactions)}+ >+ <Tooltip+ content={t(+ `Selecting this option will disable importing transactions and only import the account balance for use in reconciliation`,+ )}+ >+ <View+ style={{+ display: 'flex',+ flexWrap: 'nowrap',+ flexDirection: 'row',+ alignItems: 'center',+ gap: 4,+ }}+ >+ <Trans>Investment Account</Trans>+ <SvgQuestion height={12} width={12} cursor="pointer" />+ </View>+ </Tooltip>+ </CheckboxOption>+<Viewstyle={{display: 'flex',diff --git a/packages/loot-core/src/server/accounts/sync.ts b/packages/loot-core/src/server/accounts/sync.tsindex de5b4b870f..f9200a0792 100644--- a/packages/loot-core/src/server/accounts/sync.ts+++ b/packages/loot-core/src/server/accounts/sync.ts@@ -879,6 +879,12 @@ async function processBankSyncDownload(// that account sync sources can give two different transaction IDs even though it's the same transaction.const useStrictIdChecking = !acctRow.account_sync_source;+ const importTransactions = await aqlQuery(+ q('preferences')+ .filter({ id: `sync-import-transactions-${id}` })+ .select('value'),+ ).then(data => String(data?.data?.[0]?.value ?? 'true') === 'true');+/** Starting balance is actually the current balance of the account. */const {transactions: originalTransactions,@@ -940,10 +946,6 @@ async function processBankSyncDownload(});}- if (originalTransactions.length === 0) {- return { added: [], updated: [] };- }-const transactions = originalTransactions.map(trans => ({...trans,account: id,@@ -952,13 +954,14 @@ async function processBankSyncDownload(return runMutator(async () => {const result = await reconcileTransactions(id,- transactions,+ importTransactions ? transactions : [],true,useStrictIdChecking,);- /** Starting balance is actually the current balance of the account. */- if (currentBalance) await updateAccountBalance(id, currentBalance);+ if (currentBalance != null) {+ await updateAccountBalance(id, currentBalance);+ }return result;});diff --git a/packages/loot-core/src/types/prefs.ts b/packages/loot-core/src/types/prefs.tsindex 291eda4946..f9daafe01a 100644--- a/packages/loot-core/src/types/prefs.ts+++ b/packages/loot-core/src/types/prefs.ts@@ -36,6 +36,7 @@ export type SyncedPrefs = Partial<| `sync-import-pending-${string}`| `sync-reimport-deleted-${string}`| `sync-import-notes-${string}`+ | `sync-import-transactions-${string}`| `ofx-fallback-missing-payee-${string}`| `flip-amount-${string}-${'csv' | 'qif'}`| `flags.${FeatureFlag}`diff --git a/upcoming-release-notes/5711.md b/upcoming-release-notes/5711.mdnew file mode 100644index 0000000000..e1cec67201--- /dev/null+++ b/upcoming-release-notes/5711.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [youngcw]+---++Add bank sync option to only import account balance