A local-first personal finance app
transaction-import: treat (amount) as -amount (#808)
Aidan Harbison28c68940214c
diff --git a/packages/loot-core/src/shared/util.js b/packages/loot-core/src/shared/util.jsindex 1101c4212c..484ccb3216 100644--- a/packages/loot-core/src/shared/util.js+++ b/packages/loot-core/src/shared/util.js@@ -377,15 +377,23 @@ export function looselyParseAmount(amount) {return isNaN(v) ? null : v;}+ function extractNumbers(v) {+ return v.replace(/[^0-9-]/g, '');+ }++ if (amount.startsWith('(') && amount.endsWith(')')) {+ amount = amount.replace('(', '-').replace(')', '');+ }+let m = amount.match(/[.,][^.,]*$/);if (!m || m.index === 0) {- return safeNumber(parseFloat(amount));+ return safeNumber(parseFloat(extractNumbers(amount)));}- let left = amount.slice(0, m.index);- let right = amount.slice(m.index + 1);+ let left = extractNumbers(amount.slice(0, m.index));+ let right = extractNumbers(amount.slice(m.index + 1));- return safeNumber(parseFloat(left.replace(/[^0-9-]/g, '') + '.' + right));+ return safeNumber(parseFloat(left + '.' + right));}export function semverToNumber(str) {diff --git a/packages/loot-core/src/shared/util.test.js b/packages/loot-core/src/shared/util.test.jsindex ebd52e0c02..afe3b3d7c5 100644--- a/packages/loot-core/src/shared/util.test.js+++ b/packages/loot-core/src/shared/util.test.js@@ -22,6 +22,11 @@ describe('utility functions', () => {expect(looselyParseAmount('-3,45')).toBe(-3.45);});+ test('looseParseAmount works with parentheses (negative)', () => {+ expect(looselyParseAmount('(3.45)')).toBe(-3.45);+ expect(looselyParseAmount('(3)')).toBe(-3);+ });+test('looseParseAmount ignores non-numeric characters', () => {// This is strange behavior because it does not work for just// `3_45_23` (it needs a decimal amount). This function should bediff --git a/upcoming-release-notes/808.md b/upcoming-release-notes/808.mdnew file mode 100644index 0000000000..9009e101dc--- /dev/null+++ b/upcoming-release-notes/808.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [aharbis]+---++Import transactions with negative amounts represented as `(amount)`