Skip to content

A local-first personal finance app

Add data-1p-ignore to transaction amounts (#5783)

Matiss Janis Aboltins28caf8eaf98b
diff --git a/packages/desktop-client/src/components/table.tsx b/packages/desktop-client/src/components/table.tsx
index 717cd4faf1..5ea162279a 100644
--- a/packages/desktop-client/src/components/table.tsx
+++ b/packages/desktop-client/src/components/table.tsx
@@ -319,6 +319,8 @@ type InputValueProps = Omit<
> & {
value?: string;
onUpdate?: (newValue: string) => void;
+} & {
+ [key: `data-${string}`]: unknown;
};
function InputValue({
diff --git a/packages/desktop-client/src/components/transactions/TransactionsTable.tsx b/packages/desktop-client/src/components/transactions/TransactionsTable.tsx
index 79631606b3..ca2ec88163 100644
--- a/packages/desktop-client/src/components/transactions/TransactionsTable.tsx
+++ b/packages/desktop-client/src/components/transactions/TransactionsTable.tsx
@@ -1603,6 +1603,7 @@ const Transaction = memo(function Transaction({
inputProps={{
value: debit === '' && credit === '' ? amountToCurrency(0) : debit,
onUpdate: onUpdate.bind(null, 'debit'),
+ 'data-1p-ignore': true,
}}
privacyFilter={{
activationFilters: [!isTemporaryId(transaction.id)],
@@ -1629,6 +1630,7 @@ const Transaction = memo(function Transaction({
inputProps={{
value: credit,
onUpdate: onUpdate.bind(null, 'credit'),
+ 'data-1p-ignore': true,
}}
privacyFilter={{
activationFilters: [!isTemporaryId(transaction.id)],
diff --git a/upcoming-release-notes/5783.md b/upcoming-release-notes/5783.md
new file mode 100644
index 0000000000..882e9e180e
--- /dev/null
+++ b/upcoming-release-notes/5783.md
@@ -0,0 +1,7 @@
+---
+category: Enhancements
+authors: [MatissJanis]
+---
+
+Add data-1p-ignore attribute to transaction amount inputs to prevent 1Password autofill.
+