Skip to content

A local-first personal finance app

[AI] Replace html-to-image with snapdom for report snapshots (#9308)

Abdullah Oyewale2b2c8f5dc0a3
diff --git a/packages/desktop-client/package.json b/packages/desktop-client/package.json
index 182c18327b..2df4433f3f 100644
--- a/packages/desktop-client/package.json
+++ b/packages/desktop-client/package.json
@@ -177,6 +177,7 @@
"@use-gesture/react": "^10.3.1",
"@vitejs/plugin-basic-ssl": "^2.3.0",
"@vitejs/plugin-react": "^6.1.2",
+ "@zumer/snapdom": "^3.3.6",
"auto-text-size": "^0.2.3",
"babel-plugin-react-compiler": "^1.0.0",
"cmdk": "^1.1.1",
@@ -186,7 +187,6 @@
"downshift": "9.4.0",
"es-toolkit": "^1.52.0",
"fzf": "^0.5.2",
- "html-to-image": "^1.11.13",
"hyperformula": "^3.5.0",
"i18next": "^26.4.4",
"i18next-parser": "^9.4.0",
diff --git a/packages/desktop-client/src/components/reports/ReportTopbar.tsx b/packages/desktop-client/src/components/reports/ReportTopbar.tsx
index d89db0ab2a..18469c1285 100644
--- a/packages/desktop-client/src/components/reports/ReportTopbar.tsx
+++ b/packages/desktop-client/src/components/reports/ReportTopbar.tsx
@@ -21,7 +21,7 @@ import type {
CustomReportEntity,
RuleConditionEntity,
} from '@actual-app/core/types/models';
-import { toPng } from 'html-to-image';
+import { snapdom } from '@zumer/snapdom';
import { FilterButton } from '#components/filters/FiltersMenu';
@@ -72,9 +72,9 @@ export function ReportTopbar({
const reportElement = document.getElementById('custom-report-content');
const title = report.name;
if (reportElement) {
- const dataUrl = await toPng(reportElement);
+ const image = await snapdom.toPng(reportElement);
const link = document.createElement('a');
- link.href = dataUrl;
+ link.href = image.src;
link.download = `${monthUtils.currentDay()} - ${title}.png`;
link.click();
} else {
diff --git a/upcoming-release-notes/fix-report-snapshot-firefox.md b/upcoming-release-notes/fix-report-snapshot-firefox.md
new file mode 100644
index 0000000000..1791e526a8
--- /dev/null
+++ b/upcoming-release-notes/fix-report-snapshot-firefox.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [pendevster]
+---
+
+Fix downloading a report snapshot in Firefox
diff --git a/yarn.lock b/yarn.lock
index 66eb2edc2d..01c6a0d1b1 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -265,6 +265,7 @@ __metadata:
"@use-gesture/react": "npm:^10.3.1"
"@vitejs/plugin-basic-ssl": "npm:^2.3.0"
"@vitejs/plugin-react": "npm:^6.1.2"
+ "@zumer/snapdom": "npm:^3.3.6"
auto-text-size: "npm:^0.2.3"
babel-plugin-react-compiler: "npm:^1.0.0"
cmdk: "npm:^1.1.1"
@@ -274,7 +275,6 @@ __metadata:
downshift: "npm:9.4.0"
es-toolkit: "npm:^1.52.0"
fzf: "npm:^0.5.2"
- html-to-image: "npm:^1.11.13"
hyperformula: "npm:^3.5.0"
i18next: "npm:^26.4.4"
i18next-parser: "npm:^9.4.0"
@@ -9883,6 +9883,13 @@ __metadata:
languageName: node
linkType: hard
+"@zumer/snapdom@npm:^3.3.6":
+ version: 3.3.6
+ resolution: "@zumer/snapdom@npm:3.3.6"
+ checksum: 10/d6ee02b203951a281076ce3ea188307d4f0adb95cb79df0275b02816f0bede7caddfbff4c0b090eeb7274c5639860daef6d97ab5790e8c85c33cac1644b31cc4
+ languageName: node
+ linkType: hard
+
"abbrev@npm:^3.0.0":
version: 3.0.1
resolution: "abbrev@npm:3.0.1"
@@ -16694,13 +16701,6 @@ __metadata:
languageName: node
linkType: hard
-"html-to-image@npm:^1.11.13":
- version: 1.11.13
- resolution: "html-to-image@npm:1.11.13"
- checksum: 10/f5950a0221b4ed4e59853db09917606309ebe3ddd2051c2f89aed3e37026d1893880f76e61bc2ca2280e3f1bbc0ad5b9ea5325188ff339987c8eeccbe8284f3f
- languageName: node
- linkType: hard
-
"html-url-attributes@npm:^3.0.0":
version: 3.0.1
resolution: "html-url-attributes@npm:3.0.1"