A local-first personal finance app
[AI] fix(sync-server): prevent duplicate Enable Banking transactions (#9046)
Guo-Yixin2dc69b3de5bb
diff --git a/packages/sync-server/src/app-enablebanking/services/enablebanking-service.ts b/packages/sync-server/src/app-enablebanking/services/enablebanking-service.tsindex e2479d3e6f..bfa69413b9 100644--- a/packages/sync-server/src/app-enablebanking/services/enablebanking-service.ts+++ b/packages/sync-server/src/app-enablebanking/services/enablebanking-service.ts@@ -437,7 +437,6 @@ export const enableBankingService = {continuationKey,psuHeaders,);- allTransactions.push(...result.transactions);if (result.continuation_key &&@@ -446,6 +445,7 @@ export const enableBankingService = {break;}+ allTransactions.push(...result.transactions);continuationKey = result.continuation_key;iteration++;} while (continuationKey && iteration < maxIterations);diff --git a/packages/sync-server/src/app-enablebanking/services/tests/enablebanking-service.spec.ts b/packages/sync-server/src/app-enablebanking/services/tests/enablebanking-service.spec.tsindex fa45e9c1b0..f6265a758b 100644--- a/packages/sync-server/src/app-enablebanking/services/tests/enablebanking-service.spec.ts+++ b/packages/sync-server/src/app-enablebanking/services/tests/enablebanking-service.spec.ts@@ -496,7 +496,7 @@ describe('enableBankingService', () => {continuation_key: 'stuck-key',});mockFetchResponse({- transactions: [mockDebitTransaction],+ transactions: [mockCreditTransaction],continuation_key: 'stuck-key',});@@ -507,7 +507,7 @@ describe('enableBankingService', () => {);expect(mockFetch).toHaveBeenCalledTimes(2);- expect(result).toHaveLength(2);+ expect(result).toEqual([mockCreditTransaction]);});});diff --git a/upcoming-release-notes/fix-enable-banking-repeated-page.md b/upcoming-release-notes/fix-enable-banking-repeated-page.mdnew file mode 100644index 0000000000..aff1c256c9--- /dev/null+++ b/upcoming-release-notes/fix-enable-banking-repeated-page.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [Guo-Yixin]+---++Prevent duplicate transactions when Enable Banking repeats a continuation key during pagination