A local-first personal finance app
Save name fields on unfocus (#2327)
Julian Dominguez-Schatz30f03e8079b8
diff --git a/packages/desktop-client/src/components/accounts/Header.jsx b/packages/desktop-client/src/components/accounts/Header.jsxindex 3c4f79a78a..4e181a5146 100644--- a/packages/desktop-client/src/components/accounts/Header.jsx+++ b/packages/desktop-client/src/components/accounts/Header.jsx@@ -126,7 +126,8 @@ export function AccountHeader({<InputdefaultValue={accountName}onEnter={e => onSaveName(e.target.value)}- onBlur={() => onExposeName(false)}+ onBlur={e => onSaveName(e.target.value)}+ onEscape={() => onExposeName(false)}style={{fontSize: 25,fontWeight: 500,diff --git a/packages/desktop-client/src/components/common/Input.tsx b/packages/desktop-client/src/components/common/Input.tsxindex 342c1e75c8..390473a405 100644--- a/packages/desktop-client/src/components/common/Input.tsx+++ b/packages/desktop-client/src/components/common/Input.tsx@@ -26,6 +26,7 @@ export type InputProps = InputHTMLAttributes<HTMLInputElement> & {style?: CSSProperties;inputRef?: Ref<HTMLInputElement>;onEnter?: (event: KeyboardEvent<HTMLInputElement>) => void;+ onEscape?: (event: KeyboardEvent<HTMLInputElement>) => void;onUpdate?: (newValue: string) => void;focused?: boolean;};@@ -34,6 +35,7 @@ export function Input({style,inputRef,onEnter,+ onEscape,onUpdate,focused,...nativeProps@@ -65,6 +67,10 @@ export function Input({onEnter(e);}+ if (e.key === 'Escape' && onEscape) {+ onEscape(e);+ }+nativeProps.onKeyDown?.(e);}}onChange={e => {diff --git a/packages/desktop-client/src/components/sidebar/SidebarWithData.tsx b/packages/desktop-client/src/components/sidebar/SidebarWithData.tsxindex 32668b2487..af8010f64d 100644--- a/packages/desktop-client/src/components/sidebar/SidebarWithData.tsx+++ b/packages/desktop-client/src/components/sidebar/SidebarWithData.tsx@@ -59,6 +59,17 @@ function EditableBudgetName({ prefs, savePrefs }: EditableBudgetNameProps) {{ name: 'close', text: 'Close file' },];+ const onSaveChanges = async e => {+ const inputEl = e.target;+ const newBudgetName = inputEl.value;+ if (newBudgetName.trim() !== '') {+ await savePrefs({+ budgetName: inputEl.value,+ });+ setEditing(false);+ }+ };+if (editing) {return (<InitialFocus>@@ -69,17 +80,9 @@ function EditableBudgetName({ prefs, savePrefs }: EditableBudgetNameProps) {fontWeight: 500,}}defaultValue={prefs.budgetName}- onEnter={async e => {- const inputEl = e.target as HTMLInputElement;- const newBudgetName = inputEl.value;- if (newBudgetName.trim() !== '') {- await savePrefs({- budgetName: inputEl.value,- });- setEditing(false);- }- }}- onBlur={() => setEditing(false)}+ onEnter={onSaveChanges}+ onBlur={onSaveChanges}+ onEscape={() => setEditing(false)}/></InitialFocus>);diff --git a/upcoming-release-notes/2327.md b/upcoming-release-notes/2327.mdnew file mode 100644index 0000000000..5d1de94fc8--- /dev/null+++ b/upcoming-release-notes/2327.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [jfdoming]+---++Save budget/account name fields on blur