A local-first personal finance app
fix mobile transactions view hiding older transactions with hide reconciled enabled (#7267)
Matt Fiddaman335392dae02c
diff --git a/packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx b/packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsxindex 2095130a6e..2df583bfab 100644--- a/packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx+++ b/packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx@@ -54,18 +54,27 @@ function TransactionListWithPreviews({const dispatch = useDispatch();const navigate = useNavigate();- const baseTransactionsQuery = useCallback(- () =>- queries.transactions(account.id).options({ splits: 'all' }).select('*'),- [account.id],- );-const [showRunningBalances] = useSyncedPref(`show-balances-${account.id}`);const [hideReconciled] = useSyncedPref(`hide-reconciled-${account.id}`);++ const baseTransactionsQuery = useCallback(() => {+ let query = queries+ .transactions(account.id)+ .options({ splits: 'all' })+ .select('*');+ if (hideReconciled === 'true') {+ query = query.filter({ reconciled: { $eq: false } });+ }+ return query;+ }, [account.id, hideReconciled]);const [transactionsQuery, setTransactionsQuery] = useState<Query>(baseTransactionsQuery(),);+ useEffect(() => {+ setTransactionsQuery(baseTransactionsQuery());+ }, [baseTransactionsQuery]);+const { isSearching, search: onSearch } = useTransactionsSearch({updateQuery: setTransactionsQuery,resetQuery: () => setTransactionsQuery(baseTransactionsQuery()),@@ -191,14 +200,10 @@ function TransactionListWithPreviews({[account],);- const baseTransactions = !isSearching+ const transactionsToDisplay = !isSearching? // Do not render child transactions in the list, unless searchingpreviewTransactions.concat(transactions.filter(t => !t.is_child)): transactions;- const transactionsToDisplay =- hideReconciled === 'true'- ? baseTransactions.filter(t => !t.reconciled)- : baseTransactions;return (<TransactionListWithBalancesdiff --git a/upcoming-release-notes/7267.md b/upcoming-release-notes/7267.mdnew file mode 100644index 0000000000..932ac15a15--- /dev/null+++ b/upcoming-release-notes/7267.md@@ -0,0 +1,6 @@+---+category: Bugfixes+authors: [matt-fidd]+---++Fix mobile transactions view hiding older transactions when hiding reconciled transactions is enabled