Skip to content

A local-first personal finance app

Fix rule edit page crashing (#6175)

Matiss Janis Aboltins38145975ec79
diff --git a/packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png b/packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png
index f046376ac0..00f01dd08a 100644
Binary files a/packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png and b/packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png differ
diff --git a/packages/desktop-client/src/components/rules/RuleEditor.tsx b/packages/desktop-client/src/components/rules/RuleEditor.tsx
index daad645e6b..346f8cf228 100644
--- a/packages/desktop-client/src/components/rules/RuleEditor.tsx
+++ b/packages/desktop-client/src/components/rules/RuleEditor.tsx
@@ -1093,7 +1093,7 @@ export function RuleEditor({
type: FIELD_TYPES.get(field),
field,
op: 'set',
- value: null,
+ value: '',
options: { splitIndex },
inputKey: uuid(),
};
diff --git a/packages/loot-core/src/shared/schedules.ts b/packages/loot-core/src/shared/schedules.ts
index d73e98c5b8..dc9ffcba62 100644
--- a/packages/loot-core/src/shared/schedules.ts
+++ b/packages/loot-core/src/shared/schedules.ts
@@ -4,7 +4,11 @@ import * as d from 'date-fns';
import { Locale } from 'date-fns';
import { t } from 'i18next';
-import { type PayeeEntity, type ScheduleEntity } from 'loot-core/types/models';
+import {
+ type PayeeEntity,
+ type RecurConfig,
+ type ScheduleEntity,
+} from 'loot-core/types/models';
import { Condition } from '../server/rules';
@@ -96,7 +100,11 @@ function prettyDayName(day) {
return days[day];
}
-export function getRecurringDescription(config, dateFormat, locale: Locale) {
+export function getRecurringDescription(
+ config: RecurConfig,
+ dateFormat: string,
+ locale: Locale,
+) {
const interval = config.interval || 1;
let endModeSuffix = '';
diff --git a/packages/loot-core/src/types/models/schedule.ts b/packages/loot-core/src/types/models/schedule.ts
index 16ff20442e..555ad2c3e1 100644
--- a/packages/loot-core/src/types/models/schedule.ts
+++ b/packages/loot-core/src/types/models/schedule.ts
@@ -13,7 +13,7 @@ export interface RecurConfig {
patterns?: RecurPattern[];
skipWeekend?: boolean;
start: string;
- endMode: 'never' | 'after_n_occurrences' | 'on_date';
+ endMode?: 'never' | 'after_n_occurrences' | 'on_date';
endOccurrences?: number;
endDate?: string;
weekendSolveMode?: 'before' | 'after';
diff --git a/upcoming-release-notes/6175.md b/upcoming-release-notes/6175.md
new file mode 100644
index 0000000000..fed578216e
--- /dev/null
+++ b/upcoming-release-notes/6175.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MatissJanis]
+---
+
+Fix rule page crashing when many actions added