Skip to content

A local-first personal finance app

[AI] Fix postBinary network-failure on Alpine by removing manual Content-Length (#8195)

Matiss Janis Aboltins4227d37f232d
diff --git a/packages/loot-core/src/server/errors.ts b/packages/loot-core/src/server/errors.ts
index 6bec43b674..0cba4b7f3d 100644
--- a/packages/loot-core/src/server/errors.ts
+++ b/packages/loot-core/src/server/errors.ts
@@ -4,8 +4,8 @@ export class PostError extends Error {
reason: string;
type: 'PostError';
- constructor(reason: string, meta?: { meta: string }) {
- super('PostError: ' + reason);
+ constructor(reason: string, meta?: { meta: string }, options?: ErrorOptions) {
+ super('PostError: ' + reason, options);
this.type = 'PostError';
this.reason = reason;
this.meta = meta;
diff --git a/packages/loot-core/src/server/post.test.ts b/packages/loot-core/src/server/post.test.ts
new file mode 100644
index 0000000000..57fff0fa72
--- /dev/null
+++ b/packages/loot-core/src/server/post.test.ts
@@ -0,0 +1,114 @@
+import { fetch } from '#platform/server/fetch';
+
+import { PostError } from './errors';
+import { del, patch, post, postBinary } from './post';
+
+vi.unmock('#server/post');
+vi.mock('#platform/server/fetch', () => ({
+ fetch: vi.fn(),
+}));
+
+const mockedFetch = vi.mocked(fetch);
+
+async function captureError(promise: Promise<unknown>): Promise<unknown> {
+ try {
+ await promise;
+ return null;
+ } catch (err) {
+ return err;
+ }
+}
+
+describe('postBinary', () => {
+ beforeEach(() => {
+ mockedFetch.mockReset();
+ });
+
+ it('does not set Content-Length manually and lets fetch derive it', async () => {
+ mockedFetch.mockResolvedValue(
+ new Response(new Uint8Array([1, 2, 3]), { status: 200 }),
+ );
+
+ await postBinary('https://test.env/sync/sync', new Uint8Array([9, 9, 9]), {
+ 'X-ACTUAL-TOKEN': 'token',
+ });
+
+ expect(mockedFetch).toHaveBeenCalledTimes(1);
+ const options = mockedFetch.mock.calls[0][1];
+ expect(options?.headers).not.toHaveProperty('Content-Length');
+ expect(options?.headers).toMatchObject({
+ 'Content-Type': 'application/actual-sync',
+ 'X-ACTUAL-TOKEN': 'token',
+ });
+ });
+
+ it('preserves the underlying fetch error as cause on network failure', async () => {
+ const underlying = new TypeError('fetch failed');
+ mockedFetch.mockRejectedValue(underlying);
+
+ const error = await captureError(
+ postBinary('https://test.env/sync/sync', new Uint8Array([1]), {}),
+ );
+
+ expect(error).toBeInstanceOf(PostError);
+ expect((error as PostError).reason).toBe('network-failure');
+ expect((error as PostError).cause).toBe(underlying);
+ });
+});
+
+describe('post', () => {
+ beforeEach(() => {
+ mockedFetch.mockReset();
+ });
+
+ it('preserves the underlying fetch error as cause on network failure', async () => {
+ const underlying = new TypeError('fetch failed');
+ mockedFetch.mockRejectedValue(underlying);
+
+ const error = await captureError(
+ post('https://test.env/sync/sync', { foo: 'bar' }),
+ );
+
+ expect(error).toBeInstanceOf(PostError);
+ expect((error as PostError).reason).toBe('network-failure');
+ expect((error as PostError).cause).toBe(underlying);
+ });
+});
+
+describe('del', () => {
+ beforeEach(() => {
+ mockedFetch.mockReset();
+ });
+
+ it('preserves the underlying fetch error as cause on network failure', async () => {
+ const underlying = new TypeError('fetch failed');
+ mockedFetch.mockRejectedValue(underlying);
+
+ const error = await captureError(
+ del('https://test.env/sync/sync', { foo: 'bar' }),
+ );
+
+ expect(error).toBeInstanceOf(PostError);
+ expect((error as PostError).reason).toBe('network-failure');
+ expect((error as PostError).cause).toBe(underlying);
+ });
+});
+
+describe('patch', () => {
+ beforeEach(() => {
+ mockedFetch.mockReset();
+ });
+
+ it('preserves the underlying fetch error as cause on network failure', async () => {
+ const underlying = new TypeError('fetch failed');
+ mockedFetch.mockRejectedValue(underlying);
+
+ const error = await captureError(
+ patch('https://test.env/sync/sync', { foo: 'bar' }),
+ );
+
+ expect(error).toBeInstanceOf(PostError);
+ expect((error as PostError).reason).toBe('network-failure');
+ expect((error as PostError).cause).toBe(underlying);
+ });
+});
diff --git a/packages/loot-core/src/server/post.ts b/packages/loot-core/src/server/post.ts
index c24e0487e7..7ade9d20df 100644
--- a/packages/loot-core/src/server/post.ts
+++ b/packages/loot-core/src/server/post.ts
@@ -79,7 +79,7 @@ export async function post(
) {
throw new PostError('aborted');
}
- throw new PostError('network-failure');
+ throw new PostError('network-failure', undefined, { cause: err });
} finally {
if (timeoutId != null) clearTimeout(timeoutId);
externalSignal?.removeEventListener('abort', onExternalAbort);
@@ -133,8 +133,8 @@ export async function del(url, data, headers = {}, timeout = null) {
});
clearTimeout(timeoutId);
text = await res.text();
- } catch {
- throw new PostError('network-failure');
+ } catch (err) {
+ throw new PostError('network-failure', undefined, { cause: err });
}
throwIfNot200(res, text);
@@ -181,8 +181,8 @@ export async function patch(url, data, headers = {}, timeout = null) {
});
clearTimeout(timeoutId);
text = await res.text();
- } catch {
- throw new PostError('network-failure');
+ } catch (err) {
+ throw new PostError('network-failure', undefined, { cause: err });
}
throwIfNot200(res, text);
@@ -217,13 +217,12 @@ export async function postBinary(url, data, headers) {
method: 'POST',
body: Platform.isBrowser ? data : Buffer.from(data),
headers: {
- 'Content-Length': data.length,
'Content-Type': 'application/actual-sync',
...headers,
},
});
- } catch {
- throw new PostError('network-failure');
+ } catch (err) {
+ throw new PostError('network-failure', undefined, { cause: err });
}
let buffer;
diff --git a/upcoming-release-notes/postbinary-network-failure.md b/upcoming-release-notes/postbinary-network-failure.md
new file mode 100644
index 0000000000..3cd0e4b69e
--- /dev/null
+++ b/upcoming-release-notes/postbinary-network-failure.md
@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [MatissJanis]
+---
+
+Fix binary sync failing with `network-failure` on Alpine Linux.