A local-first personal finance app
🔥 removing privacyMode feature flag (#1688)
Matiss Janis Aboltins42e1b5ca7e4a
diff --git a/packages/desktop-client/src/components/PrivacyFilter.tsx b/packages/desktop-client/src/components/PrivacyFilter.tsxindex a1d038f5f9..ac8fd543a7 100644--- a/packages/desktop-client/src/components/PrivacyFilter.tsx+++ b/packages/desktop-client/src/components/PrivacyFilter.tsx@@ -8,7 +8,6 @@ import React, {import usePrivacyMode from 'loot-core/src/client/privacy';-import useFeatureFlag from '../hooks/useFeatureFlag';import { useResponsive } from '../ResponsiveProvider';import View from './common/View';@@ -53,7 +52,6 @@ export default function PrivacyFilter({children,...props}: PrivacyFilterProps) {- let privacyModeFeatureFlag = useFeatureFlag('privacyMode');let privacyMode = usePrivacyMode();// Limit mobile support for now.let { isNarrowWidth } = useResponsive();@@ -67,7 +65,7 @@ export default function PrivacyFilter({let blurAmount = blurIntensity != null ? `${blurIntensity}px` : '3px';- return !privacyModeFeatureFlag || !activate ? (+ return !activate ? (<>{Children.toArray(children)}</>) : (<BlurredOverlay blurIntensity={blurAmount} {...props}>diff --git a/packages/desktop-client/src/components/Titlebar.tsx b/packages/desktop-client/src/components/Titlebar.tsxindex fab82dbe3a..a91446e353 100644--- a/packages/desktop-client/src/components/Titlebar.tsx+++ b/packages/desktop-client/src/components/Titlebar.tsx@@ -296,7 +296,6 @@ export default function Titlebar({ style }) {state => state.prefs.global.floatingSidebar,);- let privacyModeFeatureFlag = useFeatureFlag('privacyMode');let themesFlag = useFeatureFlag('themes');return isNarrowWidth ? null : (@@ -369,7 +368,7 @@ export default function Titlebar({ style }) {<View style={{ flex: 1 }} /><UncategorizedButton />{themesFlag && <ThemeSelector />}- {privacyModeFeatureFlag && <PrivacyButton />}+ <PrivacyButton />{serverURL ? <SyncButton style={{ marginLeft: 10 }} /> : null}<LoggedInUser style={{ marginLeft: 10 }} /></View>diff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsxindex 37ea3ac5d8..a2237ff8fc 100644--- a/packages/desktop-client/src/components/settings/Experimental.tsx+++ b/packages/desktop-client/src/components/settings/Experimental.tsx@@ -99,7 +99,6 @@ export default function ExperimentalFeatures() {Goal templates</FeatureToggle>- <FeatureToggle flag="privacyMode">Privacy mode</FeatureToggle><FeatureToggle flag="experimentalOfxParser">Experimental OFX parser</FeatureToggle>diff --git a/packages/desktop-client/src/hooks/useFeatureFlag.ts b/packages/desktop-client/src/hooks/useFeatureFlag.tsindex 70324fd6a6..84571e1fcb 100644--- a/packages/desktop-client/src/hooks/useFeatureFlag.ts+++ b/packages/desktop-client/src/hooks/useFeatureFlag.ts@@ -6,7 +6,6 @@ const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {categorySpendingReport: false,reportBudget: false,goalTemplatesEnabled: false,- privacyMode: true,themes: false,experimentalOfxParser: true,};diff --git a/packages/loot-core/src/types/prefs.d.ts b/packages/loot-core/src/types/prefs.d.tsindex 56ea97a152..ef97ecf438 100644--- a/packages/loot-core/src/types/prefs.d.ts+++ b/packages/loot-core/src/types/prefs.d.ts@@ -4,7 +4,6 @@ export type FeatureFlag =| 'categorySpendingReport'| 'reportBudget'| 'goalTemplatesEnabled'- | 'privacyMode'| 'themes'| 'experimentalOfxParser';diff --git a/upcoming-release-notes/1688.md b/upcoming-release-notes/1688.mdnew file mode 100644index 0000000000..76a928360e--- /dev/null+++ b/upcoming-release-notes/1688.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Remove `privacyMode` feature flag as this feature is GA