Skip to content

A local-first personal finance app

Use the maximum access validity time provided by GoCardless (#551)

Matt Fiddaman45d53ff771b6
diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js
index a2c32ea941..78967e873d 100644
--- a/src/app-gocardless/bank-factory.js
+++ b/src/app-gocardless/bank-factory.js
@@ -13,7 +13,6 @@ import DanskebankDabno22 from './banks/danskebank_dabno22.js';
import EasybankBawaatww from './banks/easybank_bawaatww.js';
import EntercardSwednokk from './banks/entercard_swednokk.js';
import FortuneoFtnofrp1xxx from './banks/fortuneo_ftnofrp1xxx.js';
-import HanseaticHstbdehh from './banks/hanseatic_hstbdehh.js';
import HypeHyeeit22 from './banks/hype_hyeeit22.js';
import IngIngbrobu from './banks/ing_ingbrobu.js';
import IngIngddeff from './banks/ing_ingddeff.js';
@@ -53,7 +52,6 @@ export const banks = [
EasybankBawaatww,
EntercardSwednokk,
FortuneoFtnofrp1xxx,
- HanseaticHstbdehh,
HypeHyeeit22,
IngIngbrobu,
IngIngddeff,
diff --git a/src/app-gocardless/banks/abanca_caglesmm.js b/src/app-gocardless/banks/abanca_caglesmm.js
index bd485331bb..7a81aa2e99 100644
--- a/src/app-gocardless/banks/abanca_caglesmm.js
+++ b/src/app-gocardless/banks/abanca_caglesmm.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['ABANCA_CAGLESMM', 'ABANCA_CAGLPTPL'],
- accessValidForDays: 180,
-
// Abanca transactions doesn't get the creditorName/debtorName properly
normalizeTransaction(transaction, _booked) {
transaction.creditorName = transaction.remittanceInformationStructured;
diff --git a/src/app-gocardless/banks/abnamro_abnanl2a.js b/src/app-gocardless/banks/abnamro_abnanl2a.js
index 0bf6e216f7..2b260953f6 100644
--- a/src/app-gocardless/banks/abnamro_abnanl2a.js
+++ b/src/app-gocardless/banks/abnamro_abnanl2a.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['ABNAMRO_ABNANL2A'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
// There is no remittanceInformationUnstructured, so we'll make it
transaction.remittanceInformationUnstructured =
diff --git a/src/app-gocardless/banks/american_express_aesudef1.js b/src/app-gocardless/banks/american_express_aesudef1.js
index 2ae8168dfc..dcf6a20bcc 100644
--- a/src/app-gocardless/banks/american_express_aesudef1.js
+++ b/src/app-gocardless/banks/american_express_aesudef1.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['AMERICAN_EXPRESS_AESUDEF1'],
- accessValidForDays: 180,
-
normalizeAccount(account) {
return {
...Fallback.normalizeAccount(account),
diff --git a/src/app-gocardless/banks/bancsabadell_bsabesbbb.js b/src/app-gocardless/banks/bancsabadell_bsabesbbb.js
index 832fb8953c..1aa41e911b 100644
--- a/src/app-gocardless/banks/bancsabadell_bsabesbbb.js
+++ b/src/app-gocardless/banks/bancsabadell_bsabesbbb.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['BANCSABADELL_BSABESBB'],
- accessValidForDays: 180,
-
// Sabadell transactions don't get the creditorName/debtorName properly
normalizeTransaction(transaction, _booked) {
const amount = transaction.transactionAmount.amount;
diff --git a/src/app-gocardless/banks/bank.interface.ts b/src/app-gocardless/banks/bank.interface.ts
index 21e8758156..18de655238 100644
--- a/src/app-gocardless/banks/bank.interface.ts
+++ b/src/app-gocardless/banks/bank.interface.ts
@@ -7,8 +7,6 @@ import { Transaction, Balance } from '../gocardless-node.types.js';
export interface IBank {
institutionIds: string[];
- accessValidForDays: number;
-
/**
* Returns normalized object with required data for the frontend
*/
diff --git a/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js b/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js
index 6e677775d3..959a0fd986 100644
--- a/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js
+++ b/src/app-gocardless/banks/bank_of_ireland_b365_bofiie2d.js
@@ -6,8 +6,6 @@ export default {
institutionIds: ['BANK_OF_IRELAND_B365_BOFIIE2D'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, booked) {
transaction.remittanceInformationUnstructured = fixupPayee(
transaction.remittanceInformationUnstructured,
diff --git a/src/app-gocardless/banks/bankinter_bkbkesmm.js b/src/app-gocardless/banks/bankinter_bkbkesmm.js
index 92672d6def..8d1c329758 100644
--- a/src/app-gocardless/banks/bankinter_bkbkesmm.js
+++ b/src/app-gocardless/banks/bankinter_bkbkesmm.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['BANKINTER_BKBKESMM'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
transaction.remittanceInformationUnstructured =
transaction.remittanceInformationUnstructured
diff --git a/src/app-gocardless/banks/belfius_gkccbebb.js b/src/app-gocardless/banks/belfius_gkccbebb.js
index ebec54e126..594689edc7 100644
--- a/src/app-gocardless/banks/belfius_gkccbebb.js
+++ b/src/app-gocardless/banks/belfius_gkccbebb.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['BELFIUS_GKCCBEBB'],
- accessValidForDays: 180,
-
// The problem is that we have transaction with duplicated transaction ids.
// This is not expected and the nordigen api has a work-around for some backs
// They will set an internalTransactionId which is unique
diff --git a/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js b/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js
index 2ef27d7d63..9c8c3d9f65 100644
--- a/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js
+++ b/src/app-gocardless/banks/berliner_sparkasse_beladebexxx.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['BERLINER_SPARKASSE_BELADEBEXXX'],
- accessValidForDays: 180,
-
/**
* Following the GoCardless documentation[0] we should prefer `bookingDate`
* here, though some of their bank integrations uses the date field
diff --git a/src/app-gocardless/banks/bnp_be_gebabebb.js b/src/app-gocardless/banks/bnp_be_gebabebb.js
index 9af2fa674b..c00601939e 100644
--- a/src/app-gocardless/banks/bnp_be_gebabebb.js
+++ b/src/app-gocardless/banks/bnp_be_gebabebb.js
@@ -12,8 +12,6 @@ export default {
'BNP_BE_GEBABEBB',
],
- accessValidForDays: 180,
-
/** BNP_BE_GEBABEBB provides a lot of useful information via the 'additionalField'
* There does not seem to be a specification of this field, but the following information is contained in its subfields:
* - for pending transactions: the 'atmPosName'
diff --git a/src/app-gocardless/banks/cbc_cregbebb.js b/src/app-gocardless/banks/cbc_cregbebb.js
index 94ab202859..bf881dacf3 100644
--- a/src/app-gocardless/banks/cbc_cregbebb.js
+++ b/src/app-gocardless/banks/cbc_cregbebb.js
@@ -7,8 +7,6 @@ export default {
institutionIds: ['CBC_CREGBEBB'],
- accessValidForDays: 180,
-
/**
* For negative amounts, the only payee information we have is returned in
* remittanceInformationUnstructured.
diff --git a/src/app-gocardless/banks/danskebank_dabno22.js b/src/app-gocardless/banks/danskebank_dabno22.js
index 3d83ea9506..39a1f13b34 100644
--- a/src/app-gocardless/banks/danskebank_dabno22.js
+++ b/src/app-gocardless/banks/danskebank_dabno22.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['DANSKEBANK_DABANO22'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
/**
* Danske Bank appends the EndToEndID: NOTPROVIDED to
diff --git a/src/app-gocardless/banks/easybank_bawaatww.js b/src/app-gocardless/banks/easybank_bawaatww.js
index f93ab951f4..635cbf33f7 100644
--- a/src/app-gocardless/banks/easybank_bawaatww.js
+++ b/src/app-gocardless/banks/easybank_bawaatww.js
@@ -10,8 +10,6 @@ export default {
institutionIds: ['EASYBANK_BAWAATWW'],
- accessValidForDays: 179,
-
// If date is same, sort by transactionId
sortTransactions: (transactions = []) =>
transactions.sort((a, b) => {
diff --git a/src/app-gocardless/banks/entercard_swednokk.js b/src/app-gocardless/banks/entercard_swednokk.js
index daafbfb89c..c71c306b2c 100644
--- a/src/app-gocardless/banks/entercard_swednokk.js
+++ b/src/app-gocardless/banks/entercard_swednokk.js
@@ -11,8 +11,6 @@ export default {
institutionIds: ['ENTERCARD_SWEDNOKK'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
// GoCardless's Entercard integration returns forex transactions with the
// foreign amount in `transactionAmount`, but at least the amount actually
diff --git a/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js b/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js
index e05634e4e9..c695c0f1fa 100644
--- a/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js
+++ b/src/app-gocardless/banks/fortuneo_ftnofrp1xxx.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['FORTUNEO_FTNOFRP1XXX'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
const date =
transaction.bookingDate ||
diff --git a/src/app-gocardless/banks/hanseatic_hstbdehh.js b/src/app-gocardless/banks/hanseatic_hstbdehh.js
deleted file mode 100644
index 143f92bf49..0000000000
--- a/src/app-gocardless/banks/hanseatic_hstbdehh.js
+++ /dev/null
@@ -1,10 +0,0 @@
-import Fallback from './integration-bank.js';
-
-/** @type {import('./bank.interface.js').IBank} */
-export default {
- ...Fallback,
-
- institutionIds: ['HANSEATIC_HSTBDEHH'],
-
- accessValidForDays: 89,
-};
diff --git a/src/app-gocardless/banks/hype_hyeeit22.js b/src/app-gocardless/banks/hype_hyeeit22.js
index d69efda8e7..fdbfc02187 100644
--- a/src/app-gocardless/banks/hype_hyeeit22.js
+++ b/src/app-gocardless/banks/hype_hyeeit22.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['HYPE_HYEEIT22'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
/** Online card payments - identified by "crd" transaction code
* always start with PAGAMENTO PRESSO + <payee name>
diff --git a/src/app-gocardless/banks/ing_ingbrobu.js b/src/app-gocardless/banks/ing_ingbrobu.js
index 4f90da51c9..b514d78e8d 100644
--- a/src/app-gocardless/banks/ing_ingbrobu.js
+++ b/src/app-gocardless/banks/ing_ingbrobu.js
@@ -6,8 +6,6 @@ export default {
institutionIds: ['ING_INGBROBU'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, booked) {
//Merchant transactions all have the same transactionId of 'NOTPROVIDED'.
//For booked transactions, this can be set to the internalTransactionId
diff --git a/src/app-gocardless/banks/ing_ingddeff.js b/src/app-gocardless/banks/ing_ingddeff.js
index 3eabb99084..57907ee76b 100644
--- a/src/app-gocardless/banks/ing_ingddeff.js
+++ b/src/app-gocardless/banks/ing_ingddeff.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['ING_INGDDEFF'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
const remittanceInformationMatch = /remittanceinformation:(.*)$/.exec(
transaction.remittanceInformationUnstructured,
diff --git a/src/app-gocardless/banks/ing_pl_ingbplpw.js b/src/app-gocardless/banks/ing_pl_ingbplpw.js
index 248068cb84..611f67cab5 100644
--- a/src/app-gocardless/banks/ing_pl_ingbplpw.js
+++ b/src/app-gocardless/banks/ing_pl_ingbplpw.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['ING_PL_INGBPLPW'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
return {
...transaction,
diff --git a/src/app-gocardless/banks/integration-bank.js b/src/app-gocardless/banks/integration-bank.js
index c96b085019..70f3c1cf34 100644
--- a/src/app-gocardless/banks/integration-bank.js
+++ b/src/app-gocardless/banks/integration-bank.js
@@ -20,13 +20,6 @@ const SORTED_BALANCE_TYPE_LIST = [
export default {
institutionIds: ['IntegrationBank'],
- // EEA need to allow at least 180 days now but this doesn't apply to UK
- // banks, and it's possible that there are EEA banks which still don't follow
- // the new requirements. See:
- // - https://nordigen.zendesk.com/hc/en-gb/articles/13239212055581-EEA-180-day-access
- // - https://nordigen.zendesk.com/hc/en-gb/articles/6760902653085-Extended-history-and-continuous-access-edge-cases
- accessValidForDays: 90,
-
normalizeAccount(account) {
console.debug(
'Available account properties for new institution integration',
diff --git a/src/app-gocardless/banks/isybank_itbbitmm.js b/src/app-gocardless/banks/isybank_itbbitmm.js
index cc7e78ac39..a6685ccae0 100644
--- a/src/app-gocardless/banks/isybank_itbbitmm.js
+++ b/src/app-gocardless/banks/isybank_itbbitmm.js
@@ -6,8 +6,6 @@ export default {
institutionIds: ['ISYBANK_ITBBITMM'],
- accessValidForDays: 180,
-
// It has been reported that valueDate is more accurate than booking date
// when it is provided
normalizeTransaction(transaction, booked) {
diff --git a/src/app-gocardless/banks/kbc_kredbebb.js b/src/app-gocardless/banks/kbc_kredbebb.js
index 6818a2f558..7397340732 100644
--- a/src/app-gocardless/banks/kbc_kredbebb.js
+++ b/src/app-gocardless/banks/kbc_kredbebb.js
@@ -7,8 +7,6 @@ export default {
institutionIds: ['KBC_KREDBEBB'],
- accessValidForDays: 180,
-
/**
* For negative amounts, the only payee information we have is returned in
* remittanceInformationUnstructured.
diff --git a/src/app-gocardless/banks/mbank_retail_brexplpw.js b/src/app-gocardless/banks/mbank_retail_brexplpw.js
index 2f6e3c943b..27764e40fc 100644
--- a/src/app-gocardless/banks/mbank_retail_brexplpw.js
+++ b/src/app-gocardless/banks/mbank_retail_brexplpw.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['MBANK_RETAIL_BREXPLPW'],
- accessValidForDays: 179,
-
normalizeTransaction(transaction, _booked) {
return {
...transaction,
diff --git a/src/app-gocardless/banks/nbg_ethngraaxxx.js b/src/app-gocardless/banks/nbg_ethngraaxxx.js
index b915ee3bdf..3bdb4b4650 100644
--- a/src/app-gocardless/banks/nbg_ethngraaxxx.js
+++ b/src/app-gocardless/banks/nbg_ethngraaxxx.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['NBG_ETHNGRAAXXX'],
- accessValidForDays: 180,
-
/**
* Fixes for the pending transactions:
* - Corrects amount to negative (nbg erroneously omits the minus sign in pending transactions)
diff --git a/src/app-gocardless/banks/norwegian_xx_norwnok1.js b/src/app-gocardless/banks/norwegian_xx_norwnok1.js
index 0a00a34e98..67900828bd 100644
--- a/src/app-gocardless/banks/norwegian_xx_norwnok1.js
+++ b/src/app-gocardless/banks/norwegian_xx_norwnok1.js
@@ -16,8 +16,6 @@ export default {
'NORWEGIAN_FI_NORWNOK1',
],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, booked) {
if (booked) {
return {
diff --git a/src/app-gocardless/banks/revolut_revolt21.js b/src/app-gocardless/banks/revolut_revolt21.js
index 61b27c5a24..c2c4408419 100644
--- a/src/app-gocardless/banks/revolut_revolt21.js
+++ b/src/app-gocardless/banks/revolut_revolt21.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['REVOLUT_REVOLT21'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
if (
transaction.remittanceInformationUnstructuredArray[0].startsWith(
diff --git a/src/app-gocardless/banks/sandboxfinance_sfin0000.js b/src/app-gocardless/banks/sandboxfinance_sfin0000.js
index 0debc60306..65bdeafdb1 100644
--- a/src/app-gocardless/banks/sandboxfinance_sfin0000.js
+++ b/src/app-gocardless/banks/sandboxfinance_sfin0000.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['SANDBOXFINANCE_SFIN0000'],
- accessValidForDays: 180,
-
/**
* Following the GoCardless documentation[0] we should prefer `bookingDate`
* here, though some of their bank integrations uses the date field
diff --git a/src/app-gocardless/banks/seb_kort_bank_ab.js b/src/app-gocardless/banks/seb_kort_bank_ab.js
index 3b465641f2..c159a1f058 100644
--- a/src/app-gocardless/banks/seb_kort_bank_ab.js
+++ b/src/app-gocardless/banks/seb_kort_bank_ab.js
@@ -13,8 +13,6 @@ export default {
'SEB_CARD_ESSESESS',
],
- accessValidForDays: 180,
-
/**
* Sign of transaction amount needs to be flipped for SEB credit cards
*/
diff --git a/src/app-gocardless/banks/seb_privat.js b/src/app-gocardless/banks/seb_privat.js
index 0ff079ebf8..de6a4a4161 100644
--- a/src/app-gocardless/banks/seb_privat.js
+++ b/src/app-gocardless/banks/seb_privat.js
@@ -10,8 +10,6 @@ export default {
institutionIds: ['SEB_ESSESESS_PRIVATE'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
const date =
transaction.bookingDate ||
diff --git a/src/app-gocardless/banks/sparnord_spnodk22.js b/src/app-gocardless/banks/sparnord_spnodk22.js
index 37980fafbb..5b3179cfe0 100644
--- a/src/app-gocardless/banks/sparnord_spnodk22.js
+++ b/src/app-gocardless/banks/sparnord_spnodk22.js
@@ -12,8 +12,6 @@ export default {
'ANDELSKASSEN_FALLESKASSEN_FAELDKK1',
],
- accessValidForDays: 180,
-
/**
* Banks on the BEC backend only give information regarding the transaction in additionalInformation
*/
diff --git a/src/app-gocardless/banks/spk_karlsruhe_karsde66.js b/src/app-gocardless/banks/spk_karlsruhe_karsde66.js
index 9b8e6a2153..7974c52aea 100644
--- a/src/app-gocardless/banks/spk_karlsruhe_karsde66.js
+++ b/src/app-gocardless/banks/spk_karlsruhe_karsde66.js
@@ -9,8 +9,6 @@ export default {
institutionIds: ['SPK_KARLSRUHE_KARSDE66XXX'],
- accessValidForDays: 180,
-
/**
* Following the GoCardless documentation[0] we should prefer `bookingDate`
* here, though some of their bank integrations uses the date field
diff --git a/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js b/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js
index 3491b131bb..00b4fbe222 100644
--- a/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js
+++ b/src/app-gocardless/banks/spk_marburg_biedenkopf_heladef1mar.js
@@ -10,8 +10,6 @@ export default {
institutionIds: ['SPK_MARBURG_BIEDENKOPF_HELADEF1MAR'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
const date =
transaction.bookingDate ||
diff --git a/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js b/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js
index 0d38a0244e..d2c153c505 100644
--- a/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js
+++ b/src/app-gocardless/banks/spk_worms_alzey_ried_malade51wor.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['SPK_WORMS_ALZEY_RIED_MALADE51WOR'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
const date = transaction.bookingDate || transaction.valueDate;
if (!date) {
diff --git a/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js b/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js
index 2e320d366a..1de9f4848d 100644
--- a/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js
+++ b/src/app-gocardless/banks/ssk_dusseldorf_dussdeddxxx.js
@@ -6,8 +6,6 @@ export default {
institutionIds: ['SSK_DUSSELDORF_DUSSDEDDXXX'],
- accessValidForDays: 180,
-
normalizeTransaction(transaction, _booked) {
// Prioritize unstructured information, falling back to structured formats
let remittanceInformationUnstructured =
diff --git a/src/app-gocardless/banks/swedbank_habalv22.js b/src/app-gocardless/banks/swedbank_habalv22.js
index 8bea1360a7..205bf04558 100644
--- a/src/app-gocardless/banks/swedbank_habalv22.js
+++ b/src/app-gocardless/banks/swedbank_habalv22.js
@@ -8,8 +8,6 @@ export default {
institutionIds: ['SWEDBANK_HABALV22'],
- accessValidForDays: 180,
-
/**
* The actual transaction date for card transactions is only available in the remittanceInformationUnstructured field when the transaction is booked.
*/
diff --git a/src/app-gocardless/banks/tests/ing_ingddeff.spec.js b/src/app-gocardless/banks/tests/ing_ingddeff.spec.js
index 156875bdfe..f1279d3a40 100644
--- a/src/app-gocardless/banks/tests/ing_ingddeff.spec.js
+++ b/src/app-gocardless/banks/tests/ing_ingddeff.spec.js
@@ -20,6 +20,7 @@ describe('IngIngddeff', () => {
name: 'ING',
bic: 'INGDDEFFXXX',
transaction_total_days: '390',
+ max_access_valid_for_days: '90',
countries: ['DE'],
logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/ing.png',
supported_payments: {
@@ -59,6 +60,7 @@ describe('IngIngddeff', () => {
'single-payment': ['SCT'],
},
transaction_total_days: '390',
+ max_access_valid_for_days: '90',
},
mask: '5030',
name: 'Girokonto (XXX 5030) EUR',
diff --git a/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js b/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js
index a38a616466..a61d580ee2 100644
--- a/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js
+++ b/src/app-gocardless/banks/tests/ing_pl_ingbplpw.spec.js
@@ -26,6 +26,7 @@ describe('IngPlIngbplpw', () => {
name: 'ING',
bic: 'INGBPLPW',
transaction_total_days: '365',
+ max_access_valid_for_days: '90',
countries: ['PL'],
logo: 'https://cdn.nordigen.com/ais/ING_PL_INGBPLPW.png',
supported_payments: {},
@@ -43,34 +44,35 @@ describe('IngPlIngbplpw', () => {
it('returns normalized account data returned to Frontend', () => {
const normalizedAccount = IngPlIngbplpw.normalizeAccount(accountRaw);
expect(normalizedAccount).toMatchInlineSnapshot(`
- {
- "account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",
- "iban": "PL00000000000000000987654321",
- "institution": {
- "bic": "INGBPLPW",
- "countries": [
- "PL",
- ],
- "id": "ING_PL_INGBPLPW",
- "logo": "https://cdn.nordigen.com/ais/ING_PL_INGBPLPW.png",
- "name": "ING",
- "supported_features": [
- "access_scopes",
- "business_accounts",
- "card_accounts",
- "corporate_accounts",
- "pending_transactions",
- "private_accounts",
- ],
- "supported_payments": {},
- "transaction_total_days": "365",
- },
- "mask": "4321",
- "name": "Current Account for Individuals (Retail) (XXX 4321) PLN",
- "official_name": "Current Account for Individuals (Retail)",
- "type": "checking",
- }
- `);
+ {
+ "account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",
+ "iban": "PL00000000000000000987654321",
+ "institution": {
+ "bic": "INGBPLPW",
+ "countries": [
+ "PL",
+ ],
+ "id": "ING_PL_INGBPLPW",
+ "logo": "https://cdn.nordigen.com/ais/ING_PL_INGBPLPW.png",
+ "max_access_valid_for_days": "90",
+ "name": "ING",
+ "supported_features": [
+ "access_scopes",
+ "business_accounts",
+ "card_accounts",
+ "corporate_accounts",
+ "pending_transactions",
+ "private_accounts",
+ ],
+ "supported_payments": {},
+ "transaction_total_days": "365",
+ },
+ "mask": "4321",
+ "name": "Current Account for Individuals (Retail) (XXX 4321) PLN",
+ "official_name": "Current Account for Individuals (Retail)",
+ "type": "checking",
+ }
+ `);
});
});
diff --git a/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js b/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js
index d4113df8ff..b99eb1b690 100644
--- a/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js
+++ b/src/app-gocardless/banks/tests/mbank_retail_brexplpw.spec.js
@@ -26,6 +26,7 @@ describe('MbankRetailBrexplpw', () => {
name: 'mBank Retail',
bic: 'BREXPLPW',
transaction_total_days: '90',
+ max_access_valid_for_days: '90',
countries: ['PL'],
logo: 'https://cdn.nordigen.com/ais/MBANK_RETAIL_BREXCZPP.png',
supported_payments: {},
@@ -42,34 +43,35 @@ describe('MbankRetailBrexplpw', () => {
it('returns normalized account data returned to Frontend', () => {
expect(MbankRetailBrexplpw.normalizeAccount(accountRaw))
.toMatchInlineSnapshot(`
- {
- "account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",
- "iban": "PL00000000000000000987654321",
- "institution": {
- "bic": "BREXPLPW",
- "countries": [
- "PL",
- ],
- "id": "MBANK_RETAIL_BREXPLPW",
- "logo": "https://cdn.nordigen.com/ais/MBANK_RETAIL_BREXCZPP.png",
- "name": "mBank Retail",
- "supported_features": [
- "access_scopes",
- "business_accounts",
- "card_accounts",
- "corporate_accounts",
- "pending_transactions",
- "private_accounts",
- ],
- "supported_payments": {},
- "transaction_total_days": "90",
- },
- "mask": "4321",
- "name": "EKONTO (XXX 4321) PLN",
- "official_name": "RACHUNEK BIEŻĄCY",
- "type": "checking",
- }
- `);
+ {
+ "account_id": "d3eccc94-9536-48d3-98be-813f79199ee3",
+ "iban": "PL00000000000000000987654321",
+ "institution": {
+ "bic": "BREXPLPW",
+ "countries": [
+ "PL",
+ ],
+ "id": "MBANK_RETAIL_BREXPLPW",
+ "logo": "https://cdn.nordigen.com/ais/MBANK_RETAIL_BREXCZPP.png",
+ "max_access_valid_for_days": "90",
+ "name": "mBank Retail",
+ "supported_features": [
+ "access_scopes",
+ "business_accounts",
+ "card_accounts",
+ "corporate_accounts",
+ "pending_transactions",
+ "private_accounts",
+ ],
+ "supported_payments": {},
+ "transaction_total_days": "90",
+ },
+ "mask": "4321",
+ "name": "EKONTO (XXX 4321) PLN",
+ "official_name": "RACHUNEK BIEŻĄCY",
+ "type": "checking",
+ }
+ `);
});
});
diff --git a/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js b/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js
index a0ac23c1f1..af3612c0cc 100644
--- a/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js
+++ b/src/app-gocardless/banks/tests/sandboxfinance_sfin0000.spec.js
@@ -22,6 +22,7 @@ describe('SandboxfinanceSfin0000', () => {
name: 'Sandbox Finance',
bic: 'SFIN0000',
transaction_total_days: '90',
+ max_access_valid_for_days: '90',
countries: ['XX'],
logo: 'https://cdn.nordigen.com/ais/SANDBOXFINANCE_SFIN0000.png',
supported_payments: {},
@@ -32,27 +33,28 @@ describe('SandboxfinanceSfin0000', () => {
it('returns normalized account data returned to Frontend', () => {
expect(SandboxfinanceSfin0000.normalizeAccount(accountRaw))
.toMatchInlineSnapshot(`
- {
- "account_id": "99a0bfe2-0bef-46df-bff2-e9ae0c6c5838",
- "iban": "GL0865354374424724",
- "institution": {
- "bic": "SFIN0000",
- "countries": [
- "XX",
- ],
- "id": "SANDBOXFINANCE_SFIN0000",
- "logo": "https://cdn.nordigen.com/ais/SANDBOXFINANCE_SFIN0000.png",
- "name": "Sandbox Finance",
- "supported_features": [],
- "supported_payments": {},
- "transaction_total_days": "90",
- },
- "mask": "4724",
- "name": "Main Account (XXX 4724) EUR",
- "official_name": "Checkings",
- "type": "checking",
- }
- `);
+ {
+ "account_id": "99a0bfe2-0bef-46df-bff2-e9ae0c6c5838",
+ "iban": "GL0865354374424724",
+ "institution": {
+ "bic": "SFIN0000",
+ "countries": [
+ "XX",
+ ],
+ "id": "SANDBOXFINANCE_SFIN0000",
+ "logo": "https://cdn.nordigen.com/ais/SANDBOXFINANCE_SFIN0000.png",
+ "max_access_valid_for_days": "90",
+ "name": "Sandbox Finance",
+ "supported_features": [],
+ "supported_payments": {},
+ "transaction_total_days": "90",
+ },
+ "mask": "4724",
+ "name": "Main Account (XXX 4724) EUR",
+ "official_name": "Checkings",
+ "type": "checking",
+ }
+ `);
});
});
diff --git a/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js b/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js
index bf3bf365b0..7cac1ab81a 100644
--- a/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js
+++ b/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js
@@ -22,6 +22,7 @@ describe('SpkMarburgBiedenkopfHeladef1mar', () => {
name: 'Sparkasse Marburg-Biedenkopf',
bic: 'HELADEF1MAR',
transaction_total_days: '360',
+ max_access_valid_for_days: '90',
countries: ['DE'],
logo: 'https://storage.googleapis.com/gc-prd-institution_icons-production/DE/PNG/sparkasse.png',
supported_payments: {
@@ -57,6 +58,7 @@ describe('SpkMarburgBiedenkopfHeladef1mar', () => {
'single-payment': ['SCT', 'ISCT'],
},
transaction_total_days: '360',
+ max_access_valid_for_days: '90',
},
mask: '6789',
name: 'Sichteinlagen (XXX 6789) EUR',
diff --git a/src/app-gocardless/gocardless-node.types.ts b/src/app-gocardless/gocardless-node.types.ts
index c5ed93205a..c7d3809b93 100644
--- a/src/app-gocardless/gocardless-node.types.ts
+++ b/src/app-gocardless/gocardless-node.types.ts
@@ -253,6 +253,12 @@ export type Institution = {
*/
logo: string;
+ /**
+ * The total number of days that a requisition stays valid before requiring
+ * renewal
+ */
+ max_access_valid_for_days: string;
+
supported_payments?: object;
supported_features?: string[];
};
diff --git a/src/app-gocardless/services/gocardless-service.js b/src/app-gocardless/services/gocardless-service.js
index 754e36d118..81e5c77d57 100644
--- a/src/app-gocardless/services/gocardless-service.js
+++ b/src/app-gocardless/services/gocardless-service.js
@@ -313,7 +313,6 @@ export const goCardlessService = {
await goCardlessService.setToken();
const institution = await goCardlessService.getInstitution(institutionId);
- const bank = BankFactory(institutionId);
let response;
try {
@@ -321,7 +320,7 @@ export const goCardlessService = {
redirectUrl: host + '/gocardless/link',
institutionId,
referenceId: uuid.v4(),
- accessValidForDays: bank.accessValidForDays,
+ accessValidForDays: institution.max_access_valid_for_days,
maxHistoricalDays: BANKS_WITH_LIMITED_HISTORY.includes(institutionId)
? Number(institution.transaction_total_days) >= 90
? '89'
diff --git a/src/app-gocardless/services/tests/fixtures.js b/src/app-gocardless/services/tests/fixtures.js
index 5e373e5a34..40c34501a3 100644
--- a/src/app-gocardless/services/tests/fixtures.js
+++ b/src/app-gocardless/services/tests/fixtures.js
@@ -104,6 +104,7 @@ export const mockInstitution = {
name: 'N26 Bank',
bic: 'NTSBDEB1',
transaction_total_days: '90',
+ max_access_valid_for_days: '90',
countries: ['GB', 'NO', 'SE'],
logo: 'https://cdn.nordigen.com/ais/N26_SANDBOX_NTSBDEB1.png',
};
diff --git a/upcoming-release-notes/551.md b/upcoming-release-notes/551.md
new file mode 100644
index 0000000000..c335d9f552
--- /dev/null
+++ b/upcoming-release-notes/551.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [matt-fidd]
+---
+
+Use the maximum access validity time provided by GoCardless