Skip to content

A local-first personal finance app

fix error when clearing the payee field of a transaction (#7532)

Matt Fiddaman4b28a8146e5d
diff --git a/packages/loot-core/src/server/aql/schema-helpers.test.ts b/packages/loot-core/src/server/aql/schema-helpers.test.ts
index 2f9dda489a..e86464467a 100644
--- a/packages/loot-core/src/server/aql/schema-helpers.test.ts
+++ b/packages/loot-core/src/server/aql/schema-helpers.test.ts
@@ -201,6 +201,18 @@ describe('schema-helpers', () => {
});
});
+ test('undefined values are skipped when updating', () => {
+ const trans = convertForUpdate(basicSchema, {}, 'transactions', {
+ id: 'id',
+ notes: undefined,
+ cleared: false,
+ });
+ expect(trans).toEqual({
+ id: 'id',
+ cleared: 0,
+ });
+ });
+
test('floats are not allowed as input types to integers', () => {
expect(() => {
convertForUpdate(basicSchema, {}, 'transactions', {
diff --git a/packages/loot-core/src/server/aql/schema-helpers.ts b/packages/loot-core/src/server/aql/schema-helpers.ts
index bbb1c2de85..8bbb800768 100644
--- a/packages/loot-core/src/server/aql/schema-helpers.ts
+++ b/packages/loot-core/src/server/aql/schema-helpers.ts
@@ -132,6 +132,11 @@ export function conform(
);
}
+ // treat undefined as missing
+ if (obj[field] === undefined) {
+ return null;
+ }
+
// This option removes null values (see `convertForInsert`)
if (skipNull && obj[field] == null) {
return null;
diff --git a/upcoming-release-notes/7532.md b/upcoming-release-notes/7532.md
new file mode 100644
index 0000000000..6d752c907c
--- /dev/null
+++ b/upcoming-release-notes/7532.md
@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [matt-fidd]
+---
+
+Fix error when clearing the payee field of a transaction