Skip to content

A local-first personal finance app

fix crash when enter is used to submit empty date in date picker (#5423)

Julian4cdff7654710
diff --git a/packages/desktop-client/src/components/select/DateSelect.tsx b/packages/desktop-client/src/components/select/DateSelect.tsx
index 9b6369bd46..14f1f10c81 100644
--- a/packages/desktop-client/src/components/select/DateSelect.tsx
+++ b/packages/desktop-client/src/components/select/DateSelect.tsx
@@ -346,11 +346,13 @@ export function DateSelect({
onUpdate?.(defaultValue);
}
} else if (shouldSaveFromKey(e)) {
- setValue(selectedValue);
- setOpen(false);
+ if (selectedValue) {
+ setValue(selectedValue);
+ const date = parse(selectedValue, dateFormat, new Date());
+ onSelect(format(date, 'yyyy-MM-dd'));
+ }
- const date = parse(selectedValue, dateFormat, new Date());
- onSelect(format(date, 'yyyy-MM-dd'));
+ setOpen(false);
if (open && e.key === 'Enter') {
// This stops the event from propagating up
diff --git a/upcoming-release-notes/5423.md b/upcoming-release-notes/5423.md
new file mode 100644
index 0000000000..98d0df46ce
--- /dev/null
+++ b/upcoming-release-notes/5423.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [Serializator]
+---
+
+Fix crash when the enter key is used to submit an empty date to the date picker