Skip to content

A local-first personal finance app

ensure file upload size limits are respected when syncing files (#5779)

Matt Fiddaman4e9e153989c5
diff --git a/packages/sync-server/src/app-sync.ts b/packages/sync-server/src/app-sync.ts
index e5d630382d..e40923cb74 100644
--- a/packages/sync-server/src/app-sync.ts
+++ b/packages/sync-server/src/app-sync.ts
@@ -17,6 +17,7 @@ import {
validateSyncedFile,
validateUploadedFile,
} from './app-sync/validation.js';
+import { config } from './load-config.js';
import * as simpleSync from './sync-simple.js';
import {
errorMiddleware,
@@ -29,9 +30,19 @@ const app = express();
app.use(validateSessionMiddleware);
app.use(errorMiddleware);
app.use(requestLoggerMiddleware);
-app.use(express.raw({ type: 'application/actual-sync' }));
-app.use(express.raw({ type: 'application/encrypted-file' }));
-app.use(express.json());
+app.use(
+ express.raw({
+ type: 'application/actual-sync',
+ limit: `${config.get('upload.fileSizeSyncLimitMB')}mb`,
+ }),
+);
+app.use(
+ express.raw({
+ type: 'application/encrypted-file',
+ limit: `${config.get('upload.syncEncryptedFileSizeLimitMB')}mb`,
+ }),
+);
+app.use(express.json({ limit: `${config.get('upload.fileSizeLimitMB')}mb` }));
export { app as handlers };
diff --git a/upcoming-release-notes/5779.md b/upcoming-release-notes/5779.md
new file mode 100644
index 0000000000..df0746f899
--- /dev/null
+++ b/upcoming-release-notes/5779.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [matt-fidd]
+---
+
+Ensure file upload size limits are respected when syncing files