Skip to content

A local-first personal finance app

:bug: Fix flicker when saving transaction on account page when transactions are scheduled (#3920)

Michael Clark501c8653efd4
diff --git a/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts b/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts
index ca1471c999..d66e768722 100644
--- a/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts
+++ b/packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts
@@ -32,10 +32,6 @@ export function useAccountPreviewTransactions({
const payees = usePayees();
const previewTransactions = useMemo(() => {
- if (isLoading) {
- return [];
- }
-
if (!accountId) {
return originalPreviewTransactions;
}
@@ -50,9 +46,12 @@ export function useAccountPreviewTransactions({
a => a.id === payees.find(p => p.id === payeeId)?.transfer_acct,
),
});
- }, [accountId, accounts, isLoading, originalPreviewTransactions, payees]);
+ }, [accountId, accounts, originalPreviewTransactions, payees]);
- return { isLoading, previewTransactions };
+ return {
+ isLoading,
+ previewTransactions,
+ };
}
type AccountPreviewProps = {
diff --git a/upcoming-release-notes/3920.md b/upcoming-release-notes/3920.md
new file mode 100644
index 0000000000..e0abd6667c
--- /dev/null
+++ b/upcoming-release-notes/3920.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [MikesGlitch]
+---
+
+Fix flickering when saving a transaction when there are transactions scheduled