Skip to content

A local-first personal finance app

[AI] Fix last zizmor issues (#7975)

Matiss Janis Aboltins5565236ba723
diff --git a/.github/workflows/ai-generated-label.yml b/.github/workflows/ai-generated-label.yml
index f56c529835..82f99ffab9 100644
--- a/.github/workflows/ai-generated-label.yml
+++ b/.github/workflows/ai-generated-label.yml
@@ -21,7 +21,9 @@ jobs:
runs-on: ubuntu-latest
if: startsWith(github.event.pull_request.title, '[AI]')
steps:
- - uses: actions-ecosystem/action-add-labels@bd52874380e3909a1ac983768df6976535ece7f8 # v1.1.0
- with:
- labels: AI generated
- github_token: ${{ secrets.GITHUB_TOKEN }}
+ - name: Add 'AI generated' label
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ GH_REPO: ${{ github.repository }}
+ PR_NUMBER: ${{ github.event.pull_request.number }}
+ run: gh pr edit "$PR_NUMBER" --add-label "AI generated"
diff --git a/.github/workflows/docs-spelling.yml b/.github/workflows/docs-spelling.yml
index 2d48f8bce9..1eb7b2b4f3 100644
--- a/.github/workflows/docs-spelling.yml
+++ b/.github/workflows/docs-spelling.yml
@@ -43,7 +43,11 @@ on:
- 'packages/docs/**'
- '.github/workflows/docs-spelling.yml'
- '.github/actions/docs-spelling/**'
- pull_request_target:
+ # Required by the upstream check-spelling action's documented
+ # restricted-permissions pattern. Comment work is split into
+ # separately permissioned jobs (see header) so the spelling job
+ # itself does not write anything PR-controlled.
+ pull_request_target: # zizmor: ignore[dangerous-triggers]
branches:
- '**'
tags-ignore:
diff --git a/.github/workflows/e2e-vrt-comment.yml b/.github/workflows/e2e-vrt-comment.yml
index 1b167eba34..95c32cebcb 100644
--- a/.github/workflows/e2e-vrt-comment.yml
+++ b/.github/workflows/e2e-vrt-comment.yml
@@ -2,7 +2,10 @@ name: VRT Comment
# This workflow posts VRT failure comments on PRs, including fork PRs.
# It runs with elevated permissions via workflow_run trigger.
on:
- workflow_run:
+ # workflow_run is needed to get a token that can comment on fork PRs.
+ # This job only downloads a metadata artifact and posts a comment;
+ # it never checks out or executes PR-supplied code.
+ workflow_run: # zizmor: ignore[dangerous-triggers]
workflows: ['E2E Tests']
types:
- completed
diff --git a/.github/workflows/fork-pr-welcome.yml b/.github/workflows/fork-pr-welcome.yml
index a82431c11f..87999d9750 100644
--- a/.github/workflows/fork-pr-welcome.yml
+++ b/.github/workflows/fork-pr-welcome.yml
@@ -12,7 +12,9 @@ name: Fork PR Welcome
##########################################################################################
on:
- pull_request_target:
+ # See banner above: posts a static welcome comment, no checkout,
+ # no PR-supplied script execution.
+ pull_request_target: # zizmor: ignore[dangerous-triggers]
types: [opened, reopened]
permissions:
diff --git a/.github/workflows/issues-feature-implemented.yml b/.github/workflows/issues-feature-implemented.yml
index 2b73ca6c9f..3e1c2ced23 100644
--- a/.github/workflows/issues-feature-implemented.yml
+++ b/.github/workflows/issues-feature-implemented.yml
@@ -12,7 +12,9 @@ name: Handle completed feature requests
##########################################################################################
on:
- pull_request_target:
+ # See banner above: gated on pull_request.merged == true, runs a
+ # script from the trusted base ref only.
+ pull_request_target: # zizmor: ignore[dangerous-triggers]
types: [closed]
permissions:
diff --git a/.github/workflows/issues-remove-help-wanted.yml b/.github/workflows/issues-remove-help-wanted.yml
index 3945bdd6c0..22174ef5fb 100644
--- a/.github/workflows/issues-remove-help-wanted.yml
+++ b/.github/workflows/issues-remove-help-wanted.yml
@@ -12,6 +12,9 @@ jobs:
if: ${{ !contains(github.event.issue.labels.*.name, 'feature') && contains(github.event.issue.labels.*.name, 'help wanted') }}
runs-on: ubuntu-latest
steps:
- - uses: actions-ecosystem/action-remove-labels@2ce5d41b4b6aa8503e285553f75ed56e0a40bae0 # v1.3.0
- with:
- labels: help wanted
+ - name: Remove 'help wanted' label
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ GH_REPO: ${{ github.repository }}
+ ISSUE_NUMBER: ${{ github.event.issue.number }}
+ run: gh issue edit "$ISSUE_NUMBER" --remove-label "help wanted"
diff --git a/.github/workflows/size-compare.yml b/.github/workflows/size-compare.yml
index 08e056e55b..941fe06766 100644
--- a/.github/workflows/size-compare.yml
+++ b/.github/workflows/size-compare.yml
@@ -12,7 +12,9 @@ name: Compare Sizes
##########################################################################################
on:
- pull_request_target:
+ # See banner above: checks out base ref only; PR-side artifacts are
+ # treated as data (JSON stats) and never executed.
+ pull_request_target: # zizmor: ignore[dangerous-triggers]
paths:
- 'packages/**'
- 'package.json'
diff --git a/.github/workflows/vrt-update-apply.yml b/.github/workflows/vrt-update-apply.yml
index 4afb354b01..aa186965a3 100644
--- a/.github/workflows/vrt-update-apply.yml
+++ b/.github/workflows/vrt-update-apply.yml
@@ -3,7 +3,9 @@ name: VRT Update - Apply
# It treats the patch artifact as untrusted data, validates it contains only PNGs,
# and safely applies it to the contributor's fork branch.
on:
- workflow_run:
+ # Gated on the 'pr-automation' environment (manual approval) and
+ # validates the patch is PNG-only before applying. See SECURITY note above.
+ workflow_run: # zizmor: ignore[dangerous-triggers]
workflows: ['VRT Update - Generate']
types:
- completed
diff --git a/upcoming-release-notes/7975.md b/upcoming-release-notes/7975.md
new file mode 100644
index 0000000000..1f114fc1f5
--- /dev/null
+++ b/upcoming-release-notes/7975.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Address zizmor findings on GitHub Actions workflows.