Skip to content

A local-first personal finance app

Better account sync listing (#2795)

Robert Dyer55ef74eabc8d
diff --git a/packages/desktop-client/src/components/modals/CreateAccountModal.tsx b/packages/desktop-client/src/components/modals/CreateAccountModal.tsx
index df52d965f0..fb229e9f4c 100644
--- a/packages/desktop-client/src/components/modals/CreateAccountModal.tsx
+++ b/packages/desktop-client/src/components/modals/CreateAccountModal.tsx
@@ -71,6 +71,7 @@ export function CreateAccountModal({
name: string;
institution: string;
orgDomain: string;
+ balance: number;
};
for (const oldAccount of results.accounts) {
@@ -79,6 +80,7 @@ export function CreateAccountModal({
name: oldAccount.name,
institution: oldAccount.org.name,
orgDomain: oldAccount.org.domain,
+ balance: oldAccount.balance,
};
newAccounts.push(newAccount);
diff --git a/packages/desktop-client/src/components/modals/SelectLinkedAccounts.jsx b/packages/desktop-client/src/components/modals/SelectLinkedAccounts.jsx
index 8f74791de5..dc959f3dc5 100644
--- a/packages/desktop-client/src/components/modals/SelectLinkedAccounts.jsx
+++ b/packages/desktop-client/src/components/modals/SelectLinkedAccounts.jsx
@@ -7,6 +7,7 @@ import { Button } from '../common/Button';
import { Modal } from '../common/Modal';
import { Text } from '../common/Text';
import { View } from '../common/View';
+import { PrivacyFilter } from '../PrivacyFilter';
import { TableHeader, Table, Row, Field } from '../table';
const addAccountOption = { id: 'new', name: 'Create new account' };
@@ -18,6 +19,7 @@ export function SelectLinkedAccounts({
actions,
syncSource,
}) {
+ externalAccounts.sort((a, b) => a.name.localeCompare(b.name));
const localAccounts = useAccounts().filter(a => a.closed === 0);
const [chosenAccounts, setChosenAccounts] = useState(() => {
return Object.fromEntries(
@@ -108,6 +110,7 @@ export function SelectLinkedAccounts({
<TableHeader
headers={[
{ name: 'Bank Account To Sync', width: 200 },
+ { name: 'Balance', width: 80 },
{ name: 'Account in Actual', width: 'flex' },
{ name: 'Actions', width: 'flex' },
]}
@@ -174,6 +177,9 @@ function TableRow({
return (
<Row style={{ backgroundColor: theme.tableBackground }}>
<Field width={200}>{externalAccount.name}</Field>
+ <Field width={80}>
+ <PrivacyFilter>{externalAccount.balance}</PrivacyFilter>
+ </Field>
<Field
width="flex"
truncate={focusedField !== 'account'}
diff --git a/upcoming-release-notes/2795.md b/upcoming-release-notes/2795.md
new file mode 100644
index 0000000000..a1215bdf87
--- /dev/null
+++ b/upcoming-release-notes/2795.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [psybers]
+---
+
+Sort accounts and show their balance in the bank sync modal.