A local-first personal finance app
:sparkles: (bank-sync) expose demo-bank in the UI for DEV & preview builds (#790)
Matiss Janis Aboltins5a75befc05f1
diff --git a/packages/desktop-client/src/components/manager/ConfigServer.js b/packages/desktop-client/src/components/manager/ConfigServer.jsindex d00f0e5636..30afb69c22 100644--- a/packages/desktop-client/src/components/manager/ConfigServer.js+++ b/packages/desktop-client/src/components/manager/ConfigServer.js@@ -12,10 +12,7 @@ import {} from 'loot-design/src/components/common';import { useSetThemeColor } from 'loot-design/src/components/hooks';import { colors } from 'loot-design/src/style';-import {- isDevelopmentEnvironment,- isPreviewEnvironment,-} from 'loot-design/src/util/environment';+import { isNonProductionEnvironment } from 'loot-design/src/util/environment';import { useServerURL, useSetServerURL } from '../ServerContext';@@ -193,7 +190,7 @@ export default function ConfigServer() {Don't use a server</Button>- {(isDevelopmentEnvironment() || isPreviewEnvironment()) && (+ {isNonProductionEnvironment() && (<Buttonprimarystyle={{ marginLeft: 15 }}diff --git a/packages/desktop-client/src/components/modals/ManageRulesModal.js b/packages/desktop-client/src/components/modals/ManageRulesModal.jsindex 30d544f217..5d10c35570 100644--- a/packages/desktop-client/src/components/modals/ManageRulesModal.js+++ b/packages/desktop-client/src/components/modals/ManageRulesModal.js@@ -2,17 +2,14 @@ import React, { useState } from 'react';import { useLocation } from 'react-router-dom-v5-compat';import { Modal } from 'loot-design/src/components/common';-import {- isDevelopmentEnvironment,- isPreviewEnvironment,-} from 'loot-design/src/util/environment';+import { isNonProductionEnvironment } from 'loot-design/src/util/environment';import ManageRules from '../ManageRules';export default function ManageRulesModal({ modalProps, payeeId }) {let [loading, setLoading] = useState(true);let location = useLocation();- if (isDevelopmentEnvironment() || isPreviewEnvironment()) {+ if (isNonProductionEnvironment()) {if (location.pathname !== '/payees') {throw new Error(`Possibly invalid use of ManageRulesModal, add the current url '${location.pathname}' to the allowlist if you're confident the modal can never appear on top of the '/rules' page.`,diff --git a/packages/desktop-client/src/hooks/useFeatureFlag.js b/packages/desktop-client/src/hooks/useFeatureFlag.jsindex 27920fe189..702de577cc 100644--- a/packages/desktop-client/src/hooks/useFeatureFlag.js+++ b/packages/desktop-client/src/hooks/useFeatureFlag.js@@ -1,12 +1,9 @@import { useSelector } from 'react-redux';-import {- isDevelopmentEnvironment,- isPreviewEnvironment,-} from 'loot-design/src/util/environment';+import { isNonProductionEnvironment } from 'loot-design/src/util/environment';const DEFAULT_FEATURE_FLAG_STATE = {- newAutocomplete: isDevelopmentEnvironment() || isPreviewEnvironment(),+ newAutocomplete: isNonProductionEnvironment(),syncAccount: false,goalTemplatesEnabled: false,};diff --git a/packages/loot-core/src/server/main.js b/packages/loot-core/src/server/main.jsindex 38f87ab22d..d81348c105 100644--- a/packages/loot-core/src/server/main.js+++ b/packages/loot-core/src/server/main.js@@ -1,6 +1,8 @@import './polyfills';import injectAPI from '@actual-app/api/injected';+import { isNonProductionEnvironment } from 'loot-design/src/util/environment';+import { createTestBudget } from '../mocks/budget';import { captureException, captureBreadcrumb } from '../platform/exceptions';import asyncStorage from '../platform/server/asyncStorage';@@ -1265,7 +1267,7 @@ handlers['nordigen-get-banks'] = async function (country) {return post(getServer().NORDIGEN_SERVER + '/get-banks',- { country },+ { country, showDemo: isNonProductionEnvironment() },{'X-ACTUAL-TOKEN': userToken,},diff --git a/packages/loot-design/src/components/manager/BudgetList.js b/packages/loot-design/src/components/manager/BudgetList.jsindex 5688dd5aac..bf9b6bd526 100644--- a/packages/loot-design/src/components/manager/BudgetList.js+++ b/packages/loot-design/src/components/manager/BudgetList.js@@ -13,10 +13,7 @@ import DotsHorizontalTriple from '../../svg/v1/DotsHorizontalTriple';import FileDouble from '../../svg/v1/FileDouble';import CloudUnknown from '../../svg/v2/CloudUnknown';import tokens from '../../tokens';-import {- isDevelopmentEnvironment,- isPreviewEnvironment,-} from '../../util/environment';+import { isNonProductionEnvironment } from '../../util/environment';import { View, Text, Button, Tooltip, Menu } from '../common';function getFileDescription(file) {@@ -331,7 +328,7 @@ function BudgetList({Create new file</Button>- {(isDevelopmentEnvironment() || isPreviewEnvironment()) && (+ {isNonProductionEnvironment() && (<ButtonprimaryonClick={() => onCreate({ testMode: true })}diff --git a/packages/loot-design/src/util/environment.js b/packages/loot-design/src/util/environment.jsindex 151942d90a..42fa7be752 100644--- a/packages/loot-design/src/util/environment.js+++ b/packages/loot-design/src/util/environment.js@@ -5,3 +5,7 @@ export function isPreviewEnvironment() {export function isDevelopmentEnvironment() {return process.env.NODE_ENV === 'development';}++export function isNonProductionEnvironment() {+ return isPreviewEnvironment() || isDevelopmentEnvironment();+}diff --git a/upcoming-release-notes/790.md b/upcoming-release-notes/790.mdnew file mode 100644index 0000000000..8e12cdbd9a--- /dev/null+++ b/upcoming-release-notes/790.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Expose demo bank for easy bank-sync testing in dev and preview builds