Skip to content

A local-first personal finance app

fix: Save Account Notes (#5326)

passabilities.eth5db7026435fd
diff --git a/packages/desktop-client/src/components/NotesButton.tsx b/packages/desktop-client/src/components/NotesButton.tsx
index e1e409fb4d..d42753d839 100644
--- a/packages/desktop-client/src/components/NotesButton.tsx
+++ b/packages/desktop-client/src/components/NotesButton.tsx
@@ -4,6 +4,7 @@ import React, {
useState,
type ComponentProps,
type CSSProperties,
+ useCallback,
} from 'react';
import { useTranslation } from 'react-i18next';
@@ -43,12 +44,21 @@ export function NotesButton({
const hasNotes = note && note !== '';
const [tempNotes, setTempNotes] = useState<string>(note);
- useEffect(() => setTempNotes(note), [note]);
+ useEffect(() => setTempNotes(note), [note, id]);
- function onClose() {
- send('notes-save', { id, note: tempNotes });
- setIsOpen(false);
- }
+ const onOpenChange = useCallback<
+ NonNullable<ComponentProps<typeof Popover>['onOpenChange']>
+ >(
+ isOpen => {
+ if (!isOpen) {
+ if (tempNotes !== note) {
+ void send('notes-save', { id, note: tempNotes });
+ }
+ setIsOpen(false);
+ }
+ },
+ [id, note, tempNotes],
+ );
return (
<Tooltip
@@ -81,7 +91,7 @@ export function NotesButton({
<Popover
triggerRef={triggerRef}
isOpen={isOpen}
- onOpenChange={onClose}
+ onOpenChange={onOpenChange}
placement={tooltipPosition}
style={{ padding: 4 }}
>
diff --git a/upcoming-release-notes/5326.md b/upcoming-release-notes/5326.md
new file mode 100644
index 0000000000..7045eebdd6
--- /dev/null
+++ b/upcoming-release-notes/5326.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [passabilities]
+---
+
+fixes saving correct account notes when opening another account