Skip to content

A local-first personal finance app

[AI] Use noble Playwright image for the desktop VRT job to compile against Electron 43 headers (#8770)

Michael Clark625e18e20bb1
diff --git a/.github/workflows/vrt-update-generate.yml b/.github/workflows/vrt-update-generate.yml
index b9d20489a7..0ebd22adf7 100644
--- a/.github/workflows/vrt-update-generate.yml
+++ b/.github/workflows/vrt-update-generate.yml
@@ -170,7 +170,9 @@ jobs:
runs-on: depot-ubuntu-latest
needs: get-pr
container:
- image: mcr.microsoft.com/playwright:v1.61.1-jammy
+ # noble (gcc 13) is required to compile native modules against Electron 43+ headers;
+ # jammy's gcc 11/12 cannot parse them. Keep in sync with the functional-desktop-app job in e2e-test.yml.
+ image: mcr.microsoft.com/playwright:v1.61.1-noble
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
diff --git a/upcoming-release-notes/fix-desktop-vrt-container.md b/upcoming-release-notes/fix-desktop-vrt-container.md
new file mode 100644
index 0000000000..3bbb1e6f34
--- /dev/null
+++ b/upcoming-release-notes/fix-desktop-vrt-container.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MikesGlitch]
+---
+
+Fix the desktop VRT update workflow failing to build native modules against Electron 43