Skip to content

A local-first personal finance app

Make file size uploads configurable via env vars (#245)

James Hackett6512c465f01b
diff --git a/docker-compose.yml b/docker-compose.yml
index 9659d01925..2a6851fd15 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -10,6 +10,9 @@ services:
# Uncomment any of the lines below to set configuration options.
# - ACTUAL_HTTPS_KEY=/data/selfhost.key
# - ACTUAL_HTTPS_CERT=/data/selfhost.crt
+ # - ACTUAL_UPLOAD_FILE_SYNC_SIZE_LIMIT_MB=20
+ # - ACTUAL_UPLOAD_SYNC_ENCRYPTED_FILE_SYNC_SIZE_LIMIT_MB=50
+ # - ACTUAL_UPLOAD_FILE_SIZE_LIMIT_MB=20
# See all options and more details at https://actualbudget.github.io/docs/Installing/Configuration
# !! If you are not using any of these options, remove the 'environment:' tag entirely.
volumes:
diff --git a/src/app.js b/src/app.js
index d9bbecfc3a..6d588d2388 100644
--- a/src/app.js
+++ b/src/app.js
@@ -27,9 +27,19 @@ app.use(
standardHeaders: true,
}),
);
-app.use(bodyParser.json({ limit: '20mb' }));
-app.use(bodyParser.raw({ type: 'application/actual-sync', limit: '20mb' }));
-app.use(bodyParser.raw({ type: 'application/encrypted-file', limit: '50mb' }));
+app.use(bodyParser.json({ limit: `${config.upload.fileSizeLimitMB}mb` }));
+app.use(
+ bodyParser.raw({
+ type: 'application/actual-sync',
+ limit: `${config.upload.fileSizeSyncLimitMB}mb`,
+ }),
+);
+app.use(
+ bodyParser.raw({
+ type: 'application/encrypted-file',
+ limit: `${config.upload.syncEncryptedFileSizeLimitMB}mb`,
+ }),
+);
app.use('/sync', syncApp.handlers);
app.use('/account', accountApp.handlers);
diff --git a/src/config-types.ts b/src/config-types.ts
index 58268662c6..fc59333d4c 100644
--- a/src/config-types.ts
+++ b/src/config-types.ts
@@ -11,4 +11,9 @@ export interface Config {
key: string;
cert: string;
} & ServerOptions;
+ upload?: {
+ fileSizeSyncLimitMB: number;
+ syncEncryptedFileSizeLimitMB: number;
+ fileSizeLimitMB: number;
+ };
}
diff --git a/src/load-config.js b/src/load-config.js
index 947c8c86d3..a4714d1eda 100644
--- a/src/load-config.js
+++ b/src/load-config.js
@@ -55,6 +55,11 @@ let defaultConfig = {
'web',
'build',
),
+ upload: {
+ fileSizeSyncLimitMB: 20,
+ syncEncryptedFileSizeLimitMB: 50,
+ fileSizeLimitMB: 20,
+ },
};
/** @type {import('./config-types.js').Config} */
@@ -91,6 +96,24 @@ const finalConfig = {
...(config.https || {}),
}
: config.https,
+ upload:
+ process.env.ACTUAL_UPLOAD_FILE_SYNC_SIZE_LIMIT_MB ||
+ process.env.ACTUAL_UPLOAD_SYNC_ENCRYPTED_FILE_SYNC_SIZE_LIMIT_MB ||
+ process.env.ACTUAL_UPLOAD_FILE_SIZE_LIMIT_MB
+ ? {
+ fileSizeSyncLimitMB:
+ +process.env.ACTUAL_UPLOAD_FILE_SYNC_SIZE_LIMIT_MB ||
+ +process.env.ACTUAL_UPLOAD_FILE_SIZE_LIMIT_MB ||
+ config.upload.fileSizeSyncLimitMB,
+ syncEncryptedFileSizeLimitMB:
+ +process.env.ACTUAL_UPLOAD_SYNC_ENCRYPTED_FILE_SYNC_SIZE_LIMIT_MB ||
+ +process.env.ACTUAL_UPLOAD_FILE_SIZE_LIMIT_MB ||
+ config.upload.syncEncryptedFileSizeLimitMB,
+ fileSizeLimitMB:
+ +process.env.ACTUAL_UPLOAD_FILE_SIZE_LIMIT_MB ||
+ config.upload.fileSizeLimitMB,
+ }
+ : config.upload,
};
debug(`using port ${finalConfig.port}`);
@@ -106,4 +129,12 @@ if (finalConfig.https) {
debugSensitive(`using https cert ${finalConfig.https.cert}`);
}
+if (finalConfig.upload) {
+ debug(`using file sync limit ${finalConfig.upload.fileSizeSyncLimitMB}mb`);
+ debug(
+ `using sync encrypted file limit ${finalConfig.upload.syncEncryptedFileSizeLimitMB}mb`,
+ );
+ debug(`using file limit ${finalConfig.upload.fileSizeLimitMB}mb`);
+}
+
export default finalConfig;
diff --git a/upcoming-release-notes/245.md b/upcoming-release-notes/245.md
new file mode 100644
index 0000000000..396cea9481
--- /dev/null
+++ b/upcoming-release-notes/245.md
@@ -0,0 +1,7 @@
+---
+category: Features
+authors:
+ - DistroByte
+---
+
+Make upload limits configurable via env vars to allow for larger files to be uploaded.