A local-first personal finance app
:wrench: (eslint) disallow using 'var': no-var rule (#1949)
Matiss Janis Aboltins6ed1b58321ca
diff --git a/.eslintrc.js b/.eslintrc.jsindex e0655c27d2..c8785c13f6 100644--- a/.eslintrc.js+++ b/.eslintrc.js@@ -92,6 +92,8 @@ module.exports = {// },// ],+ 'no-var': 'warn',+'import/extensions': ['warn','never',diff --git a/packages/desktop-client/src/browser-preload.browser.js b/packages/desktop-client/src/browser-preload.browser.jsindex 6d5b7dd7c3..5a6f6850f8 100644--- a/packages/desktop-client/src/browser-preload.browser.js+++ b/packages/desktop-client/src/browser-preload.browser.js@@ -82,7 +82,7 @@ global.Actual = {let filename = file.name.replace(/.*(\.[^.]*)/, 'file$1');if (file) {- var reader = new FileReader();+ let reader = new FileReader();reader.readAsArrayBuffer(file);reader.onload = async function (ev) {let filepath = `/uploads/${filename}`;diff --git a/packages/desktop-electron/afterSignHook.js b/packages/desktop-electron/afterSignHook.jsindex 91815db199..1eb1f69427 100644--- a/packages/desktop-electron/afterSignHook.js+++ b/packages/desktop-electron/afterSignHook.js@@ -1,7 +1,7 @@const fs = require('fs');const path = require('path');-var electron_notarize = require('electron-notarize');+let electron_notarize = require('electron-notarize');// This is expected to be run by `electron-builder` after it signs the build.// It's disabled for now as we currently don't sign builds after Actual being open sourced.diff --git a/packages/desktop-electron/security.js b/packages/desktop-electron/security.jsindex 08ef6933db..b7235567e6 100644--- a/packages/desktop-electron/security.js+++ b/packages/desktop-electron/security.js@@ -30,7 +30,7 @@ electron.app.on('ready', function () {permission,callback,) {- var url = webContents.getURL();+ let url = webContents.getURL();if (url.startsWith('file://')) {callback(true);} else {diff --git a/packages/node-libofx/index.js b/packages/node-libofx/index.jsindex d6beb54667..50b2a203e7 100644--- a/packages/node-libofx/index.js+++ b/packages/node-libofx/index.js@@ -5,7 +5,7 @@ let _libofxPromise;let _libofx;let ffi;-var parser = {+let parser = {ctx: null,transactions: [],diff --git a/upcoming-release-notes/1949.md b/upcoming-release-notes/1949.mdnew file mode 100644index 0000000000..cfb20fbb2e--- /dev/null+++ b/upcoming-release-notes/1949.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++eslint: disallow using 'var': no-var rule