Skip to content

A local-first personal finance app

fix: add scoped ErrorBoundaries to mobile schedules, payees, and bank sync pages (#8547)

BasilTh71d802e91f5d
diff --git a/packages/desktop-client/src/components/FinancesApp.tsx b/packages/desktop-client/src/components/FinancesApp.tsx
index 7d4817be15..84176384a3 100644
--- a/packages/desktop-client/src/components/FinancesApp.tsx
+++ b/packages/desktop-client/src/components/FinancesApp.tsx
@@ -277,27 +277,51 @@ export function FinancesApp() {
<Route
path="/schedules"
- element={<NarrowAlternate name="Schedules" />}
+ element={
+ <ErrorBoundary
+ FallbackComponent={FeatureErrorFallback}
+ resetKeys={[location.pathname]}
+ >
+ <NarrowAlternate name="Schedules" />
+ </ErrorBoundary>
+ }
/>
<Route
path="/schedules/:id"
element={
- <WideNotSupported>
- <NarrowAlternate name="ScheduleEdit" />
- </WideNotSupported>
+ <ErrorBoundary
+ FallbackComponent={FeatureErrorFallback}
+ resetKeys={[location.pathname]}
+ >
+ <WideNotSupported>
+ <NarrowAlternate name="ScheduleEdit" />
+ </WideNotSupported>
+ </ErrorBoundary>
}
/>
<Route
path="/payees"
- element={<NarrowAlternate name="Payees" />}
+ element={
+ <ErrorBoundary
+ FallbackComponent={FeatureErrorFallback}
+ resetKeys={[location.pathname]}
+ >
+ <NarrowAlternate name="Payees" />
+ </ErrorBoundary>
+ }
/>
<Route
path="/payees/:id"
element={
- <WideNotSupported>
- <NarrowAlternate name="PayeeEdit" />
- </WideNotSupported>
+ <ErrorBoundary
+ FallbackComponent={FeatureErrorFallback}
+ resetKeys={[location.pathname]}
+ >
+ <WideNotSupported>
+ <NarrowAlternate name="PayeeEdit" />
+ </WideNotSupported>
+ </ErrorBoundary>
}
/>
<Route
@@ -324,14 +348,26 @@ export function FinancesApp() {
/>
<Route
path="/bank-sync"
- element={<NarrowAlternate name="BankSync" />}
+ element={
+ <ErrorBoundary
+ FallbackComponent={FeatureErrorFallback}
+ resetKeys={[location.pathname]}
+ >
+ <NarrowAlternate name="BankSync" />
+ </ErrorBoundary>
+ }
/>
<Route
path="/bank-sync/account/:accountId/edit"
element={
- <WideNotSupported redirectTo="/bank-sync">
- <MobileBankSyncAccountEditPage />
- </WideNotSupported>
+ <ErrorBoundary
+ FallbackComponent={FeatureErrorFallback}
+ resetKeys={[location.pathname]}
+ >
+ <WideNotSupported redirectTo="/bank-sync">
+ <MobileBankSyncAccountEditPage />
+ </WideNotSupported>
+ </ErrorBoundary>
}
/>
<Route path="/tags" element={<ManageTagsPage />} />
diff --git a/upcoming-release-notes/mobile-error-boundaries-schedules-payees-banksync.md b/upcoming-release-notes/mobile-error-boundaries-schedules-payees-banksync.md
new file mode 100644
index 0000000000..06bc99470f
--- /dev/null
+++ b/upcoming-release-notes/mobile-error-boundaries-schedules-payees-banksync.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [BasilTh]
+---
+
+Wrap the mobile schedules, payees, and bank sync pages in scoped error boundaries, so a rendering error in one of these sections shows a recoverable fallback instead of crashing the whole app.