Skip to content

A local-first personal finance app

fix ToBudget actions not showing in firefox (#8958)

Terry Lockett71e133ef7dc4
diff --git a/packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudget.tsx b/packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudget.tsx
index 95c51e14f3..d5f9b3d455 100644
--- a/packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudget.tsx
+++ b/packages/desktop-client/src/components/budget/envelope/budgetsummary/ToBudget.tsx
@@ -67,6 +67,11 @@ export function ToBudget({
setMenuOpen(true);
};
+ const closeMenu = () => {
+ setMenuStep('actions');
+ setMenuOpen(false);
+ };
+
return (
<>
<View ref={triggerRef}>
@@ -87,10 +92,7 @@ export function ToBudget({
triggerRef={triggerRef}
placement="bottom"
isOpen={menuOpen}
- onOpenChange={() => {
- setMenuStep('actions');
- setMenuOpen(false);
- }}
+ onOpenChange={closeMenu}
style={{ width: 200, margin: 1 }}
isNonModal
{...position}
@@ -111,7 +113,7 @@ export function ToBudget({
)}
{menuStep === 'buffer' && (
<HoldMenu
- onClose={() => setMenuOpen(false)}
+ onClose={closeMenu}
onSubmit={amount => {
onBudgetAction(month, 'hold', { amount });
}}
@@ -120,7 +122,7 @@ export function ToBudget({
{menuStep === 'transfer' && (
<TransferMenu
initialAmount={availableValue}
- onClose={() => setMenuOpen(false)}
+ onClose={closeMenu}
onSubmit={(amount, categoryId) => {
onBudgetAction(month, 'transfer-available', {
amount,
@@ -133,7 +135,7 @@ export function ToBudget({
<CoverMenu
showToBeBudgeted={false}
initialAmount={availableValue}
- onClose={() => setMenuOpen(false)}
+ onClose={closeMenu}
onSubmit={(amount, categoryId) => {
onBudgetAction(month, 'cover-overbudgeted', {
category: categoryId,
diff --git a/upcoming-release-notes/4985.md b/upcoming-release-notes/4985.md
new file mode 100644
index 0000000000..819a859b8c
--- /dev/null
+++ b/upcoming-release-notes/4985.md
@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [terrylockett]
+---
+
+Fix issue where `To Budget` actions list does not show in Firefox after using one of `Hold for next month`, `Move to a category`, or `Cover from a category`.