Skip to content

A local-first personal finance app

increase timeout for SimpleFIN batch sync and add debug logging (#4515)

Matt Fiddaman7650eed64401
diff --git a/packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx b/packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx
index 4d3b07b3fc..06437f9ec2 100644
--- a/packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx
+++ b/packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx
@@ -46,6 +46,9 @@ function useErrorMessage() {
case 'RATE_LIMIT_EXCEEDED':
return t('Rate limit exceeded for this item. Please try again later.');
+ case 'TIMED_OUT':
+ return t('The request timed out. Please try again later.');
+
case 'INVALID_ACCESS_TOKEN':
return t(
'Your SimpleFIN Access Token is no longer valid. Please reset and generate a new token.',
diff --git a/packages/loot-core/src/server/accounts/app.ts b/packages/loot-core/src/server/accounts/app.ts
index bcc690c65b..b20c002b4d 100644
--- a/packages/loot-core/src/server/accounts/app.ts
+++ b/packages/loot-core/src/server/accounts/app.ts
@@ -696,13 +696,17 @@ function handleSyncError(
err: Error | PostError | BankSyncError,
acct: db.DbAccount,
): SyncError {
- if (err instanceof BankSyncError) {
+ // TODO: refactor bank sync logic to use BankSyncError properly
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ if (err instanceof BankSyncError || (err as any)?.type === 'BankSyncError') {
+ const error = err as BankSyncError;
+
return {
type: 'SyncError',
accountId: acct.id,
message: 'Failed syncing account “' + acct.name + '.”',
- category: err.category,
- code: err.code,
+ category: error.category,
+ code: error.code,
};
}
diff --git a/packages/loot-core/src/server/accounts/sync.ts b/packages/loot-core/src/server/accounts/sync.ts
index 133292e0c8..33e7b87ba2 100644
--- a/packages/loot-core/src/server/accounts/sync.ts
+++ b/packages/loot-core/src/server/accounts/sync.ts
@@ -197,17 +197,24 @@ async function downloadSimpleFinTransactions(
console.log('Pulling transactions from SimpleFin');
- const res = await post(
- getServer().SIMPLEFIN_SERVER + '/transactions',
- {
- accountId: acctId,
- startDate: since,
- },
- {
- 'X-ACTUAL-TOKEN': userToken,
- },
- 60000,
- );
+ let res;
+ try {
+ res = await post(
+ getServer().SIMPLEFIN_SERVER + '/transactions',
+ {
+ accountId: acctId,
+ startDate: since,
+ },
+ {
+ 'X-ACTUAL-TOKEN': userToken,
+ },
+ // 5 minute timeout for batch sync, one minute for individual accounts
+ Array.isArray(acctId) ? 300000 : 60000,
+ );
+ } catch (error) {
+ console.error('Suspected timeout during bank sync:', error);
+ throw BankSyncError('TIMED_OUT', 'TIMED_OUT');
+ }
if (Object.keys(res).length === 0) {
throw BankSyncError('NO_DATA', 'NO_DATA');
diff --git a/upcoming-release-notes/4515.md b/upcoming-release-notes/4515.md
new file mode 100644
index 0000000000..ad412bc3ce
--- /dev/null
+++ b/upcoming-release-notes/4515.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [matt-fidd]
+---
+
+Increase timeout for SimpleFIN batch sync and add debug logging