Skip to content

A local-first personal finance app

[AI] Clarify that E2E encryption does not cover bank sync tokens (#7392)

Matiss Janis Aboltins78739b926bd9
diff --git a/packages/desktop-client/src/components/settings/Encryption.tsx b/packages/desktop-client/src/components/settings/Encryption.tsx
index 1cf5320b57..c649a155c8 100644
--- a/packages/desktop-client/src/components/settings/Encryption.tsx
+++ b/packages/desktop-client/src/components/settings/Encryption.tsx
@@ -41,9 +41,11 @@ export function EncryptionSettings() {
<Trans>End-to-end Encryption is turned on.</Trans>
</Text>{' '}
<Trans>
- Your data is encrypted with a key that only you have before sending it
- it out to the cloud. Local data remains unencrypted so if you forget
- your password you can re-encrypt it.
+ Your budget data is encrypted with a key that only you have before
+ sending it out to the cloud. Local data remains unencrypted so if you
+ forget your password you can re-encrypt it. Note: bank sync operations
+ and secrets stored on the server are not covered by end-to-end
+ encryption.
</Trans>{' '}
<Link
variant="external"
diff --git a/packages/docs/docs/advanced/bank-sync.md b/packages/docs/docs/advanced/bank-sync.md
index cae99722d0..afce8718be 100644
--- a/packages/docs/docs/advanced/bank-sync.md
+++ b/packages/docs/docs/advanced/bank-sync.md
@@ -7,7 +7,7 @@ Here are a couple of considerations to know about before making the decision to
- The integration only works if you are using actual-server.
-- The Secrets and Keys are stored in your Actual installed version so it is highly recommended to turn on End to End encryption and create a strong passphrase to encrypt your files.
+- The API secrets and keys for bank sync are stored on the server and are **not** covered by [end-to-end encryption](/docs/getting-started/sync/#end-to-end-encryption). End-to-end encryption only protects your budget data. Server administrators or hosting providers with direct access to the server's database can read bank sync tokens. If this is a concern, consider self-hosting your server.
- You will need to add a config file to your installation.
diff --git a/packages/docs/docs/getting-started/sync.md b/packages/docs/docs/getting-started/sync.md
index 47cdb64943..7a1117f876 100644
--- a/packages/docs/docs/getting-started/sync.md
+++ b/packages/docs/docs/getting-started/sync.md
@@ -18,15 +18,19 @@ If you have already created files, after logging in Actual will show you all the
In addition to the requirement to enter your password before the Actual server will allow you to access your budget, you can optionally enable end-to-end encryption. This will require you to enter a second password to access the budget, and that the server will no longer be able to access your budget information. On the one hand, this improves security if you're worried that someone else will have access to the server's file or if you don't trust the server to check the password correctly (that said, we have done our best to make the server secure). On the other hand, you **will not be able to recover your data if you forget your encryption password**. If you forget the encryption password and you still have a copy of your data locally, you can reset your key which will do a [sync reset](#what-does-resetting-sync-mean) and generate a new key.
-End-to-end encryption offers the ability for you to generate a key based on a password and encrypt it so that hosted services can't read the data. Before your data leaves your device, it is encrypted using keys only you have.
+End-to-end encryption offers the ability for you to generate a key based on a password and encrypt it so that hosted services can't read your budget data. Before your data leaves your device, it is encrypted using keys only you have.
-This guarantees that only you will ever have access to your data. This is optional and using it requires you to enter a password whenever downloading [cloud files](#this-file-is-not-a-cloud-file) (this only needs to be done once per device). The password you enter should be different from the main server password.
+This guarantees that only you will ever have access to your budget data. This is optional and using it requires you to enter a password whenever downloading [cloud files](#this-file-is-not-a-cloud-file) (this only needs to be done once per device). The password you enter should be different from the main server password.
+
+:::note
+End-to-end encryption applies only to your budget data. If you use [bank sync](/docs/advanced/bank-sync), the bank sync tokens (e.g. SimpleFIN, GoCardless, or Pluggy credentials) are stored separately on the server and are **not** covered by end-to-end encryption. Server administrators or hosting providers with direct access to the server's database can read these tokens. If this is a concern, consider self-hosting your server.
+:::
Data on your local device is still unencrypted. We recommend full disk encryption if you are interested in local encryption.
There are some things to consider with end-to-end encryption:
-- **Pro:** Your data is fully secure and nobody except you can read it
+- **Pro:** Your budget data is fully secure and nobody except you can read it
- **Pro:** If you don't want to sync across devices, this still allows you keep a fully encrypted backup of your data
- **Pro:** If you want to share the server with someone else, you can use different passwords to encrypt separate budget files, and you won't be able to access each other's budgets.
- **Con:** If you lose your local data copy and forget your password, you can never recover your data
diff --git a/packages/docs/docs/settings/index.md b/packages/docs/docs/settings/index.md
index 51ed43786f..401e617126 100644
--- a/packages/docs/docs/settings/index.md
+++ b/packages/docs/docs/settings/index.md
@@ -37,7 +37,7 @@ OpenID can be enabled here. [Learn more](/docs/config/oauth-auth)
### Encryption
-End-to-end encryption allows you to encrypt the data on your remote server with a password. If you don't trust the server's owners, enable this setting to fully encrypt the data. [Learn more](/docs/getting-started/sync/#end-to-end-encryption)
+End-to-end encryption allows you to encrypt your budget data on the remote server with a password. If you don't trust the server's owners, enable this setting to encrypt your budget data. Note that [bank sync](/docs/advanced/bank-sync) tokens are stored separately on the server and are not covered by this encryption. [Learn more](/docs/getting-started/sync/#end-to-end-encryption)
![Image of Encryption setting](/img/using-actual/settings-encryption.webp)
diff --git a/upcoming-release-notes/7392.md b/upcoming-release-notes/7392.md
new file mode 100644
index 0000000000..451d028abb
--- /dev/null
+++ b/upcoming-release-notes/7392.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [MatissJanis]
+---
+
+Clarify that end-to-end encryption only protects budget data, excluding bank sync tokens.