A local-first personal finance app
🐛 Fix: Error rate limit at user directory page (#4397)
lelemm7a252d06948f
diff --git a/packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx b/packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsxindex 6fa61cd2b5..db659eada2 100644--- a/packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx+++ b/packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx@@ -41,37 +41,40 @@ type ManageUserDirectoryContentProps = {function useGetUserDirectoryErrors() {const { t } = useTranslation();- function getUserDirectoryErrors(reason) {- switch (reason) {- case 'unauthorized':- return t('You are not logged in.');- case 'token-expired':- return t('Login expired, please log in again.');- case 'user-cant-be-empty':- return t(- 'Please enter a value for the username; the field cannot be empty.',- );- case 'role-cant-be-empty':- return t('Select a role; the field cannot be empty.');- case 'user-already-exists':- return t(- 'The username you entered already exists. Please choose a different username.',- );- case 'not-all-deleted':- return t(- 'Not all users were deleted. Check if one of the selected users is the server owner.',- );- case 'role-does-not-exists':- return t(- 'Selected role does not exists, possibly a bug? Visit https://actualbudget.org/contact/ for support.',- );- default:- return t(- 'An internal error occurred, sorry! Visit https://actualbudget.org/contact/ for support. (ref: {{reason}})',- { reason },- );- }- }+ const getUserDirectoryErrors = useCallback(+ reason => {+ switch (reason) {+ case 'unauthorized':+ return t('You are not logged in.');+ case 'token-expired':+ return t('Login expired, please log in again.');+ case 'user-cant-be-empty':+ return t(+ 'Please enter a value for the username; the field cannot be empty.',+ );+ case 'role-cant-be-empty':+ return t('Select a role; the field cannot be empty.');+ case 'user-already-exists':+ return t(+ 'The username you entered already exists. Please choose a different username.',+ );+ case 'not-all-deleted':+ return t(+ 'Not all users were deleted. Check if one of the selected users is the server owner.',+ );+ case 'role-does-not-exists':+ return t(+ 'Selected role does not exist, possibly a bug? Visit https://actualbudget.org/contact/ for support.',+ );+ default:+ return t(+ 'An internal error occurred, sorry! Visit https://actualbudget.org/contact/ for support. (ref: {{reason}})',+ { reason },+ );+ }+ },+ [t],+ );return { getUserDirectoryErrors };}diff --git a/upcoming-release-notes/4397.md b/upcoming-release-notes/4397.mdnew file mode 100644index 0000000000..15200dde8b--- /dev/null+++ b/upcoming-release-notes/4397.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [lelemm]+---++Fix for User directory page that was calling the api every frame