A local-first personal finance app
Handle detailedAccount null or undefined in gocardless service. Fixes #5664 (#5706)
Mauro Artizzu7a420b79f28b
diff --git a/packages/sync-server/src/app-gocardless/services/gocardless-service.js b/packages/sync-server/src/app-gocardless/services/gocardless-service.jsindex 65fc2c9266..fdb778635c 100644--- a/packages/sync-server/src/app-gocardless/services/gocardless-service.js+++ b/packages/sync-server/src/app-gocardless/services/gocardless-service.js@@ -426,16 +426,21 @@ export const goCardlessService = {handleGoCardlessError(error);}+ // Handle cases where either response is null/undefined+ const accountDetails = detailedAccount?.account || {};+ const metadata = metadataAccount || {};+// Some banks provide additional data in both fields, but can do yucky things like have an empty// string in one place but not the other. We'll fix this by merging the two objects, but preferring truthy values// from the metadata object over the details object.const mergedAccount = {};const uniqueKeys = new Set([- ...Object.keys(detailedAccount.account),- ...Object.keys(metadataAccount),+ ...Object.keys(accountDetails),+ ...Object.keys(metadata),]);+for (const key of uniqueKeys) {- mergedAccount[key] = metadataAccount[key] || detailedAccount.account[key];+ mergedAccount[key] = metadata[key] || accountDetails[key];}return mergedAccount;diff --git a/upcoming-release-notes/5706.md b/upcoming-release-notes/5706.mdnew file mode 100644index 0000000000..24db9a4263--- /dev/null+++ b/upcoming-release-notes/5706.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [mauroartizzu]+---++Fixes detailedAccounts that might me null or undefined with some Italian Banks (Widiba, Poste, Intesa)