A local-first personal finance app
:recycle: (eslint) enable 'react/no-children-prop' rule and fix issues (#2029)
Matiss Janis Aboltins7a45d467b750
diff --git a/.eslintrc.js b/.eslintrc.jsindex b2d03eb5b4..d0eadff98c 100644--- a/.eslintrc.js+++ b/.eslintrc.js@@ -82,7 +82,6 @@ module.exports = {// TODO: re-enable these rules'react-hooks/exhaustive-deps': 'off',- 'react/no-children-prop': 'off','react/display-name': 'off','react/react-in-jsx-scope': 'off',// 'react-hooks/exhaustive-deps': [diff --git a/packages/desktop-client/src/components/NotesButton.tsx b/packages/desktop-client/src/components/NotesButton.tsxindex 59ab111225..3c65b4a1f8 100644--- a/packages/desktop-client/src/components/NotesButton.tsx+++ b/packages/desktop-client/src/components/NotesButton.tsx@@ -124,11 +124,9 @@ function NotesTooltip({/>) : (<Text {...markdownStyles}>- <ReactMarkdown- remarkPlugins={remarkPlugins}- linkTarget="_blank"- children={notes}- />+ <ReactMarkdown remarkPlugins={remarkPlugins} linkTarget="_blank">+ {notes}+ </ReactMarkdown></Text>)}</Tooltip>diff --git a/packages/desktop-client/src/components/ScrollProvider.tsx b/packages/desktop-client/src/components/ScrollProvider.tsxindex 45c39e0ac8..b959fbc40b 100644--- a/packages/desktop-client/src/components/ScrollProvider.tsx+++ b/packages/desktop-client/src/components/ScrollProvider.tsx@@ -42,10 +42,9 @@ export default function ScrollProvider({ children }: ScrollProviderProps) {}, []);return (- <ScrollContext.Provider- value={{ scrollY, isBottomReached }}- children={children}- />+ <ScrollContext.Provider value={{ scrollY, isBottomReached }}>+ {children}+ </ScrollContext.Provider>);}diff --git a/packages/desktop-client/src/components/Titlebar.tsx b/packages/desktop-client/src/components/Titlebar.tsxindex aa55d08005..5c50871ec2 100644--- a/packages/desktop-client/src/components/Titlebar.tsx+++ b/packages/desktop-client/src/components/Titlebar.tsx@@ -78,10 +78,9 @@ export function TitlebarProvider({ children }: TitlebarProviderProps) {}return (- <TitlebarContext.Provider- value={{ sendEvent, subscribe }}- children={children}- />+ <TitlebarContext.Provider value={{ sendEvent, subscribe }}>+ {children}+ </TitlebarContext.Provider>);}diff --git a/packages/desktop-client/src/components/budget/report/ReportContext.tsx b/packages/desktop-client/src/components/budget/report/ReportContext.tsxindex fc9927882e..3f746cfd5b 100644--- a/packages/desktop-client/src/components/budget/report/ReportContext.tsx+++ b/packages/desktop-client/src/components/budget/report/ReportContext.tsx@@ -26,8 +26,9 @@ export function ReportProvider({onBudgetAction,onToggleSummaryCollapse,}}- children={children}- />+ >+ {children}+ </Context.Provider>);}diff --git a/packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx b/packages/desktop-client/src/components/budget/rollover/RolloverContext.tsxindex 706999c7cb..7006ae78ee 100644--- a/packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx+++ b/packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx@@ -29,8 +29,9 @@ export function RolloverContext({onBudgetAction,onToggleSummaryCollapse,}}- children={children}- />+ >+ {children}+ </Context.Provider>);}diff --git a/packages/desktop-client/src/hooks/useSelected.tsx b/packages/desktop-client/src/hooks/useSelected.tsxindex 21455ab4ec..934318e366 100644--- a/packages/desktop-client/src/hooks/useSelected.tsx+++ b/packages/desktop-client/src/hooks/useSelected.tsx@@ -340,10 +340,8 @@ export function SelectedProviderWithItems<T extends Item>({}, [registerDispatch]);return (- <SelectedProvider<T>- instance={selected}- fetchAllIds={fetchAllIds}- children={children}- />+ <SelectedProvider<T> instance={selected} fetchAllIds={fetchAllIds}>+ {children}+ </SelectedProvider>);}diff --git a/packages/loot-core/src/client/data-hooks/accounts.tsx b/packages/loot-core/src/client/data-hooks/accounts.tsxindex 084060f3b8..7bcde4b7bf 100644--- a/packages/loot-core/src/client/data-hooks/accounts.tsx+++ b/packages/loot-core/src/client/data-hooks/accounts.tsx@@ -13,7 +13,9 @@ const AccountsContext = createContext<AccountEntity[]>(null);export function AccountsProvider({ children }) {const data = useAccounts();- return <AccountsContext.Provider value={data} children={children} />;+ return (+ <AccountsContext.Provider value={data}>{children}</AccountsContext.Provider>+ );}export function CachedAccounts({ children, idKey }) {diff --git a/packages/loot-core/src/client/data-hooks/payees.tsx b/packages/loot-core/src/client/data-hooks/payees.tsxindex f5b1956aca..8197d50e7a 100644--- a/packages/loot-core/src/client/data-hooks/payees.tsx+++ b/packages/loot-core/src/client/data-hooks/payees.tsx@@ -13,7 +13,9 @@ const PayeesContext = createContext<PayeeEntity[]>(null);export function PayeesProvider({ children }) {const data = usePayees();- return <PayeesContext.Provider value={data} children={children} />;+ return (+ <PayeesContext.Provider value={data}>{children}</PayeesContext.Provider>+ );}export function CachedPayees({ children, idKey }) {diff --git a/packages/loot-core/src/client/data-hooks/schedules.tsx b/packages/loot-core/src/client/data-hooks/schedules.tsxindex a139658c9b..0a46c38e96 100644--- a/packages/loot-core/src/client/data-hooks/schedules.tsx+++ b/packages/loot-core/src/client/data-hooks/schedules.tsx@@ -69,7 +69,11 @@ const SchedulesContext = createContext(null);export function SchedulesProvider({ transform, children }) {const data = useSchedules({ transform });- return <SchedulesContext.Provider value={data} children={children} />;+ return (+ <SchedulesContext.Provider value={data}>+ {children}+ </SchedulesContext.Provider>+ );}export function useCachedSchedules() {diff --git a/packages/loot-core/src/client/query-hooks.tsx b/packages/loot-core/src/client/query-hooks.tsxindex 329f466b73..52314faa37 100644--- a/packages/loot-core/src/client/query-hooks.tsx+++ b/packages/loot-core/src/client/query-hooks.tsx@@ -46,7 +46,7 @@ function makeContext(queryState, opts, QueryClass) {};}, []);- return <Context.Provider value={value} children={children} />;+ return <Context.Provider value={value}>{children}</Context.Provider>;}function useQuery() {diff --git a/upcoming-release-notes/2029.md b/upcoming-release-notes/2029.mdnew file mode 100644index 0000000000..68c09ee2a4--- /dev/null+++ b/upcoming-release-notes/2029.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [MatissJanis]+---++Enable `react/no-children-prop` rule and fix the issues