Skip to content

A local-first personal finance app

πŸ› Fix goals tooltip obstructing cover spending context menu (#5051)

Johnn277d38f6934dda
diff --git a/packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx b/packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx
index cfbcf482a3..e3b058d7c2 100644
--- a/packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx
+++ b/packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx
@@ -98,6 +98,7 @@ type BalanceWithCarryoverProps = Omit<
isDisabled?: boolean;
shouldInlineGoalStatus?: boolean;
CarryoverIndicator?: ComponentType<CarryoverIndicatorProps>;
+ tooltipDisabled?: boolean;
};
export function BalanceWithCarryover({
@@ -109,6 +110,7 @@ export function BalanceWithCarryover({
isDisabled,
shouldInlineGoalStatus,
CarryoverIndicator: CarryoverIndicatorComponent = CarryoverIndicator,
+ tooltipDisabled,
children,
...props
}: BalanceWithCarryoverProps) {
@@ -259,7 +261,10 @@ export function BalanceWithCarryover({
triggerProps={{
delay: 750,
isDisabled:
- !isGoalTemplatesEnabled || goalValue == null || isNarrowWidth,
+ !isGoalTemplatesEnabled ||
+ goalValue == null ||
+ isNarrowWidth ||
+ tooltipDisabled,
}}
>
{children ? (
diff --git a/packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx b/packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx
index 785a8c29c9..246fcc096c 100644
--- a/packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx
+++ b/packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx
@@ -496,6 +496,7 @@ export const ExpenseCategoryMonth = memo(function ExpenseCategoryMonth({
goal={envelopeBudget.catGoal(category.id)}
budgeted={envelopeBudget.catBudgeted(category.id)}
longGoal={envelopeBudget.catLongGoal(category.id)}
+ tooltipDisabled={balanceMenuOpen}
/>
</span>
diff --git a/upcoming-release-notes/5051.md b/upcoming-release-notes/5051.md
new file mode 100644
index 0000000000..6d6259e9b2
--- /dev/null
+++ b/upcoming-release-notes/5051.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [johnn27]
+---
+
+πŸ› Fix goals tooltip obstructing cover spending context menu