A local-first personal finance app
Global prefs undefined change (#4837)
Alec Bakholdin7e3ebb7e5f3d
diff --git a/packages/desktop-client/src/components/settings/LanguageSettings.tsx b/packages/desktop-client/src/components/settings/LanguageSettings.tsxindex 2c04986a95..dee10cb28c 100644--- a/packages/desktop-client/src/components/settings/LanguageSettings.tsx+++ b/packages/desktop-client/src/components/settings/LanguageSettings.tsx@@ -79,7 +79,7 @@ export function LanguageSettings() {the instructions{' '}<Linkvariant="external"- to="https://actualbudget.org/docs/install/local#translations"+ to="https://actualbudget.org/docs/install/build-from-source#translations">here</Link>{' '}diff --git a/packages/loot-core/src/server/preferences/app.ts b/packages/loot-core/src/server/preferences/app.tsindex 51a5783687..4df984e80e 100644--- a/packages/loot-core/src/server/preferences/app.ts+++ b/packages/loot-core/src/server/preferences/app.ts@@ -66,28 +66,28 @@ async function saveGlobalPrefs(prefs: GlobalPrefs) {return 'ok';}- if (prefs.maxMonths) {+ if (prefs.maxMonths !== undefined) {await asyncStorage.setItem('max-months', '' + prefs.maxMonths);}- if (prefs.documentDir && (await fs.exists(prefs.documentDir))) {+ if (prefs.documentDir !== undefined && (await fs.exists(prefs.documentDir))) {await asyncStorage.setItem('document-dir', prefs.documentDir);}if (prefs.floatingSidebar !== undefined) {await asyncStorage.setItem('floating-sidebar', '' + prefs.floatingSidebar);}- if (prefs.language) {+ if (prefs.language !== undefined) {await asyncStorage.setItem('language', prefs.language);}- if (prefs.theme) {+ if (prefs.theme !== undefined) {await asyncStorage.setItem('theme', prefs.theme);}- if (prefs.preferredDarkTheme) {+ if (prefs.preferredDarkTheme !== undefined) {await asyncStorage.setItem('preferred-dark-theme',prefs.preferredDarkTheme,);}- if (prefs.serverSelfSignedCert) {+ if (prefs.serverSelfSignedCert !== undefined) {await asyncStorage.setItem('server-self-signed-cert',prefs.serverSelfSignedCert,diff --git a/upcoming-release-notes/4837.md b/upcoming-release-notes/4837.mdnew file mode 100644index 0000000000..7760ca7b0d--- /dev/null+++ b/upcoming-release-notes/4837.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [alecbakholdin]+---++Fixed saving falsy values in saveGlobalPrefs