A local-first personal finance app
add Fortuneo Banque GoCardless integration (#389)
Tom Crasset7e84cf897cc5
diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.jsindex 831c694ec0..7747065029 100644--- a/src/app-gocardless/bank-factory.js+++ b/src/app-gocardless/bank-factory.js@@ -4,6 +4,7 @@ import BankinterBkbkesmm from './banks/bankinter-bkbkesmm.js';import Belfius from './banks/belfius_gkccbebb.js';import BnpBeGebabebb from './banks/bnp-be-gebabebb.js';import DanskeBankDabNO22 from './banks/danskebank-dabno22.js';+import Fortuneo from './banks/FORTUNEO_FTNOFRP1XXX.js';import IngIngddeff from './banks/ing-ingddeff.js';import IngPlIngbplpw from './banks/ing-pl-ingbplpw.js';import IntegrationBank from './banks/integration-bank.js';@@ -25,6 +26,7 @@ export const banks = [Belfius,BnpBeGebabebb,DanskeBankDabNO22,+ Fortuneo,IngIngddeff,IngPlIngbplpw,MbankRetailBrexplpw,diff --git a/src/app-gocardless/banks/FORTUNEO_FTNOFRP1XXX.js b/src/app-gocardless/banks/FORTUNEO_FTNOFRP1XXX.jsnew file mode 100644index 0000000000..f73d8156b1--- /dev/null+++ b/src/app-gocardless/banks/FORTUNEO_FTNOFRP1XXX.js@@ -0,0 +1,62 @@+import { formatPayeeName } from '../../util/payee-name.js';+import Fallback from './integration-bank.js';+import * as d from 'date-fns';++/** @type {import('./bank.interface.js').IBank} */+export default {+ ...Fallback,++ institutionIds: ['FORTUNEO_FTNOFRP1XXX'],++ accessValidForDays: 90,++ normalizeTransaction(transaction, _booked) {+ const date =+ transaction.bookingDate ||+ transaction.bookingDateTime ||+ transaction.valueDate ||+ transaction.valueDateTime;+ // If we couldn't find a valid date field we filter out this transaction+ // and hope that we will import it again once the bank has processed the+ // transaction further.+ if (!date) {+ return null;+ }++ // Most of the information from the transaction is in the remittanceInformationUnstructuredArray field.+ // We extract the creditor and debtor names from this field.+ // The remittanceInformationUnstructuredArray field usually contain keywords like "Vir" for+ // bank transfers or "Carte 03/06" for card payments, as well as the date.+ // We remove these keywords to get a cleaner payee name.+ const keywordsToRemove = [+ 'VIR INST',+ 'VIR',+ 'PRLV',+ 'ANN CARTE',+ 'CARTE \\d{2}\\/\\d{2}',+ ];++ const details =+ transaction.remittanceInformationUnstructuredArray.join(' ');+ const amount = transaction.transactionAmount.amount;++ const regex = new RegExp(keywordsToRemove.join('|'), 'g');+ const payeeName = details.replace(regex, '').trim();++ // The amount is negative for outgoing transactions, positive for incoming transactions.+ const isCreditorPayee = parseFloat(amount) < 0;++ // The payee name is the creditor name for outgoing transactions and the debtor name for incoming transactions.+ const creditorName = isCreditorPayee ? payeeName : null;+ const debtorName = isCreditorPayee ? null : payeeName;++ transaction.creditorName = creditorName;+ transaction.debtorName = debtorName;++ return {+ ...transaction,+ payeeName: formatPayeeName(transaction),+ date: d.format(d.parseISO(date), 'yyyy-MM-dd'),+ };+ },+};diff --git a/src/app-gocardless/banks/tests/FORTUNEO_FTNOFRP1XXX.spec.js b/src/app-gocardless/banks/tests/FORTUNEO_FTNOFRP1XXX.spec.jsnew file mode 100644index 0000000000..5188699eac--- /dev/null+++ b/src/app-gocardless/banks/tests/FORTUNEO_FTNOFRP1XXX.spec.js@@ -0,0 +1,210 @@+import Fortuneo from '../FORTUNEO_FTNOFRP1XXX.js';++describe('Fortuneo', () => {+ describe('#normalizeTransaction', () => {+ const transactionsRaw = [+ {+ bookingDate: '2024-07-05',+ valueDate: '2024-07-05',+ transactionAmount: {+ amount: '-12.0',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: ['PRLV ONG'],+ internalTransactionId: '674323725470140d5caaf7b85a135817',+ date: '2024-07-05',+ },+ {+ bookingDate: '2024-07-04',+ valueDate: '2024-07-04',+ transactionAmount: {+ amount: '-7.72',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: [+ 'PRLV PRIXTEL SCOR/53766825A',+ ],+ internalTransactionId: 'e8365f68077f2be249f8dfa9183296e4',+ date: '2024-07-04',+ },+ {+ bookingDate: '2024-07-04',+ valueDate: '2024-07-04',+ transactionAmount: {+ amount: '-500.0',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: ['VIR XXXYYYYZZZ'],+ internalTransactionId: '0c12be495b71a63d14e46c43bfcb12f6',+ date: '2024-07-04',+ },+ {+ bookingDate: '2024-07-04',+ valueDate: '2024-07-04',+ transactionAmount: {+ amount: '-10.49',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: [+ 'CARTE 04/07 Google Payment I Dublin',+ ],+ internalTransactionId: 'b09df9be4711cb06bdd2a53aef5423cc',+ date: '2024-07-04',+ },+ {+ bookingDate: '2024-07-04',+ valueDate: '2024-07-04',+ transactionAmount: {+ amount: '-6.38',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: ['CARTE 03/07 SPORT MARKET'],+ internalTransactionId: '67552cc7782c742f1df8297e614470ea',+ date: '2024-07-04',+ },+ {+ bookingDate: '2024-07-04',+ valueDate: '2024-07-04',+ transactionAmount: {+ amount: '26.52',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: [+ 'ANN CARTE WEEZEVENT SOMEPLACE',+ ],+ internalTransactionId: 'c0bed1b61806bd45fd07732e5dfb1f11',+ date: '2024-07-04',+ },+ {+ bookingDate: '2024-07-03',+ valueDate: '2024-07-03',+ transactionAmount: {+ amount: '-104.9',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: [+ "CARTE 02/07 HPY*L'APPAC - Sport JANDA",+ ],+ internalTransactionId: '7716b23b56cda848efd788a0d8c79d12',+ date: '2024-07-03',+ },+ {+ bookingDate: '2024-07-03',+ valueDate: '2024-07-02',+ transactionAmount: {+ amount: '-22.95',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: [+ 'VIR INST Leclerc XXXX Leclerc XXXX 44321IXCRT211141232',+ ],+ internalTransactionId: 'e75304593c9557f20014904f90eb23a2',+ date: '2024-07-03',+ },+ {+ bookingDate: '2024-07-02',+ valueDate: '2024-07-02',+ transactionAmount: {+ amount: '-8.9',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: ['CARTE 01/07 CHIK CHAK'],+ internalTransactionId: 'e9811e50c8d7453c459f4e42453cf07c',+ date: '2024-07-02',+ },+ {+ bookingDate: '2024-07-02',+ valueDate: '2024-07-02',+ transactionAmount: {+ amount: '-8.0',+ currency: 'EUR',+ },+ remittanceInformationUnstructuredArray: [+ 'CARTE 01/07 SERVICE 1228 GENEV 8,00 EUR',+ ],+ internalTransactionId: '354a49232bd05de583a3d2ab834e20cd',+ date: '2024-07-02',+ },+ ];++ it('sets debtor and creditor name according to amount', () => {+ const creditorTransaction = transactionsRaw[0];+ const debtorTransaction = transactionsRaw[5];++ const normalizedCreditorTransaction = Fortuneo.normalizeTransaction(+ creditorTransaction,+ true,+ );+ const normalizedDebtorTransaction = Fortuneo.normalizeTransaction(+ debtorTransaction,+ true,+ );++ expect(normalizedCreditorTransaction.creditorName).toBeDefined();+ expect(normalizedCreditorTransaction.debtorName).toBeNull();+ expect(+ parseFloat(normalizedCreditorTransaction.transactionAmount.amount),+ ).toBeLessThan(0);++ expect(normalizedDebtorTransaction.debtorName).toBeDefined();+ expect(normalizedDebtorTransaction.creditorName).toBeNull();+ expect(+ parseFloat(normalizedDebtorTransaction.transactionAmount.amount),+ ).toBeGreaterThan(0);+ });++ it('extracts payee name from remittanceInformationUnstructured', () => {+ const transaction0 = transactionsRaw[0];+ const normalizedTransaction = Fortuneo.normalizeTransaction(+ transaction0,+ true,+ );++ expect(normalizedTransaction.creditorName).toBe('ONG');++ const transaction2 = transactionsRaw[2];+ const normalizedTransaction2 = Fortuneo.normalizeTransaction(+ transaction2,+ true,+ );++ expect(normalizedTransaction2.creditorName).toBe('XXXYYYYZZZ');++ const transaction3 = transactionsRaw[3];+ const normalizedTransaction3 = Fortuneo.normalizeTransaction(+ transaction3,+ true,+ );++ expect(normalizedTransaction3.creditorName).toBe(+ 'Google Payment I Dublin',+ );++ const transaction4 = transactionsRaw[4];+ const normalizedTransaction4 = Fortuneo.normalizeTransaction(+ transaction4,+ true,+ );++ expect(normalizedTransaction4.creditorName).toBe('SPORT MARKET');++ const transaction5 = transactionsRaw[5];+ const normalizedTransaction5 = Fortuneo.normalizeTransaction(+ transaction5,+ true,+ );++ expect(normalizedTransaction5.debtorName).toBe('WEEZEVENT SOMEPLACE');++ const transaction7 = transactionsRaw[7];+ const normalizedTransaction7 = Fortuneo.normalizeTransaction(+ transaction7,+ true,+ );++ expect(normalizedTransaction7.creditorName).toBe(+ 'Leclerc XXXX Leclerc XXXX 44321IXCRT211141232',+ );+ });+ });+});diff --git a/upcoming-release-notes/389.md b/upcoming-release-notes/389.mdnew file mode 100644index 0000000000..9745dea435--- /dev/null+++ b/upcoming-release-notes/389.md@@ -0,0 +1,6 @@+---+category: Enhancements+authors: [tcrasset]+---++Add Fortuneo GoCardless Integration\ No newline at end of file