Skip to content

A local-first personal finance app

Refresh akahu account if stale (#8115)

Tim7ee821343b2a
diff --git a/packages/sync-server/src/app-akahu/app-akahu.ts b/packages/sync-server/src/app-akahu/app-akahu.ts
index ecf662f4b8..c56ecade23 100644
--- a/packages/sync-server/src/app-akahu/app-akahu.ts
+++ b/packages/sync-server/src/app-akahu/app-akahu.ts
@@ -17,6 +17,7 @@ import {
requestLoggerMiddleware,
validateSessionMiddleware,
} from '#util/middlewares';
+import { createMutex } from '#util/mutex';
type AkahuTransaction = {
booked: boolean;
@@ -135,7 +136,7 @@ app.post(
try {
const akahu = new AkahuClient({ appToken });
- const account = await akahu.accounts.get(userToken, accountId);
+ const account = await getRefreshedAccount(akahu, userToken, accountId);
if (!account) {
return res.send({
status: 'error',
@@ -265,6 +266,41 @@ app.post(
}),
);
+// prevent race conditions when refreshing accounts
+const runRefresh = createMutex();
+
+function getRefreshedAccount(
+ akahu: AkahuClient,
+ userToken: string,
+ accountId: string,
+): Promise<Account | null> {
+ return runRefresh(async () => {
+ let account = await akahu.accounts.get(userToken, accountId);
+ if (!account) {
+ return null;
+ } else if (!shouldRefreshAccount(account.refreshed?.transactions)) {
+ return account;
+ }
+
+ await akahu.accounts.refreshAll(userToken);
+
+ // wait for the refresh to complete
+ for (let i = 0; i < 5; i++) {
+ await new Promise(resolve => setTimeout(resolve, 3000));
+ account = await akahu.accounts.get(userToken, accountId);
+ if (!account) {
+ return null;
+ } else if (!shouldRefreshAccount(account.refreshed?.transactions)) {
+ // wait for transactions to settle
+ await new Promise(resolve => setTimeout(resolve, 3000));
+ break;
+ }
+ }
+
+ return account;
+ });
+}
+
function isEnriched(
trans:
| Transaction
@@ -339,3 +375,17 @@ function processTransaction(
transactionId: trans._id,
};
}
+
+const AKAHU_TRANSACTION_REFRESH_INTERVAL_MS = 60 * 60 * 1000;
+
+function shouldRefreshAccount(refreshedAt?: string) {
+ if (!refreshedAt) {
+ return false;
+ }
+
+ const refreshedAtTime = Date.parse(refreshedAt);
+ return (
+ Number.isFinite(refreshedAtTime) &&
+ Date.now() - refreshedAtTime > AKAHU_TRANSACTION_REFRESH_INTERVAL_MS
+ );
+}
diff --git a/packages/sync-server/src/util/mutex.ts b/packages/sync-server/src/util/mutex.ts
new file mode 100644
index 0000000000..dd5f8ca53c
--- /dev/null
+++ b/packages/sync-server/src/util/mutex.ts
@@ -0,0 +1,14 @@
+export const createMutex = (): (<A>(
+ operation: () => Promise<A>,
+) => Promise<A>) => {
+ let mutex = Promise.resolve();
+
+ return <A>(operation: () => Promise<A>) =>
+ new Promise<A>((resolve, reject) => {
+ mutex = mutex.finally(() => {
+ try {
+ return operation().then(resolve, reject);
+ } catch {}
+ });
+ });
+};
diff --git a/upcoming-release-notes/akahu-refresh.md b/upcoming-release-notes/akahu-refresh.md
new file mode 100644
index 0000000000..e780e009b8
--- /dev/null
+++ b/upcoming-release-notes/akahu-refresh.md
@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [tim-smart]
+---
+
+Refresh Akahu account if stale