A local-first personal finance app
:bug: (signup) fix setting up for the first time with missing protocol (#1657)
Matiss Janis Aboltins852b5373bc54
diff --git a/packages/desktop-client/src/components/manager/ConfigServer.tsx b/packages/desktop-client/src/components/manager/ConfigServer.tsxindex 8934024d20..e61887a8e2 100644--- a/packages/desktop-client/src/components/manager/ConfigServer.tsx+++ b/packages/desktop-client/src/components/manager/ConfigServer.tsx@@ -49,7 +49,7 @@ export default function ConfigServer() {let { error } = await setServerUrl(url);if (- error === 'network-failure' &&+ ['network-failure', 'get-server-failure'].includes(error) &&!url.startsWith('http://') &&!url.startsWith('https://')) {diff --git a/packages/loot-core/src/server/main.ts b/packages/loot-core/src/server/main.tsindex d76af67ee1..ac73984651 100644--- a/packages/loot-core/src/server/main.ts+++ b/packages/loot-core/src/server/main.ts@@ -1628,8 +1628,12 @@ handlers['get-did-bootstrap'] = async function () {handlers['subscribe-needs-bootstrap'] = async function ({url,}: { url? } = {}) {- if (!getServer(url)) {- return { bootstrapped: true, hasServer: false };+ try {+ if (!getServer(url)) {+ return { bootstrapped: true, hasServer: false };+ }+ } catch (err) {+ return { error: 'get-server-failure' };}let res;diff --git a/packages/loot-core/src/server/server-config.ts b/packages/loot-core/src/server/server-config.tsindex 623cced37c..ab0e72096d 100644--- a/packages/loot-core/src/server/server-config.ts+++ b/packages/loot-core/src/server/server-config.ts@@ -32,8 +32,7 @@ export function getServer(url?: string): ServerConfig | null {SYNC_SERVER: joinURL(url, '/sync'),SIGNUP_SERVER: joinURL(url, '/account'),PLAID_SERVER: joinURL(url, '/plaid'),- // TODO: change to use `/gocardless` after v23.8.0- GOCARDLESS_SERVER: joinURL(url, '/nordigen'),+ GOCARDLESS_SERVER: joinURL(url, '/gocardless'),};}return config;diff --git a/upcoming-release-notes/1657.md b/upcoming-release-notes/1657.mdnew file mode 100644index 0000000000..50be64716e--- /dev/null+++ b/upcoming-release-notes/1657.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [MatissJanis]+---++Fix signup page not allowing to use domains without protocol