A local-first personal finance app
ESLint prefer-const (#1956)
Joel Jeremy Marquez881999bcfeea
diff --git a/.eslintrc.js b/.eslintrc.jsindex c8785c13f6..78a6e37d12 100644--- a/.eslintrc.js+++ b/.eslintrc.js@@ -232,6 +232,25 @@ module.exports = {'no-restricted-imports': ['off', { patterns: restrictedImportColors }],},},+ // TODO: Remove this override once we addressed all warnings and enable the rule globally.+ {+ files: [+ './packages/api/*',+ './packages/api/app/**/*',+ './packages/crdt/**/*',+ './packages/desktop-client/src/*',+ './packages/desktop-client/src/hooks/**/*',+ './packages/desktop-client/src/icons/**/*',+ './packages/desktop-client/src/style/**/*',+ './packages/desktop-client/src/types/**/*',+ './packages/desktop-client/src/util/**/*',+ './packages/desktop-electron/**/*',+ './packages/eslint-plugin-actual/**/*',+ ],+ rules: {+ 'prefer-const': 'warn',+ },+ },],settings: {'import/parsers': {diff --git a/packages/api/app/query.js b/packages/api/app/query.jsindex 1ee3b16eca..dddb807de3 100644--- a/packages/api/app/query.js+++ b/packages/api/app/query.js@@ -23,7 +23,7 @@ class Query {}unfilter(exprs) {- let exprSet = new Set(exprs);+ const exprSet = new Set(exprs);return new Query({...this.state,filterExpressions: this.state.filterExpressions.filter(@@ -37,13 +37,13 @@ class Query {exprs = [exprs];}- let query = new Query({ ...this.state, selectExpressions: exprs });+ const query = new Query({ ...this.state, selectExpressions: exprs });query.state.calculation = false;return query;}calculate(expr) {- let query = this.select({ result: expr });+ const query = this.select({ result: expr });query.state.calculation = true;return query;}diff --git a/packages/crdt/src/crdt/merkle.test.ts b/packages/crdt/src/crdt/merkle.test.tsindex 48f300f45a..a9209d3a1d 100644--- a/packages/crdt/src/crdt/merkle.test.ts+++ b/packages/crdt/src/crdt/merkle.test.ts@@ -69,8 +69,8 @@ describe('merkle trie', () => {});test('diffing works with empty tries', () => {- let trie1 = merkle.emptyTrie();- let trie2 = merkle.insert(+ const trie1 = merkle.emptyTrie();+ const trie2 = merkle.insert(merkle.emptyTrie(),Timestamp.parse('2009-01-02T10:17:37.789Z-0000-0000testinguuid1')!,);@@ -79,7 +79,7 @@ describe('merkle trie', () => {});test('pruning works and keeps correct hashes', () => {- let messages = [+ const messages = [message('2018-11-01T01:00:00.000Z-0000-0123456789ABCDEF', 1000),message('2018-11-01T01:09:00.000Z-0000-0123456789ABCDEF', 1100),message('2018-11-01T01:18:00.000Z-0000-0123456789ABCDEF', 1200),@@ -101,13 +101,13 @@ describe('merkle trie', () => {expect(trie.hash).toBe(2496);expect(trie).toMatchSnapshot();- let pruned = merkle.prune(trie);+ const pruned = merkle.prune(trie);expect(pruned.hash).toBe(2496);expect(pruned).toMatchSnapshot();});test('diffing differently shaped tries returns correct time', () => {- let messages = [+ const messages = [message('2018-11-01T01:00:00.000Z-0000-0123456789ABCDEF', 1000),message('2018-11-01T01:09:00.000Z-0000-0123456789ABCDEF', 1100),message('2018-11-01T01:18:00.000Z-0000-0123456789ABCDEF', 1200),@@ -122,7 +122,7 @@ describe('merkle trie', () => {message('2018-11-01T02:37:00.000Z-0000-0123456789ABCDEF', 2100),];- let trie = insertMessages({}, messages);+ const trie = insertMessages({}, messages);// Case 0: It always returns a base time when comparing with an// empty trie@@ -136,7 +136,7 @@ describe('merkle trie', () => {// Case 1: Add an older message that modifies the trie in such a// way that it modifies the 1st out of 3 branches (so it will be// pruned away)- let trie1 = insertMessages(trie, [+ const trie1 = insertMessages(trie, [message('2018-11-01T00:59:00.000Z-0000-0123456789ABCDEF', 900),]);@@ -167,7 +167,7 @@ describe('merkle trie', () => {// Case 2: Add two messages similar to the above case, but the// second message modifies the 2nd key at the same level as the// first message modifying the 1st key- let trie2 = insertMessages(trie, [+ const trie2 = insertMessages(trie, [message('2018-11-01T00:59:00.000Z-0000-0123456789ABCDEF', 900),message('2018-11-01T01:15:00.000Z-0000-0123456789ABCDEF', 1422),]);diff --git a/packages/crdt/src/crdt/merkle.ts b/packages/crdt/src/crdt/merkle.tsindex 3413a471b8..067fdb52db 100644--- a/packages/crdt/src/crdt/merkle.ts+++ b/packages/crdt/src/crdt/merkle.ts@@ -36,7 +36,7 @@ export function getKeys(trie: TrieNode): NumberTrieNodeKey[] {export function keyToTimestamp(key: string): number {// 16 is the length of the base 3 value of the current time in// minutes. Ensure it's padded to create the full value- let fullkey = key + '0'.repeat(16 - key.length);+ const fullkey = key + '0'.repeat(16 - key.length);// Parse the base 3 representationreturn parseInt(fullkey, 3) * 1000 * 60;@@ -46,8 +46,8 @@ export function keyToTimestamp(key: string): number {* Mutates `trie` to insert a node at `timestamp`*/export function insert(trie: TrieNode, timestamp: Timestamp) {- let hash = timestamp.hash();- let key = Number(Math.floor(timestamp.millis() / 1000 / 60)).toString(3);+ const hash = timestamp.hash();+ const key = Number(Math.floor(timestamp.millis() / 1000 / 60)).toString(3);trie = Object.assign({}, trie, { hash: (trie.hash || 0) ^ hash });return insertKey(trie, key, hash);@@ -68,8 +68,8 @@ function insertKey(trie: TrieNode, key: string, hash: number): TrieNode {}export function build(timestamps: Timestamp[]) {- let trie = emptyTrie();- for (let timestamp of timestamps) {+ const trie = emptyTrie();+ for (const timestamp of timestamps) {insert(trie, timestamp);}return trie;@@ -89,8 +89,8 @@ export function diff(trie1: TrieNode, trie2: TrieNode): number | null {// left (this shouldn't happen, if that's the case the hash check at// the top of this function should pass)while (1) {- let keyset = new Set([...getKeys(node1), ...getKeys(node2)]);- let keys = [...keyset.values()];+ const keyset = new Set([...getKeys(node1), ...getKeys(node2)]);+ const keys = [...keyset.values()];keys.sort();let diffkey = null;@@ -110,10 +110,10 @@ export function diff(trie1: TrieNode, trie2: TrieNode): number | null {// changed time that we know of, because of pruning it might take// multiple passes to sync up a trie.for (let i = 0; i < keys.length; i++) {- let key = keys[i];+ const key = keys[i];- let next1 = node1[key];- let next2 = node2[key];+ const next1 = node1[key];+ const next2 = node2[key];if (!next1 || !next2) {break;@@ -143,13 +143,13 @@ export function prune(trie: TrieNode, n = 2): TrieNode {return trie;}- let keys = getKeys(trie);+ const keys = getKeys(trie);keys.sort();- let next: TrieNode = { hash: trie.hash };+ const next: TrieNode = { hash: trie.hash };// Prune child nodes.- for (let k of keys.slice(-n)) {+ for (const k of keys.slice(-n)) {const node = trie[k];if (!node) {diff --git a/packages/crdt/src/crdt/timestamp.test.ts b/packages/crdt/src/crdt/timestamp.test.tsindex cea2a94a74..d54c2e2857 100644--- a/packages/crdt/src/crdt/timestamp.test.ts+++ b/packages/crdt/src/crdt/timestamp.test.ts@@ -28,7 +28,7 @@ describe('Timestamp', function () {describe('parsing', function () {it('should not parse', function () {- let invalidInputs = [+ const invalidInputs = [null,undefined,{},@@ -44,19 +44,19 @@ describe('Timestamp', function () {'9999-12-31T23:59:59.999Z-10000-FFFFFFFFFFFFFFFF','9999-12-31T23:59:59.999Z-FFFF-10000000000000000',];- for (let invalidInput of invalidInputs) {+ for (const invalidInput of invalidInputs) {expect(Timestamp.parse(invalidInput as string)).toBe(null);}});it('should parse', function () {- let validInputs = [+ const validInputs = ['1970-01-01T00:00:00.000Z-0000-0000000000000000','2015-04-24T22:23:42.123Z-1000-0123456789ABCDEF','9999-12-31T23:59:59.999Z-FFFF-FFFFFFFFFFFFFFFF',];- for (let validInput of validInputs) {- let parsed = Timestamp.parse(validInput)!;+ for (const validInput of validInputs) {+ const parsed = Timestamp.parse(validInput)!;expect(typeof parsed).toBe('object');expect(parsed.millis() >= 0).toBeTruthy();expect(parsed.millis() < 253402300800000).toBeTruthy();diff --git a/packages/crdt/src/crdt/timestamp.ts b/packages/crdt/src/crdt/timestamp.tsindex ff2fb3496f..cdc72dc583 100644--- a/packages/crdt/src/crdt/timestamp.ts+++ b/packages/crdt/src/crdt/timestamp.ts@@ -80,7 +80,7 @@ export function makeClientId() {return uuidv4().replace(/-/g, '').slice(-16);}-let config = {+const config = {// Allow 5 minutes of clock driftmaxDrift: 5 * 60 * 1000,};@@ -168,11 +168,11 @@ export class Timestamp {return timestamp;}if (typeof timestamp === 'string') {- let parts = timestamp.split('-');+ const parts = timestamp.split('-');if (parts && parts.length === 5) {- let millis = Date.parse(parts.slice(0, 3).join('-')).valueOf();- let counter = parseInt(parts[3], 16);- let node = parts[4];+ const millis = Date.parse(parts.slice(0, 3).join('-')).valueOf();+ const counter = parseInt(parts[3], 16);+ const node = parts[4];if (!isNaN(millis) &&millis >= 0 &&@@ -198,17 +198,17 @@ export class Timestamp {}// retrieve the local wall time- let phys = Date.now();+ const phys = Date.now();// unpack the clock.timestamp logical time and counter- let lOld = clock.timestamp.millis();- let cOld = clock.timestamp.counter();+ const lOld = clock.timestamp.millis();+ const cOld = clock.timestamp.counter();// calculate the next logical time and counter// * ensure that the logical time never goes backward// * increment the counter if phys time does not advance- let lNew = Math.max(lOld, phys);- let cNew = lOld === lNew ? cOld + 1 : 0;+ const lNew = Math.max(lOld, phys);+ const cNew = lOld === lNew ? cOld + 1 : 0;// check the result for drift and counter overflowif (lNew - phys > config.maxDrift) {@@ -238,11 +238,11 @@ export class Timestamp {}// retrieve the local wall time- let phys = Date.now();+ const phys = Date.now();// unpack the message wall time/counter- let lMsg = msg.millis();- let cMsg = msg.counter();+ const lMsg = msg.millis();+ const cMsg = msg.counter();// assert the node id and remote clock drift// if (msg.node() === clock.timestamp.node()) {@@ -253,8 +253,8 @@ export class Timestamp {}// unpack the clock.timestamp logical time and counter- let lOld = clock.timestamp.millis();- let cOld = clock.timestamp.counter();+ const lOld = clock.timestamp.millis();+ const cOld = clock.timestamp.counter();// calculate the next logical time and counter// . ensure that the logical time never goes backward@@ -262,8 +262,8 @@ export class Timestamp {// . if max = old > message, increment local counter// . if max = messsage > old, increment message counter// . otherwise, clocks are monotonic, reset counter- let lNew = Math.max(Math.max(lOld, phys), lMsg);- let cNew =+ const lNew = Math.max(Math.max(lOld, phys), lMsg);+ const cNew =lNew === lOld && lNew === lMsg? Math.max(cOld, cMsg) + 1: lNew === lOlddiff --git a/packages/desktop-client/src/browser-preload.browser.js b/packages/desktop-client/src/browser-preload.browser.jsindex 5a6f6850f8..e3730195f8 100644--- a/packages/desktop-client/src/browser-preload.browser.js+++ b/packages/desktop-client/src/browser-preload.browser.js@@ -11,8 +11,8 @@ const backendWorkerUrl = new URL('./browser-server.js', import.meta.url);// browser environment this is where we initialize the backend and// everything else.-let IS_DEV = process.env.NODE_ENV === 'development';-let ACTUAL_VERSION = Platform.isPlaywright ? '99.9.9' : packageJson.version;+const IS_DEV = process.env.NODE_ENV === 'development';+const ACTUAL_VERSION = Platform.isPlaywright ? '99.9.9' : packageJson.version;// *** Start the backend ***let worker;@@ -67,7 +67,7 @@ global.Actual = {input.id = 'open-file-dialog-input';input.value = null;- let filter = filters.find(filter => filter.extensions);+ const filter = filters.find(filter => filter.extensions);if (filter) {input.accept = filter.extensions.map(ext => '.' + ext).join(',');}@@ -78,14 +78,14 @@ global.Actual = {input.style.display = 'none';input.onchange = e => {- let file = e.target.files[0];- let filename = file.name.replace(/.*(\.[^.]*)/, 'file$1');+ const file = e.target.files[0];+ const filename = file.name.replace(/.*(\.[^.]*)/, 'file$1');if (file) {- let reader = new FileReader();+ const reader = new FileReader();reader.readAsArrayBuffer(file);reader.onload = async function (ev) {- let filepath = `/uploads/${filename}`;+ const filepath = `/uploads/${filename}`;window.__actionsForMenu.uploadFile(filename, ev.target.result)diff --git a/packages/desktop-client/src/browser-server.js b/packages/desktop-client/src/browser-server.jsindex fcb2949c43..6efb691f2d 100644--- a/packages/desktop-client/src/browser-server.js+++ b/packages/desktop-client/src/browser-server.js@@ -38,13 +38,13 @@ const importScriptsWithRetry = async (script, { maxRetries = 5 } = {}) => {self.addEventListener('message', async e => {if (!hasInitialized) {- let msg = e.data;+ const msg = e.data;if (msg.type === 'init') {hasInitialized = true;- let isDev = !!msg.isDev;+ const isDev = !!msg.isDev;// let version = msg.version;- let hash = msg.hash;+ const hash = msg.hash;if (!self.SharedArrayBuffer && !msg.isSharedArrayBufferOverrideEnabled) {self.postMessage({@@ -61,7 +61,7 @@ self.addEventListener('message', async e => {backend.initApp(isDev, self).catch(err => {console.log(err);- let msg = {+ const msg = {type: 'app-init-failure',IDBFailure: err.message.includes('indexeddb-failure'),};diff --git a/packages/desktop-client/src/global-events.js b/packages/desktop-client/src/global-events.jsindex 258e13ea21..2123b26756 100644--- a/packages/desktop-client/src/global-events.js+++ b/packages/desktop-client/src/global-events.js@@ -45,7 +45,7 @@ export function handleGlobalEvents(actions, store) {// We don't need to query anything until the file is loaded, and// sync events might come in if the file is being synced before// being loaded (happens when downloading)- let prefs = store.getState().prefs.local;+ const prefs = store.getState().prefs.local;if (prefs && prefs.id) {if (type === 'applied') {if (tables.includes('payees') || tables.includes('payee_mapping')) {@@ -70,8 +70,8 @@ export function handleGlobalEvents(actions, store) {sharedListeners.listenForSyncEvent(actions, store);listen('undo-event', undoState => {- let { tables, undoTag } = undoState;- let promises = [];+ const { tables, undoTag } = undoState;+ const promises = [];if (tables.includes('categories') ||@@ -85,7 +85,7 @@ export function handleGlobalEvents(actions, store) {promises.push(actions.getAccounts());}- let tagged = undo.getTaggedState(undoTag);+ const tagged = undo.getTaggedState(undoTag);if (tagged) {Promise.all(promises).then(() => {@@ -93,7 +93,7 @@ export function handleGlobalEvents(actions, store) {// If a modal has been tagged, open it instead of navigatingif (tagged.openModal) {- let { modalStack } = store.getState().modals;+ const { modalStack } = store.getState().modals;if (modalStack.length === 0 ||diff --git a/packages/desktop-client/src/gocardless.js b/packages/desktop-client/src/gocardless.jsindex 6db92f4867..308feb2c9e 100644--- a/packages/desktop-client/src/gocardless.js+++ b/packages/desktop-client/src/gocardless.js@@ -14,7 +14,7 @@ function _authorize(pushModal, upgradingAccountId, { onSuccess, onClose }) {const { link, requisitionId } = resp;window.Actual.openURLInBrowser(link);- let { error, data } = await send('gocardless-poll-web-token', {+ const { error, data } = await send('gocardless-poll-web-token', {upgradingAccountId,requisitionId,});diff --git a/packages/desktop-client/src/hooks/useLatestVersion.ts b/packages/desktop-client/src/hooks/useLatestVersion.tsindex 2a29a73fa9..b2bb46ab27 100644--- a/packages/desktop-client/src/hooks/useLatestVersion.ts+++ b/packages/desktop-client/src/hooks/useLatestVersion.ts@@ -3,7 +3,7 @@ import { useState, useEffect } from 'react';import { getIsOutdated, getLatestVersion } from '../util/versions';function useIsOutdated(): boolean {- let [isOutdated, setIsOutdated] = useState(false);+ const [isOutdated, setIsOutdated] = useState(false);const latestVersion = useLatestVersion();useEffect(() => {@@ -16,7 +16,7 @@ function useIsOutdated(): boolean {}function useLatestVersion(): string {- let [latestVersion, setLatestVersion] = useState('');+ const [latestVersion, setLatestVersion] = useState('');useEffect(() => {(async () => {setLatestVersion(await getLatestVersion());diff --git a/packages/desktop-client/src/hooks/useNavigate.ts b/packages/desktop-client/src/hooks/useNavigate.tsindex 21387e423b..05e993ff81 100644--- a/packages/desktop-client/src/hooks/useNavigate.ts+++ b/packages/desktop-client/src/hooks/useNavigate.ts@@ -26,7 +26,7 @@ export default function useNavigate(): NavigateFunction {},};- let { previousLocation, ...previousOriginalState } =+ const { previousLocation, ...previousOriginalState } =location.state || {};if (diff --git a/packages/desktop-client/src/hooks/useProperFocus.tsx b/packages/desktop-client/src/hooks/useProperFocus.tsxindex d75f60ac6f..d8e738599b 100644--- a/packages/desktop-client/src/hooks/useProperFocus.tsx+++ b/packages/desktop-client/src/hooks/useProperFocus.tsx@@ -13,7 +13,7 @@ function getFocusedKey(el: HTMLElement): string | null {let node: HTMLElement | ParentNode = el;// Search up to 10 parent nodesfor (let i = 0; i < 10 && node; i++) {- let key = 'dataset' in node ? node.dataset?.focusKey : undefined;+ const key = 'dataset' in node ? node.dataset?.focusKey : undefined;if (key) {return key;}@@ -28,7 +28,7 @@ function focusElement(refocusContext: AvoidRefocusScrollContextValue,): void {if (refocusContext) {- let key = getFocusedKey(el);+ const key = getFocusedKey(el);el.focus({ preventScroll: key && key === refocusContext.keyRef.current });refocusContext.onKeyChange(key);} else {@@ -45,7 +45,7 @@ type AvoidRefocusScrollContextValue = {onKeyChange: (key: string) => void;};-let AvoidRefocusScrollContext =+const AvoidRefocusScrollContext =createContext<AvoidRefocusScrollContextValue>(null);type AvoidRefocusScrollProviderProps = {@@ -55,9 +55,9 @@ type AvoidRefocusScrollProviderProps = {export function AvoidRefocusScrollProvider({children,}: AvoidRefocusScrollProviderProps) {- let keyRef = useRef<string>(null);+ const keyRef = useRef<string>(null);- let value = useMemo<AvoidRefocusScrollContextValue>(+ const value = useMemo<AvoidRefocusScrollContextValue>(() => ({keyRef,onKeyChange: key => {@@ -78,16 +78,16 @@ export function useProperFocus(ref: RefObject<HTMLElement>,shouldFocus: boolean,): void {- let context = useContext(AvoidRefocusScrollContext);- let prevShouldFocus = useRef(null);+ const context = useContext(AvoidRefocusScrollContext);+ const prevShouldFocus = useRef(null);useLayoutEffect(() => {- let prev = prevShouldFocus.current;- let view = ref.current;+ const prev = prevShouldFocus.current;+ const view = ref.current;if (view && shouldFocus && (prev === null || prev === false)) {- let selector = 'input,button,div[tabindex]';- let focusEl = view.matches(selector)+ const selector = 'input,button,div[tabindex]';+ const focusEl = view.matches(selector)? view: view.querySelector<HTMLElement>(selector);diff --git a/packages/desktop-client/src/hooks/useResizeObserver.ts b/packages/desktop-client/src/hooks/useResizeObserver.tsindex ef34570fc8..73c1a4521d 100644--- a/packages/desktop-client/src/hooks/useResizeObserver.ts+++ b/packages/desktop-client/src/hooks/useResizeObserver.ts@@ -3,14 +3,14 @@ import { useRef, useCallback } from 'react';export default function useResizeObserver(func: (contentRect: DOMRectReadOnly) => void,): (el: unknown) => void {- let observer = useRef(null);+ const observer = useRef(null);if (!observer.current) {observer.current = new ResizeObserver(entries => {func(entries[0].contentRect);});}- let elementRef = useCallback(el => {+ const elementRef = useCallback(el => {observer.current.disconnect();if (el) {observer.current.observe(el, { box: 'border-box' });diff --git a/packages/desktop-client/src/hooks/useSelected.tsx b/packages/desktop-client/src/hooks/useSelected.tsxindex d9f2404642..f3dfb94dc6 100644--- a/packages/desktop-client/src/hooks/useSelected.tsx+++ b/packages/desktop-client/src/hooks/useSelected.tsx@@ -19,8 +19,8 @@ type Range<T> = { start: T; end: T | null };type Item = { id: string };function iterateRange(range: Range<number>, func: (i: number) => void): void {- let from = Math.min(range.start, range.end);- let to = Math.max(range.start, range.end);+ const from = Math.min(range.start, range.end);+ const to = Math.max(range.start, range.end);for (let i = from; i <= to; i++) {func(i);@@ -55,18 +55,18 @@ export default function useSelected<T extends Item>(initialSelectedIds: string[],selectAllFilter?: (T) => boolean,) {- let [state, dispatch] = useReducer(+ const [state, dispatch] = useReducer((state: State, action: Actions) => {switch (action.type) {case 'select': {- let { selectedRange } = state;- let selectedItems = new Set(state.selectedItems);- let { id, event } = action;+ const { selectedRange } = state;+ const selectedItems = new Set(state.selectedItems);+ const { id, event } = action;if (event.shiftKey && selectedRange) {- let idx = items.findIndex(p => p.id === id);- let startIdx = items.findIndex(p => p.id === selectedRange.start);- let endIdx = items.findIndex(p => p.id === selectedRange.end);+ const idx = items.findIndex(p => p.id === id);+ const startIdx = items.findIndex(p => p.id === selectedRange.start);+ const endIdx = items.findIndex(p => p.id === selectedRange.end);let range: Range<number>;let deleteUntil: Range<number>;@@ -163,7 +163,7 @@ export default function useSelected<T extends Item>(}),);- let prevItems = useRef(items);+ const prevItems = useRef(items);useEffect(() => {if (state.selectedItems.size > 0) {// We need to make sure there are no ids in the selection that@@ -181,14 +181,14 @@ export default function useSelected<T extends Item>(// selected item too early (because the component rerenders// multiple times)- let ids = new Set(items.map(item => item.id));- let isSame =+ const ids = new Set(items.map(item => item.id));+ const isSame =prevItems.current.length === items.length &&prevItems.current.every(item => ids.has(item.id));if (!isSame) {- let selected = [...state.selectedItems];- let filtered = selected.filter(id => ids.has(id));+ const selected = [...state.selectedItems];+ const filtered = selected.filter(id => ids.has(id));// If the selected items has changed, update the selectionif (selected.length !== filtered.length) {@@ -201,18 +201,18 @@ export default function useSelected<T extends Item>(}, [items, state.selectedItems]);useEffect(() => {- let prevState = undo.getUndoState('selectedItems');+ const prevState = undo.getUndoState('selectedItems');undo.setUndoState('selectedItems', { name, items: state.selectedItems });return () => undo.setUndoState('selectedItems', prevState);}, [state.selectedItems]);- let lastUndoState = useSelector(state => state.app.lastUndoState);+ const lastUndoState = useSelector(state => state.app.lastUndoState);useEffect(() => {function onUndo({ messages, undoTag }: UndoState) {- let tagged = undo.getTaggedState(undoTag);+ const tagged = undo.getTaggedState(undoTag);- let deletedIds = new Set(+ const deletedIds = new Set(messages.filter(msg => msg.column === 'tombstone' && msg.value === 1).map(msg => msg.row),@@ -242,8 +242,8 @@ export default function useSelected<T extends Item>(};}-let SelectedDispatch = createContext<(action: Actions) => void>(null);-let SelectedItems = createContext<Set<unknown>>(null);+const SelectedDispatch = createContext<(action: Actions) => void>(null);+const SelectedItems = createContext<Set<unknown>>(null);export function useSelectedDispatch() {return useContext(SelectedDispatch);@@ -264,13 +264,13 @@ export function SelectedProvider<T extends Item>({fetchAllIds,children,}: SelectedProviderProps<T>) {- let latestItems = useRef(null);+ const latestItems = useRef(null);useEffect(() => {latestItems.current = instance.items;}, [instance.items]);- let dispatch = useCallback(+ const dispatch = useCallback(async (action: Actions) => {if (!action.event && isNonProductionEnvironment()) {throw new Error('SelectedDispatch actions must have an event');@@ -327,7 +327,7 @@ export function SelectedProviderWithItems<T extends Item>({selectAllFilter,children,}: SelectedProviderWithItemsProps<T>) {- let selected = useSelected<T>(+ const selected = useSelected<T>(name,items,initialSelectedIds,diff --git a/packages/desktop-client/src/icons/Loading.tsx b/packages/desktop-client/src/icons/Loading.tsxindex 5b19843ad4..c8101941c3 100644--- a/packages/desktop-client/src/icons/Loading.tsx+++ b/packages/desktop-client/src/icons/Loading.tsx@@ -1,8 +1,8 @@import React, { type SVGProps, useState } from 'react';const SvgLoading = (props: SVGProps<SVGSVGElement>) => {- let { color = 'currentColor' } = props;- let [gradientId] = useState('gradient-' + Math.random());+ const { color = 'currentColor' } = props;+ const [gradientId] = useState('gradient-' + Math.random());return (<svg {...props} viewBox="0 0 38 38" style={{ ...props.style }}>diff --git a/packages/desktop-client/src/plaid.js b/packages/desktop-client/src/plaid.jsindex a4b41a4388..7dfd53804b 100644--- a/packages/desktop-client/src/plaid.js+++ b/packages/desktop-client/src/plaid.js@@ -4,7 +4,7 @@ import { send } from 'loot-core/src/platform/client/fetch';function _authorize(pushModal, plaidToken, { onSuccess, onClose }) {pushModal('plaid-external-msg', {onMoveExternal: async () => {- let token = await send('create-web-token');+ const token = await send('create-web-token');let url = 'http://link.actualbudget.com/?token=' + token;// let url = 'http://localhost:8080/?token=' + token;if (plaidToken) {@@ -12,7 +12,7 @@ function _authorize(pushModal, plaidToken, { onSuccess, onClose }) {}window.Actual.openURLInBrowser(url);- let { error, data } = await send('poll-web-token', { token });+ const { error, data } = await send('poll-web-token', { token });return { error, data };},@@ -36,7 +36,7 @@ export async function authorizeBank(pushModal, { upgradingId } = {}) {}export async function reauthorizeBank(pushModal, bankId, onSuccess) {- let { linkToken } = await send('make-plaid-public-token', {+ const { linkToken } = await send('make-plaid-public-token', {bankId,});diff --git a/packages/desktop-client/src/style/styles.ts b/packages/desktop-client/src/style/styles.tsindex 78bf4b7d95..7cd0bb73f2 100644--- a/packages/desktop-client/src/style/styles.ts+++ b/packages/desktop-client/src/style/styles.ts@@ -157,11 +157,11 @@ function onScrollbarChange() {if (Platform.env === 'web') {function testScrollbars() {- let el = document.createElement('div');+ const el = document.createElement('div');el.innerHTML ='<div style="width:100px;height:100px;overflow:scroll;position:absolute;top:-9999px;"/>';document.body.appendChild(el);- let testNode = el.childNodes[0] as HTMLDivElement;+ const testNode = el.childNodes[0] as HTMLDivElement;if (testNode.offsetWidth === testNode.clientWidth) {return true;}diff --git a/packages/desktop-client/src/style/theme.tsx b/packages/desktop-client/src/style/theme.tsxindex 49d87451fe..322de92bf3 100644--- a/packages/desktop-client/src/style/theme.tsx+++ b/packages/desktop-client/src/style/theme.tsx@@ -24,9 +24,9 @@ export function useTheme() {}export function ThemeStyle() {- let theme = useTheme();- let themeColors = themes[theme].colors;- let css = Object.keys(themeColors)+ const theme = useTheme();+ const themeColors = themes[theme].colors;+ const css = Object.keys(themeColors).map(key => ` --color-${key}: ${themeColors[key]};`).join('\n');return <style>{`:root {\n${css}}`}</style>;diff --git a/packages/desktop-client/src/util/router-tools.tsx b/packages/desktop-client/src/util/router-tools.tsxindex ec4b37bbf2..f35a33560f 100644--- a/packages/desktop-client/src/util/router-tools.tsx+++ b/packages/desktop-client/src/util/router-tools.tsx@@ -3,7 +3,7 @@ import { useLayoutEffect } from 'react';import useNavigate from '../hooks/useNavigate';export function ExposeNavigate() {- let navigate = useNavigate();+ const navigate = useNavigate();useLayoutEffect(() => {window.__navigate = navigate;}, [navigate]);diff --git a/packages/desktop-client/src/util/versions.ts b/packages/desktop-client/src/util/versions.tsindex d483aa1543..e9fbef569c 100644--- a/packages/desktop-client/src/util/versions.ts+++ b/packages/desktop-client/src/util/versions.ts@@ -11,8 +11,8 @@ function cmpSemanticVersion(versionStringA: string,versionStringB: string,): number {- let x = parseSemanticVersion(versionStringA);- let y = parseSemanticVersion(versionStringB);+ const x = parseSemanticVersion(versionStringA);+ const y = parseSemanticVersion(versionStringB);return x[0] - y[0] || x[1] - y[1] || x[2] - y[2];}@@ -23,11 +23,11 @@ export async function getLatestVersion(): Promise<string | 'unknown'> {}try {- let response = await fetch(+ const response = await fetch('https://api.github.com/repos/actualbudget/actual/tags',);- let json = await response.json();- let tags = json+ const json = await response.json();+ const tags = json.map(t => t.name).concat([`v${window.Actual.ACTUAL_VERSION}`]);tags.sort(cmpSemanticVersion);@@ -40,7 +40,7 @@ export async function getLatestVersion(): Promise<string | 'unknown'> {}export async function getIsOutdated(latestVersion: string): Promise<boolean> {- let clientVersion = window.Actual.ACTUAL_VERSION;+ const clientVersion = window.Actual.ACTUAL_VERSION;if (latestVersion === 'unknown') {return Promise.resolve(false);}diff --git a/packages/desktop-electron/afterSignHook.js b/packages/desktop-electron/afterSignHook.jsindex 1eb1f69427..68355d056a 100644--- a/packages/desktop-electron/afterSignHook.js+++ b/packages/desktop-electron/afterSignHook.js@@ -1,7 +1,7 @@const fs = require('fs');const path = require('path');-let electron_notarize = require('electron-notarize');+const electron_notarize = require('electron-notarize');// This is expected to be run by `electron-builder` after it signs the build.// It's disabled for now as we currently don't sign builds after Actual being open sourced.@@ -16,9 +16,9 @@ module.exports = async function (params) {}// Same appId in electron-builder.- let appId = 'com.shiftreset.actual';+ const appId = 'com.shiftreset.actual';- let appPath = path.join(+ const appPath = path.join(params.appOutDir,`${params.packager.appInfo.productFilename}.app`,);diff --git a/packages/desktop-electron/index.js b/packages/desktop-electron/index.jsindex f67e4b678b..a2755a41f9 100644--- a/packages/desktop-electron/index.js+++ b/packages/desktop-electron/index.js@@ -188,7 +188,7 @@ async function createWindow() {});win.on('focus', async () => {- let url = clientWin.webContents.getURL();+ const url = clientWin.webContents.getURL();if (url.includes('app://') || url.includes('localhost:')) {clientWin.webContents.executeJavaScript('__actionsForMenu.focused()');}@@ -239,7 +239,7 @@ function updateMenu(isBudgetOpen) {.filter(item => item.label === 'Load Backup...').map(item => (item.enabled = isBudgetOpen));- let tools = menu.items.filter(item => item.label === 'Tools')[0];+ const tools = menu.items.filter(item => item.label === 'Tools')[0];tools.submenu.items.forEach(item => {item.enabled = isBudgetOpen;});@@ -356,7 +356,7 @@ ipcMain.handle('open-file-dialog', (event, { filters, properties }) => {ipcMain.handle('save-file-dialog',(event, { title, defaultPath, fileContents }) => {- let fileLocation = dialog.showSaveDialogSync({ title, defaultPath });+ const fileLocation = dialog.showSaveDialogSync({ title, defaultPath });return new Promise((resolve, reject) => {if (fileLocation) {@@ -379,7 +379,7 @@ ipcMain.on('show-about', () => {ipcMain.on('screenshot', () => {if (isDev) {- let width = 1100;+ const width = 1100;// This is for the main screenshot inside the frameclientWin.setSize(width, Math.floor(width * (427 / 623)));@@ -409,7 +409,7 @@ ipcMain.on('update-menu', (event, isBudgetOpen) => {});ipcMain.on('set-theme', theme => {- let obj = { theme: theme };+ const obj = { theme: theme };clientWin.webContents.executeJavaScript(`window.__actionsForMenu && window.__actionsForMenu.saveGlobalPrefs(${obj})`,diff --git a/packages/desktop-electron/menu.js b/packages/desktop-electron/menu.jsindex 09d8fc9d72..b6fa34657d 100644--- a/packages/desktop-electron/menu.js+++ b/packages/desktop-electron/menu.js@@ -211,7 +211,7 @@ function getMenu(isDev, createWindow) {].filter(x => x),});// Edit menu.- let editIdx = template.findIndex(t => t.label === 'Edit');+ const editIdx = template.findIndex(t => t.label === 'Edit');template[editIdx].submenu.push({type: 'separator',@@ -229,7 +229,7 @@ function getMenu(isDev, createWindow) {},);// Window menu.- let windowIdx = template.findIndex(t => t.role === 'window');+ const windowIdx = template.findIndex(t => t.role === 'window');template[windowIdx].submenu = [{label: 'Close',diff --git a/packages/desktop-electron/preload.js b/packages/desktop-electron/preload.jsindex 759d4fc201..8aac6545db 100644--- a/packages/desktop-electron/preload.js+++ b/packages/desktop-electron/preload.js@@ -1,10 +1,10 @@const { ipcRenderer, contextBridge } = require('electron');-let { version: VERSION, isDev: IS_DEV } =+const { version: VERSION, isDev: IS_DEV } =ipcRenderer.sendSync('get-bootstrap-data');let resolveSocketPromise;-let socketPromise = new Promise(resolve => {+const socketPromise = new Promise(resolve => {resolveSocketPromise = resolve;});diff --git a/packages/desktop-electron/security.js b/packages/desktop-electron/security.jsindex b7235567e6..a3f43a2274 100644--- a/packages/desktop-electron/security.js+++ b/packages/desktop-electron/security.js@@ -30,7 +30,7 @@ electron.app.on('ready', function () {permission,callback,) {- let url = webContents.getURL();+ const url = webContents.getURL();if (url.startsWith('file://')) {callback(true);} else {diff --git a/packages/desktop-electron/server.js b/packages/desktop-electron/server.jsindex d8c02c0442..109fb02336 100644--- a/packages/desktop-electron/server.js+++ b/packages/desktop-electron/server.js@@ -10,9 +10,9 @@ function getBackend() {}if (process.argv[2] === '--subprocess') {- let isDev = false;+ const isDev = false;// let version = process.argv[3];- let socketName = process.argv[4];+ const socketName = process.argv[4];// Start the appgetBackend().initApp(isDev, socketName);@@ -20,8 +20,8 @@ if (process.argv[2] === '--subprocess') {require('source-map-support').install();getBackend().initApp(true, 'actual-standalone');} else {- let { ipcRenderer } = require('electron');- let isDev = true;+ const { ipcRenderer } = require('electron');+ const isDev = true;ipcRenderer.on('set-socket', (event, { name }) => {// Start the appdiff --git a/packages/desktop-electron/updater.js b/packages/desktop-electron/updater.jsindex df447317e2..3a9edae4be 100644--- a/packages/desktop-electron/updater.js+++ b/packages/desktop-electron/updater.js@@ -2,7 +2,7 @@ const isDev = require('electron-is-dev');const { autoUpdater } = require('electron-updater');// Every 5 minutes-let INTERVAL = 1000 * 60 * 5;+const INTERVAL = 1000 * 60 * 5;let updateTimer = null;let isCheckingForUpdates = false;let emitEvent = null;diff --git a/packages/desktop-electron/window-state.js b/packages/desktop-electron/window-state.jsindex 27f9c51fd2..205c881621 100644--- a/packages/desktop-electron/window-state.js+++ b/packages/desktop-electron/window-state.js@@ -1,10 +1,10 @@-let fs = require('fs');-let path = require('path');+const fs = require('fs');+const path = require('path');-let electron = require('electron');+const electron = require('electron');// eslint-disable-next-line import/extensions-let backend = require('loot-core/lib-dist/bundle.desktop.js');+const backend = require('loot-core/lib-dist/bundle.desktop.js');function loadState() {let state = {};diff --git a/upcoming-release-notes/1956.md b/upcoming-release-notes/1956.mdnew file mode 100644index 0000000000..0919a55dcc--- /dev/null+++ b/upcoming-release-notes/1956.md@@ -0,0 +1,6 @@+---+category: Maintenance+authors: [joel-jeremy]+---++ESLint prefer-const rule