Skip to content

A local-first personal finance app

Adjust account panel borders and corners (#5958)

Matiss Janis Aboltins8b1aa6fb93d1
diff --git a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png
index ebbccbeddd..d80092f6df 100644
Binary files a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png and b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-1-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png
index ecc8281da9..0d5399d877 100644
Binary files a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png and b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png
index 0d62a337f0..790055f7b9 100644
Binary files a/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png and b/packages/desktop-client/e2e/accounts.mobile.test.ts-snapshots/Mobile-Accounts-opens-the-accounts-page-and-asserts-on-balances-3-chromium-linux.png differ
diff --git a/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx b/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx
index a731702255..04651e1fb7 100644
--- a/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx
+++ b/packages/desktop-client/src/components/mobile/accounts/AccountsPage.tsx
@@ -156,7 +156,16 @@ function AccountListItem({
}
return (
- <ListBoxItem textValue={account.name} {...props}>
+ <ListBoxItem
+ textValue={account.name}
+ className={css({
+ borderBottom: `1px solid ${theme.tableBorder}`,
+ '&:last-child': {
+ borderBottom: 'none',
+ },
+ })}
+ {...props}
+ >
{itemProps => (
<Button
{...itemProps}
@@ -164,7 +173,8 @@ function AccountListItem({
height: ROW_HEIGHT,
width: '100%',
backgroundColor: theme.tableBackground,
- border: `1px solid ${theme.tableBorder}`,
+ border: 'none',
+ borderRadius: 0,
paddingLeft: 20,
}}
data-testid="account-list-item"
@@ -470,7 +480,14 @@ const AccountList = forwardRef<HTMLDivElement, AccountListProps>(
items={accounts}
dragAndDropHooks={dragAndDropHooks}
ref={ref}
- style={{ display: 'flex', flexDirection: 'column', margin: '0 8px' }}
+ style={{
+ display: 'flex',
+ flexDirection: 'column',
+ margin: '0 8px',
+ border: `1px solid ${theme.tableBorder}`,
+ borderRadius: 8,
+ overflow: 'hidden',
+ }}
>
{account => (
<AccountListItem
diff --git a/upcoming-release-notes/5958.md b/upcoming-release-notes/5958.md
new file mode 100644
index 0000000000..6dfa89f4ce
--- /dev/null
+++ b/upcoming-release-notes/5958.md
@@ -0,0 +1,7 @@
+---
+category: Enhancements
+authors: [MatissJanis]
+---
+
+Adjust account panel borders for a cohesive appearance by modifying item border styling.
+