A local-first personal finance app
Proposal - Disable Save Button in Mobile Transaction View if field is edited (#2214)
HansiWursti8b968579b134
diff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.pngindex 71c34be425..1aeaa14f98 100644Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.pngindex 885ad0401f..76c562bd18 100644Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.pngindex f66759c318..39f7c042e3 100644Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.pngindex 3f118cdc0a..8320db5365 100644Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.pngindex 3404a4f5b3..591897b5a4 100644Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png differdiff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.pngindex 6bb639fa3d..3d879590fd 100644Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png differdiff --git a/packages/desktop-client/src/components/transactions/MobileTransaction.jsx b/packages/desktop-client/src/components/transactions/MobileTransaction.jsxindex e3b9deb81c..e78adfaf99 100644--- a/packages/desktop-client/src/components/transactions/MobileTransaction.jsx+++ b/packages/desktop-client/src/components/transactions/MobileTransaction.jsx@@ -186,6 +186,7 @@ function Footer({onSplit,onAddSplit,onEmptySplitFound,+ editingField,}) {const [transaction, ...childTransactions] = transactions;const onClickRemainingSplit = () => {@@ -217,6 +218,7 @@ function Footer({<Buttontype="primary"style={{ height: 40 }}+ disabled={editingField}onClick={onClickRemainingSplit}onPointerDown={e => e.preventDefault()}>@@ -237,19 +239,16 @@ function Footer({</Button>) : adding ? (<Button+ type="primary"style={{ height: 40 }}+ disabled={editingField}onClick={onAdd}onPointerDown={e => e.preventDefault()}>- <SvgAdd- width={17}- height={17}- style={{ color: theme.formLabelText }}- />+ <SvgAdd width={17} height={17} /><Textstyle={{...styles.text,- color: theme.formLabelText,marginLeft: 5,}}>@@ -258,22 +257,17 @@ function Footer({</Button>) : (<Button+ type="primary"style={{ height: 40 }}+ disabled={editingField}onClick={onSave}onPointerDown={e => e.preventDefault()}>- <SvgPencilWriteAlternate- width={16}- height={16}- style={{- color: theme.formLabelText,- }}- />+ <SvgPencilWriteAlternate width={16} height={16} /><Textstyle={{...styles.text,marginLeft: 6,- color: theme.formLabelText,}}>Save changes@@ -678,6 +672,7 @@ const TransactionEditInner = memo(function TransactionEditInner({onSplit={onSplit}onAddSplit={onAddSplit}onEmptySplitFound={onEmptySplitFound}+ editingField={editingField}/>}padding={0}diff --git a/upcoming-release-notes/2214.md b/upcoming-release-notes/2214.mdnew file mode 100644index 0000000000..b1ae5edaea--- /dev/null+++ b/upcoming-release-notes/2214.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [HansiWursti]+---++Mobile - Disable Save Button while editing Transaction Fields - Fixes #2203\ No newline at end of file