A local-first personal finance app
Fix translate rule stages (#5421)
milanalexandre8f69669cc697
diff --git a/packages/desktop-client/e2e/help-menu.test.ts b/packages/desktop-client/e2e/help-menu.test.tsindex 779849bef1..f3bd8a8ab4 100644--- a/packages/desktop-client/e2e/help-menu.test.ts+++ b/packages/desktop-client/e2e/help-menu.test.ts@@ -28,6 +28,7 @@ test.describe('Help menu', () => {await page.getByRole('button', { name: 'Help' }).click();expect(page.getByText('Keyboard shortcuts')).toBeVisible();await expect(page).toMatchThemeScreenshots();+ await page.keyboard.press('Escape');});test('Check the keyboard shortcuts modal visuals', async () => {diff --git a/packages/desktop-client/src/components/rules/RuleRow.tsx b/packages/desktop-client/src/components/rules/RuleRow.tsxindex dae17a8ccb..6d0951e001 100644--- a/packages/desktop-client/src/components/rules/RuleRow.tsx+++ b/packages/desktop-client/src/components/rules/RuleRow.tsx@@ -13,7 +13,7 @@ import { theme } from '@actual-app/components/theme';import { View } from '@actual-app/components/view';import { v4 as uuid } from 'uuid';-import { friendlyOp } from 'loot-core/shared/rules';+import { friendlyOp, translateRuleStage } from 'loot-core/shared/rules';import { type RuleEntity } from 'loot-core/types/models';import { ActionExpression } from './ActionExpression';@@ -138,7 +138,7 @@ export const RuleRow = memo(padding: '3px 5px',}}>- {rule.stage}+ {translateRuleStage(rule.stage)}</View>)}</Cell>diff --git a/packages/loot-core/src/shared/rules.ts b/packages/loot-core/src/shared/rules.tsindex 83ffdcb785..39ae6cb157 100644--- a/packages/loot-core/src/shared/rules.ts+++ b/packages/loot-core/src/shared/rules.ts@@ -232,6 +232,17 @@ export function friendlyOp(op, type?) {}}+export function translateRuleStage(stage: string): string {+ switch (stage) {+ case 'pre':+ return t('Pre');+ case 'post':+ return t('Post');+ default:+ return '';+ }+}+export function deserializeField(field) {if (field === 'amount-inflow') {return { field: 'amount', options: { inflow: true } };diff --git a/upcoming-release-notes/5421.md b/upcoming-release-notes/5421.mdnew file mode 100644index 0000000000..a0ac0fc24d--- /dev/null+++ b/upcoming-release-notes/5421.md@@ -0,0 +1,6 @@+---+category: Bugfix+authors: [milanalexandre]+---++add translation support for rule stages